Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pylint - enforce singleton-comparison check #4625

Merged
merged 4 commits into from
Nov 4, 2021

Conversation

pavoljuhas
Copy link
Collaborator

Correct few lint issues that show after enabling singleton-comparison check.

@pavoljuhas pavoljuhas requested a review from maffoo November 4, 2021 03:24
@CirqBot CirqBot added the size: S 10< lines changed <50 label Nov 4, 2021
@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Nov 4, 2021
@MichaelBroughton MichaelBroughton self-assigned this Nov 4, 2021
Copy link
Collaborator

@MichaelBroughton MichaelBroughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thx!

@MichaelBroughton MichaelBroughton added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Nov 4, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Nov 4, 2021
@CirqBot CirqBot merged commit d1e7228 into quantumlib:master Nov 4, 2021
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Nov 4, 2021
@pavoljuhas pavoljuhas deleted the pylint-singleton-comparison branch November 5, 2021 01:55
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
Correct few lint issues that show after enabling singleton-comparison check.
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
Correct few lint issues that show after enabling singleton-comparison check.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Makes googlebot stop complaining. size: S 10< lines changed <50
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants