Minor cleanup in QCS Getting Started tutorial #4575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…string instead of hardcoded pacific at multiple places
tanujkhattar
requested review from
cduck,
vtomole,
wcourtney and
a team
as code owners
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
tanujkhattar
changed the title
MichaelBroughton
approved these changes
Oct 14, 2021
| @@ -164,7 +164,7 @@ | |||
| "\n", | |||
| "# The Google Cloud Project id to use.\n", | |||
| "project_id = \"\" #@param {type:\"string\"}\n", | |||
| "processor_id = \"\" #@param {type:\"string\"}\n", | |||
There was a problem hiding this comment.
Should we make it weber ?
There was a problem hiding this comment.
At this point, weber is turning down too. Given churn, maybe we should force users to choose and guide them through listing available processors if this is left unset?
tanujkhattar
added
the
automerge
wcourtney
approved these changes
Jan 25, 2022
| @@ -164,7 +164,7 @@ | |||
| "\n", | |||
| "# The Google Cloud Project id to use.\n", | |||
| "project_id = \"\" #@param {type:\"string\"}\n", | |||
| "processor_id = \"\" #@param {type:\"string\"}\n", | |||
There was a problem hiding this comment.
At this point, weber is turning down too. Given churn, maybe we should force users to choose and guide them through listing available processors if this is left unset?
CirqBot
added
the
front_of_queue_automerge
|
Automerge cancelled: A status check is failing. |
CirqBot
removed
automerge
MichaelBroughton
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
Modify QCS Getting Started tutorial to reuse the setup processord_id string instead of hardcoded pacific at multiple places
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify QCS Getting Started tutorial to reuse the setup processord_id string instead of hardcoded pacific at multiple places