Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dict.itervalues, which does not exist in python3 #4

Merged
merged 1 commit into from
Jan 10, 2018
Merged

Remove dict.itervalues, which does not exist in python3 #4

merged 1 commit into from
Jan 10, 2018

Conversation

maffoo
Copy link
Contributor

@maffoo maffoo commented Jan 10, 2018

3to2 doesn't translate this back to itervalues for python2, unfortunately, but I don't think that should be too much of a performance hit.

@maffoo maffoo requested a review from dabacon January 10, 2018 00:55
@Strilanc
Copy link
Contributor

So much for our tacit agreement to run the tests before pushing. I'll get to work on a script to run the tests and push a status.

Strilanc
Strilanc approved these changes Jan 10, 2018
View reviewed changes
Copy link
Contributor

@Strilanc Strilanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maffoo maffoo merged commit 1a0705f into quantumlib:master Jan 10, 2018
@maffoo maffoo deleted the dict-values branch January 10, 2018 00:58
peterse added a commit to peterse/Cirq that referenced this pull request Jun 26, 2019
@peterse
linting quantumlib#4, pr tweaks
7fc2ce1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Strilanc Strilanc Strilanc approved these changes

@dabacon dabacon Awaiting requested review from dabacon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maffoo @Strilanc