Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow qubit_map with conflicting dimensions in subcircuits #3983

Merged
merged 1 commit into from
Apr 1, 2021
Merged

Disallow qubit_map with conflicting dimensions in subcircuits #3983

merged 1 commit into from
Apr 1, 2021

Conversation

daxfohl
Copy link
Contributor

@daxfohl daxfohl commented Apr 1, 2021

Fixes #3982

@daxfohl daxfohl requested review from cduck, vtomole and a team as code owners April 1, 2021 01:30
@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Apr 1, 2021
95-martin-orion
95-martin-orion approved these changes Apr 1, 2021
View reviewed changes
Copy link
Collaborator

@95-martin-orion 95-martin-orion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@95-martin-orion 95-martin-orion merged commit ff8fb57 into quantumlib:master Apr 1, 2021
@daxfohl daxfohl deleted the dimensionfix branch April 1, 2021 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@95-martin-orion 95-martin-orion 95-martin-orion approved these changes

@cduck cduck Awaiting requested review from cduck

@vtomole vtomole Awaiting requested review from vtomole

Assignees
No one assigned
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CircuitOperation.qubit_map allows mapping qubits of different dimension
2 participants
@daxfohl @95-martin-orion