Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type annotations for optimization_pass #3962

Merged
merged 6 commits into from
Mar 24, 2021
Merged

Type annotations for optimization_pass #3962

merged 6 commits into from
Mar 24, 2021

Conversation

vtomole
Copy link
Collaborator

@vtomole vtomole commented Mar 23, 2021

Part of: #554

@vtomole vtomole requested review from cduck, wcourtney and a team as code owners March 23, 2021 22:23
@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Mar 23, 2021
@vtomole vtomole changed the title Type annotation for optimization_pass Type annotations for optimization_pass Mar 23, 2021
95-martin-orion
95-martin-orion requested changes Mar 23, 2021
View reviewed changes
Copy link
Collaborator

@95-martin-orion 95-martin-orion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Top-level comment: don't add cirq imports for type annotations. Instead, use 'cirq.{TYPE}'. Other imports (like from typing import Optional) are fine.

Other than that, looks good to me.

cirq/circuits/optimization_pass_test.py Outdated Show resolved Hide resolved
cirq/circuits/optimization_pass_test.py Outdated Show resolved Hide resolved
@vtomole vtomole requested a review from 95-martin-orion March 24, 2021 15:07
@vtomole
Copy link
Collaborator Author

vtomole commented Mar 24, 2021

@95-martin-orion PTAL

@95-martin-orion 95-martin-orion added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Mar 24, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Mar 24, 2021
@CirqBot CirqBot merged commit ce9fde6 into quantumlib:master Mar 24, 2021
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@95-martin-orion 95-martin-orion 95-martin-orion approved these changes

@cduck cduck Awaiting requested review from cduck

@wcourtney wcourtney Awaiting requested review from wcourtney

Assignees
No one assigned
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vtomole @95-martin-orion @CirqBot