Improve type safety with generics on simulators #3818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxfohl
requested review from
cduck,
mrwojtek,
vtomole,
wcourtney and
a team
as code owners
daxfohl
commented
Feb 17, 2021
95-martin-orion
requested changes
Feb 17, 2021
95-martin-orion
requested changes
Feb 17, 2021
95-martin-orion
approved these changes
Feb 17, 2021
95-martin-orion
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
|
I think there are some open issues complaining about some of these things? Can you find them and see if this addresses them? |
|
@mpharrigan There was only #554 about the general problem from a while ago. Added a link there but there's still more work to be done before closing that particular issue. There are some other open type issues around gates and operations, parameters, and such but I didn't see any open issues referring specifically to simulators. |
|
Does this PR address #2413? |
|
Oh, I didn't see that one. Yes, that should be fixed now.
…On Fri, Feb 19, 2021, 1:17 PM Matthew Harrigan ***@***.***> wrote:
Does this PR address #2413
<#2413>?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3818 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAG464IZ22HW3S6AAU53KSDS73INTANCNFSM4XYUOBRA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.