-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CircuitOperation crashes simulation if parameters come from the main circuit #5016
Labels
kind/bug-report
Something doesn't seem to work.
Comments
Looks like the root cause is already documented in #3619, however leaving this open for now since that is a feature request while this is a bug. |
This was referenced Feb 25, 2022
CirqBot
pushed a commit
that referenced
this issue
Mar 1, 2022
Preserves existing behavior in circuitoperations, where `with_params({a: b, b: a})` just swaps the parameter names and preserves that behavior for subsequent application (we don't change like 613), but we allow optional recursive application for each individual resolution applied (line 614). @95-martin-orion Fixes #5016 Closes #3619
95-martin-orion
pushed a commit
to 95-martin-orion/Cirq
that referenced
this issue
Mar 2, 2022
Preserves existing behavior in circuitoperations, where `with_params({a: b, b: a})` just swaps the parameter names and preserves that behavior for subsequent application (we don't change like 613), but we allow optional recursive application for each individual resolution applied (line 614). @95-martin-orion Fixes quantumlib#5016 Closes quantumlib#3619
rht
pushed a commit
to rht/Cirq
that referenced
this issue
May 1, 2023
Preserves existing behavior in circuitoperations, where `with_params({a: b, b: a})` just swaps the parameter names and preserves that behavior for subsequent application (we don't change like 613), but we allow optional recursive application for each individual resolution applied (line 614). @95-martin-orion Fixes quantumlib#5016 Closes quantumlib#3619
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this issue
Oct 31, 2024
Preserves existing behavior in circuitoperations, where `with_params({a: b, b: a})` just swaps the parameter names and preserves that behavior for subsequent application (we don't change like 613), but we allow optional recursive application for each individual resolution applied (line 614). @95-martin-orion Fixes quantumlib#5016 Closes quantumlib#3619
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description of the issue
If there's a parameterized operation in a subcircuit, it crashes when passing the param resolver into
simulate
.How to reproduce the issue
raises
stack trace
Cirq version
0.14.0.dev
The text was updated successfully, but these errors were encountered: