-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cirq.plot_density_matrix
outputs buggy plots (abstract art) and doesn't scale with number of qubits.
#4804
Comments
cirq.plot_density_matrix
outputs random plots and doesn't scale with number of qubits. cirq.plot_density_matrix
outputs buggy plots and doesn't scale with number of qubits.
It does look like some sort of abstract art, though :) |
cirq.plot_density_matrix
outputs buggy plots and doesn't scale with number of qubits. cirq.plot_density_matrix
outputs buggy plots (abstract art) and doesn't scale with number of qubits.
@dabacon Updated the title to better reflect what's happening :P |
The plotting positions were dividing by cell size instead of multiplying, fixed that.
I have no idea how all the multiply operations were written as divide, I had made the mistake but I remember that things were working last I checked. Anyways, fixed this, please lemme know if stuff is working now. Not sure if adding a test here would help, maybe I can add that radius of any circle should not be more than 1 and same with with length of any line. |
The plotting positions were dividing by cell size instead of multiplying, fixed that. Closes #4804.
The plotting positions were dividing by cell size instead of multiplying, fixed that. Closes quantumlib#4804.
The plotting positions were dividing by cell size instead of multiplying, fixed that. Closes quantumlib#4804.
The plotting positions were dividing by cell size instead of multiplying, fixed that. Closes quantumlib#4804.
Description of the issue
cirq.plot_density_matrix
is buggy and output's random plots (tested in a colab) and would also doesn't scale well with number of qubits.My guess is that this due to the magic numbers hardcoded in the code, which should be changed and computed on the fly based on the size of the density matrix.
Cirq/cirq-core/cirq/vis/density_matrix.py
Line 39 in 09a4667
How to reproduce the issue
Cirq version
0.14.0.dev20220105215702
cc @AnimeshSinha1309
The text was updated successfully, but these errors were encountered: