Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check/all fails because it runs rigetti tests #4660

Closed
dabacon opened this issue Nov 11, 2021 · 2 comments · Fixed by #5632
Closed

check/all fails because it runs rigetti tests #4660

dabacon opened this issue Nov 11, 2021 · 2 comments · Fixed by #5632
Assignees
@dstrain115
Labels
area/ci area/testing kind/health For CI/testing/release process/refactoring/technical debt items priority/p1 Fix is needed as soon as possible. Should be staffed. It is blocking some major flows for users triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on

Comments

@dabacon
Copy link
Collaborator

dabacon commented Nov 11, 2021

One a clean dev install (with qiskit fix #4659) and docker installed, check/all fails becaused it attempts to run the rigetti integration tests. This is caused by it calling check/pytest-and-incremental-coverage. In contrast check/pytest does not run these tests.
@dabacon dabacon added the kind/health For CI/testing/release process/refactoring/technical debt items label Nov 11, 2021
@viathor viathor added triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on area/ci area/testing labels Nov 17, 2021
@vtomole vtomole mentioned this issue Nov 20, 2021
Closed
@dstrain115 dstrain115 self-assigned this Apr 7, 2022
@dabacon
Copy link
Collaborator Author

dabacon commented Jun 9, 2022

This really doesn't need to be done before 1.0, it doesn't define a new API. @dstrain115 @MichaelBroughton

@dstrain115 dstrain115 added the priority/p1 Fix is needed as soon as possible. Should be staffed. It is blocking some major flows for users label Jun 9, 2022
@dstrain115
Copy link
Collaborator

SGTM. I'll put it as P1, since it would be nice to fix all these tests and make everything cleaner, but it can be post-poned until after launch.

@dabacon dabacon mentioned this issue Jun 27, 2022
Merged
CirqBot pushed a commit that referenced this issue Jun 27, 2022
@dabacon
Remove Rigetti from local checks (#5632)
abdb5b6 
This remove the rigetti integration tests from the default of `pytest-and-incremental-coverage` and hence of `all`.  It keeps these tests in the CI workflow.  

The alternative to this would be to add the docker up and down to these scripts, but I'm hesitant to do this as these download external docker images.

Fixes #4660
rht pushed a commit to rht/Cirq that referenced this issue May 1, 2023
@dabacon @rht
Remove Rigetti from local checks (quantumlib#5632)
0a4443e 
This remove the rigetti integration tests from the default of `pytest-and-incremental-coverage` and hence of `all`.  It keeps these tests in the CI workflow.  

The alternative to this would be to add the docker up and down to these scripts, but I'm hesitant to do this as these download external docker images.

Fixes quantumlib#4660
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dstrain115 dstrain115

Labels
area/ci area/testing kind/health For CI/testing/release process/refactoring/technical debt items priority/p1 Fix is needed as soon as possible. Should be staffed. It is blocking some major flows for users triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove Rigetti from local checks dabacon/Cirq
4 participants
@dabacon @tanujkhattar @dstrain115 @viathor