Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PointOptimizer that respects moment structure #2406

Closed
mpharrigan opened this issue Oct 25, 2019 · 2 comments
Closed

PointOptimizer that respects moment structure #2406

mpharrigan opened this issue Oct 25, 2019 · 2 comments
Assignees
@tanujkhattar
Labels
area/transformers kind/design-issue A conversation around design kind/feature-request Describes new functionality status/needs-agreed-design We want to do this, but it needs an agreed upon design before implementation triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on

Comments

@mpharrigan
Copy link
Collaborator

Right now ops get flattened during initialization of PointOptimizationSummary and during circuit.insert_at_frontier. Would be nice to be able to transform circuits in a more structured way
@mpharrigan mpharrigan mentioned this issue Oct 30, 2019
Merged
CirqBot pushed a commit that referenced this issue Nov 5, 2019
@mpharrigan @CirqBot
PointOptimizerSummary option to avoid flattening (#2461)
d7fefa8 
This isn't actually enough as the point optimizer will flatten it (again). But this *does* make it so I can write my own PointOptimizer replacement that can respect it

xref #2406
@mpharrigan mpharrigan mentioned this issue Nov 14, 2019
Closed
@mpharrigan mpharrigan mentioned this issue Nov 22, 2019
Merged
@Strilanc Strilanc added kind/design-issue A conversation around design kind/feature-request Describes new functionality triage/discuss Needs decision / discussion, bring these up during Cirq Cynque labels Sep 22, 2020
@tanujkhattar tanujkhattar added status/needs-agreed-design We want to do this, but it needs an agreed upon design before implementation triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on and removed triage/discuss Needs decision / discussion, bring these up during Cirq Cynque labels Oct 13, 2021
@tanujkhattar
Copy link
Collaborator

I'll marked this as fixed given the new moment preserving primitives, which are now intended to replace PointOptimizer completely. Please feel free to file another issue if you run into a scenario where the newly added moment preserving primitives are not sufficient and you need a moment preserving version of PointOptimizer.

@tanujkhattar
Copy link
Collaborator

#5154 adds a tutorial to Cirq on new transformer infrastructure, with details of newly added moment preserving primitives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tanujkhattar tanujkhattar

Labels
area/transformers kind/design-issue A conversation around design kind/feature-request Describes new functionality status/needs-agreed-design We want to do this, but it needs an agreed upon design before implementation triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Strilanc @balopat @mpharrigan @tanujkhattar