Skip to content

Commit

Permalink
Fix ci-daily notebook failures on Mac OS X (#6444)
Browse files Browse the repository at this point in the history
Use common version specification for quimb and numba as defined in
contrib/requirements.txt.  And install notebook dependencies for all CI platforms.

Avoid incompatible versions of quimb and numba in notebook environments.

Example failure: https://github.com/quantumlib/Cirq/actions/runs/7792626671/job/21250976788#step:6:580

Fix verified at https://github.com/quantumlib/Cirq/actions/runs/7805446772

Related to #6336
  • Loading branch information
pavoljuhas authored Feb 7, 2024
1 parent 57c52fe commit 36e91b0
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
6 changes: 4 additions & 2 deletions .github/workflows/ci-daily.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ jobs:
pip install \
-r dev_tools/requirements/deps/format.txt \
-r dev_tools/requirements/deps/pylint.txt \
-r dev_tools/requirements/deps/pytest.txt
-r dev_tools/requirements/deps/pytest.txt \
-r dev_tools/requirements/deps/notebook.txt
- name: Run Quil dependencies
run: docker-compose -f cirq-rigetti/docker-compose.test.yaml up -d
- name: Pytest check
Expand Down Expand Up @@ -60,7 +61,8 @@ jobs:
pip install --pre cirq &&
pip install -r dev_tools/requirements/deps/format.txt &&
pip install -r dev_tools/requirements/deps/pylint.txt &&
pip install -r dev_tools/requirements/deps/pytest.txt
pip install -r dev_tools/requirements/deps/pytest.txt &&
pip install -r dev_tools/requirements/deps/notebook.txt
- name: Pytest Windows
run: check/pytest -n auto --ignore=cirq-core/cirq/contrib --enable-slow-tests
shell: bash
Expand Down
4 changes: 3 additions & 1 deletion dev_tools/requirements/deps/notebook.txt
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@ ipykernel==5.3.4

# for executing notebooks in tests
papermill~=2.3.2
quimb~=1.6.0

# for notebooks that do `pip install cirq-core[contrib]`
-r ../../../cirq-core/cirq/contrib/requirements.txt

# assumed to be part of colab
seaborn~=0.11.1

0 comments on commit 36e91b0

Please sign in to comment.