-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get version number dynamically from tag #244
Conversation
Preview page for your plugin is ready here: |
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #244 +/- ##
==========================================
+ Coverage 82.94% 82.98% +0.04%
==========================================
Files 19 19
Lines 1560 1552 -8
Branches 263 260 -3
==========================================
- Hits 1294 1288 -6
+ Misses 191 190 -1
+ Partials 75 74 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Only concern is the possibility of a mismatch between the compiled version and the python library. I guess that now we have the CI compilation it should be less of an issue.
Yes, unfortunately that problem may exist but shouldn't be that common. As long as it is made clear to users who are developing locally that you must run |
Fixes #219.
Following #231 the shared libraries are now built dynamically in CI. As a result,
VERSION.txt
is not needed, as we can dynamically get the version from the current tag.The main advantage of this is it's one less thing to remember to update. Another is that we can have a current development version. For example, for me locally:
prints
0.5.1.dev160+g4a43956.d20230322
.