Add option to keep all attributes as strings #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 88f5cea The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
When data is coming from user supplied HTML, I would expect all attributes to come in as strings. Instead this library converts boolean strings "true" and "false" to boolean primitives. My use-case is very heavy on custom components, many of which do string operations on the incoming data. For example we have one that passes in a a path to get properties off of an object, that path can be the string literal values "true"/"false". It would be nice to be able to toggle off the feature that converts booleans.
RichardCzechowski
force-pushed
the
option-all-attrs-as-strings
branch
from
b5d03cf
to
08f85bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When data is coming from user supplied HTML, I would expect all attributes to come in as strings.
Instead this library converts boolean strings "true" and "false" to boolean primitives.
My use-case is very heavy on custom components, many of which do string operations on the incoming data.
For example we have one that passes in a a path to get properties off of an object, that path can be the string literal values "true"/"false".
It would be nice to be able to toggle off the feature that converts booleans.