fix: handle render of empty noInnerParse html nodes like script and s…

…tyle tag #597 (#601) * fix: handle empty noInnerParse html nodes * Create sharp-lobsters-turn.md --------- Co-authored-by: Evan Jacobs <[email protected]>
quantizor · Nov 12, 2024 · 58b96d3 · 58b96d3
1 parent b16f668
commit 58b96d3
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 1 deletion.
diff --git a/.changeset/sharp-lobsters-turn.md b/.changeset/sharp-lobsters-turn.md
@@ -0,0 +1,5 @@
+---
+"markdown-to-jsx": patch
+---
+
+fix: handle empty HTML tags more consistently #597
diff --git a/index.compiler.spec.tsx b/index.compiler.spec.tsx
@@ -4711,3 +4711,12 @@ it('handles naked brackets in link text', () => {
     </a>
   `)
 })
+
+it('#597 handles script tag with empty content', () => {
+  render(compiler('<script src="dummy.js"></script>'))
+
+  expect(root.innerHTML).toMatchInlineSnapshot(`
+    <script src="dummy.js">
+    </script>
+  `)
+})
diff --git a/index.tsx b/index.tsx
@@ -1546,7 +1546,7 @@ export function compiler(
       render(node, output, state) {
         return (
           <node.tag key={state.key} {...node.attrs}>
-            {node.text || output(node.children, state)}
+            {node.text || (node.children ? output(node.children, state) : '')}
           </node.tag>
         )
       },