Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@testing-library/user-event types are fixed, remove our workaround #2278

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

berekuk
Copy link
Collaborator

@berekuk berekuk commented Sep 15, 2023

testing-library/user-event#1162

Minor fix for our tests.

PS: Fixed version of @testing-library/user-event was released 20 minutes ago, we're probably the first to adopt it :)

@berekuk berekuk requested a review from OAGr as a code owner September 15, 2023 18:32
@changeset-bot
Copy link

changeset-bot bot commented Sep 15, 2023

⚠️ No Changeset found

Latest commit: 5c1c7a0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@berekuk berekuk temporarily deployed to Preview September 15, 2023 18:32 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented Sep 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
quri-hub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 15, 2023 6:35pm
quri-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 15, 2023 6:35pm
squiggle-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 15, 2023 6:35pm
squiggle-website ✅ Ready (Inspect) Visit Preview Sep 15, 2023 6:35pm

@berekuk berekuk merged commit 9cc2941 into main Sep 15, 2023
4 checks passed
@berekuk berekuk deleted the user-event-fix branch September 15, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants