Move AWS secrets env. variables setup to the job section in the hope …

…doing so fixes intermittent problem with AWS_ACCESS_KEY_ID
quantcast · Apr 2, 2021 · e14720f · e14720f
1 parent 56ff714
commit e14720f
Showing 1 changed file with 9 additions and 12 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -94,6 +94,9 @@ jobs:
             buser: qfsbuild
     runs-on: ubuntu-latest
     env:
+      AWS_ACCESS_KEY_ID: ${{ github.secrets.AWS_ACCESS_KEY_ID }}
+      AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
+      AWS_DEFAULT_REGION: us-west-2
       BUILD_OS_NAME: linux
       BUILD_RUN_DOCKER: "yes"
       DISTRO: ${{ matrix.distro }}
@@ -117,16 +120,15 @@ jobs:
           && 'release' == matrix.btype
           && 'qfsbuild' == matrix.buser
           && 'yes' != matrix.codecov
-        env:
-          AWS_ACCESS_KEY_ID: ${{ github.secrets.AWS_ACCESS_KEY_ID }}
-          AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
-          AWS_DEFAULT_REGION: us-west-2
         run: aws s3 cp build/qfs-*.tgz s3://quantcast-qfs
 
   osx-build:
     runs-on: macos-latest
     env:
       BUILD_OS_NAME: osx
+      AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
+      AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
+      AWS_DEFAULT_REGION: us-west-2
     steps:
       - name: Brew install
         run: |
@@ -143,17 +145,16 @@ jobs:
         if: |
           'refs/heads/master' == github.ref
           || startsWith(github.ref, 'refs/tags/')
-        env:
-          AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
-          AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
-          AWS_DEFAULT_REGION: us-west-2
         run: aws s3 cp build/qfs-*.tgz s3://quantcast-qfs
 
   cygwin-build:
     runs-on: windows-latest
     env:
       CYG_MIRROR: http://cygwin.mirror.constant.com
       DEPENDENCIES: gcc-g++,autoconf,automake,make,cmake,libboost-devel,libssl-devel,bzip2,python,git,libstdc++6-devel,libkrb5-devel,zlib-devel
+      AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
+      AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
+      AWS_DEFAULT_REGION: us-west-2
     steps:
       - name: Set git to use LF
         run: |
@@ -233,10 +234,6 @@ jobs:
         if: |
           'refs/heads/master' == github.ref
           || startsWith(github.ref, 'refs/tags/')
-        env:
-          AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
-          AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
-          AWS_DEFAULT_REGION: us-west-2
         shell: pwsh
         run: |
           aws s3 cp (Get-ChildItem "build\qfs-*.tgz").FullName `