Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SECRET support #20

Merged
merged 9 commits into from
Jan 7, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
cast unique_ptr to the correct type
lmangani authored Jan 7, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 5e053207f2f23b739441258922496b6503b79df9
14 changes: 7 additions & 7 deletions src/open_prompt_extension.cpp
Original file line number Diff line number Diff line change
@@ -38,14 +38,14 @@
idx_t model_idx;
idx_t json_schema_idx;
idx_t json_system_prompt_idx;
unique_ptr<FunctionData> Copy() const {
auto res = make_uniq<OpenPromptData>();
res->model_idx = model_idx;
res->json_schema_idx = json_schema_idx;
res->json_system_prompt_idx = json_system_prompt_idx;
return res;
};
unique_ptr<FunctionData> Copy() const override {
auto res = make_uniq<OpenPromptData>();
res->model_idx = model_idx;
res->json_schema_idx = json_schema_idx;
res->json_system_prompt_idx = json_system_prompt_idx;
return std::unique_ptr<FunctionData>(std::move(res));

Check failure on line 46 in src/open_prompt_extension.cpp

GitHub Actions / Build extension binaries / MacOS (osx_arm64, arm64, arm64-osx)

no viable conversion from returned value of type 'std::unique_ptr<FunctionData>' to function return type 'unique_ptr<FunctionData>'

Check failure on line 46 in src/open_prompt_extension.cpp

GitHub Actions / Build extension binaries / MacOS (osx_arm64, arm64, arm64-osx)

no viable conversion from returned value of type 'std::unique_ptr<FunctionData>' to function return type 'unique_ptr<FunctionData>'

Check failure on line 46 in src/open_prompt_extension.cpp

GitHub Actions / Build extension binaries / DuckDB-Wasm (wasm_mvp, wasm32-emscripten)

no viable conversion from returned value of type 'std::unique_ptr<FunctionData>' to function return type 'unique_ptr<FunctionData>'

Check failure on line 46 in src/open_prompt_extension.cpp

GitHub Actions / Build extension binaries / DuckDB-Wasm (wasm_mvp, wasm32-emscripten)

no viable conversion from returned value of type 'std::unique_ptr<FunctionData>' to function return type 'unique_ptr<FunctionData>'

Check failure on line 46 in src/open_prompt_extension.cpp

GitHub Actions / Build extension binaries / DuckDB-Wasm (wasm_threads, wasm32-emscripten)

no viable conversion from returned value of type 'std::unique_ptr<FunctionData>' to function return type 'unique_ptr<FunctionData>'

Check failure on line 46 in src/open_prompt_extension.cpp

GitHub Actions / Build extension binaries / DuckDB-Wasm (wasm_threads, wasm32-emscripten)

no viable conversion from returned value of type 'std::unique_ptr<FunctionData>' to function return type 'unique_ptr<FunctionData>'

Check failure on line 46 in src/open_prompt_extension.cpp

GitHub Actions / Build extension binaries / DuckDB-Wasm (wasm_eh, wasm32-emscripten)

no viable conversion from returned value of type 'std::unique_ptr<FunctionData>' to function return type 'unique_ptr<FunctionData>'

Check failure on line 46 in src/open_prompt_extension.cpp

GitHub Actions / Build extension binaries / DuckDB-Wasm (wasm_eh, wasm32-emscripten)

no viable conversion from returned value of type 'std::unique_ptr<FunctionData>' to function return type 'unique_ptr<FunctionData>'

Check failure on line 46 in src/open_prompt_extension.cpp

GitHub Actions / Build extension binaries / MacOS (osx_arm64, arm64, arm64-osx)

no viable conversion from returned value of type 'std::unique_ptr<FunctionData>' to function return type 'unique_ptr<FunctionData>'

Check failure on line 46 in src/open_prompt_extension.cpp

GitHub Actions / Build extension binaries / MacOS (osx_arm64, arm64, arm64-osx)

no viable conversion from returned value of type 'std::unique_ptr<FunctionData>' to function return type 'unique_ptr<FunctionData>'

Check failure on line 46 in src/open_prompt_extension.cpp

GitHub Actions / Build extension binaries / DuckDB-Wasm (wasm_threads, wasm32-emscripten)

no viable conversion from returned value of type 'std::unique_ptr<FunctionData>' to function return type 'unique_ptr<FunctionData>'

Check failure on line 46 in src/open_prompt_extension.cpp

GitHub Actions / Build extension binaries / DuckDB-Wasm (wasm_threads, wasm32-emscripten)

no viable conversion from returned value of type 'std::unique_ptr<FunctionData>' to function return type 'unique_ptr<FunctionData>'

Check failure on line 46 in src/open_prompt_extension.cpp

GitHub Actions / Build extension binaries / DuckDB-Wasm (wasm_mvp, wasm32-emscripten)

no viable conversion from returned value of type 'std::unique_ptr<FunctionData>' to function return type 'unique_ptr<FunctionData>'

Check failure on line 46 in src/open_prompt_extension.cpp

GitHub Actions / Build extension binaries / DuckDB-Wasm (wasm_mvp, wasm32-emscripten)

no viable conversion from returned value of type 'std::unique_ptr<FunctionData>' to function return type 'unique_ptr<FunctionData>'

Check failure on line 46 in src/open_prompt_extension.cpp

GitHub Actions / Build extension binaries / DuckDB-Wasm (wasm_eh, wasm32-emscripten)

no viable conversion from returned value of type 'std::unique_ptr<FunctionData>' to function return type 'unique_ptr<FunctionData>'

Check failure on line 46 in src/open_prompt_extension.cpp

GitHub Actions / Build extension binaries / DuckDB-Wasm (wasm_eh, wasm32-emscripten)

no viable conversion from returned value of type 'std::unique_ptr<FunctionData>' to function return type 'unique_ptr<FunctionData>'

Check failure on line 46 in src/open_prompt_extension.cpp

GitHub Actions / Build extension binaries / DuckDB-Wasm (wasm_eh, wasm32-emscripten)

no viable conversion from returned value of type 'std::unique_ptr<FunctionData>' to function return type 'unique_ptr<FunctionData>'

Check failure on line 46 in src/open_prompt_extension.cpp

GitHub Actions / Build extension binaries / DuckDB-Wasm (wasm_eh, wasm32-emscripten)

no viable conversion from returned value of type 'std::unique_ptr<FunctionData>' to function return type 'unique_ptr<FunctionData>'

Check failure on line 46 in src/open_prompt_extension.cpp

GitHub Actions / Build extension binaries / DuckDB-Wasm (wasm_threads, wasm32-emscripten)

no viable conversion from returned value of type 'std::unique_ptr<FunctionData>' to function return type 'unique_ptr<FunctionData>'

Check failure on line 46 in src/open_prompt_extension.cpp

GitHub Actions / Build extension binaries / DuckDB-Wasm (wasm_threads, wasm32-emscripten)

no viable conversion from returned value of type 'std::unique_ptr<FunctionData>' to function return type 'unique_ptr<FunctionData>'
};
bool Equals(const FunctionData &other) const {

Check warning on line 48 in src/open_prompt_extension.cpp

GitHub Actions / Build extension binaries / MacOS (osx_arm64, arm64, arm64-osx)

'Equals' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]

Check warning on line 48 in src/open_prompt_extension.cpp

GitHub Actions / Build extension binaries / MacOS (osx_arm64, arm64, arm64-osx)

'Equals' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]

Check warning on line 48 in src/open_prompt_extension.cpp

GitHub Actions / Build extension binaries / MacOS (osx_arm64, arm64, arm64-osx)

'Equals' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]

Check warning on line 48 in src/open_prompt_extension.cpp

GitHub Actions / Build extension binaries / MacOS (osx_arm64, arm64, arm64-osx)

'Equals' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]

Check warning on line 48 in src/open_prompt_extension.cpp

GitHub Actions / Build extension binaries / DuckDB-Wasm (wasm_eh, wasm32-emscripten)

'Equals' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]

Check warning on line 48 in src/open_prompt_extension.cpp

GitHub Actions / Build extension binaries / DuckDB-Wasm (wasm_eh, wasm32-emscripten)

'Equals' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]

Check warning on line 48 in src/open_prompt_extension.cpp

GitHub Actions / Build extension binaries / DuckDB-Wasm (wasm_threads, wasm32-emscripten)

'Equals' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]

Check warning on line 48 in src/open_prompt_extension.cpp

GitHub Actions / Build extension binaries / DuckDB-Wasm (wasm_threads, wasm32-emscripten)

'Equals' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
return model_idx == other.Cast<OpenPromptData>().model_idx &&
json_schema_idx == other.Cast<OpenPromptData>().json_schema_idx &&
json_system_prompt_idx==other.Cast<OpenPromptData>().json_system_prompt_idx;

Unchanged files with check annotations Beta