Skip to content

Commit

Permalink
cast unique_ptr to the correct type
Browse files Browse the repository at this point in the history
  • Loading branch information
lmangani authored Jan 7, 2025
1 parent b86b137 commit 5e05320
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions src/open_prompt_extension.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,13 @@ namespace duckdb {
idx_t model_idx;
idx_t json_schema_idx;
idx_t json_system_prompt_idx;
unique_ptr<FunctionData> Copy() const {
auto res = make_uniq<OpenPromptData>();
res->model_idx = model_idx;
res->json_schema_idx = json_schema_idx;
res->json_system_prompt_idx = json_system_prompt_idx;
return res;
};
unique_ptr<FunctionData> Copy() const override {
auto res = make_uniq<OpenPromptData>();
res->model_idx = model_idx;
res->json_schema_idx = json_schema_idx;
res->json_system_prompt_idx = json_system_prompt_idx;
return std::unique_ptr<FunctionData>(std::move(res));

Check failure on line 46 in src/open_prompt_extension.cpp

View workflow job for this annotation

GitHub Actions / Build extension binaries / MacOS (osx_arm64, arm64, arm64-osx)

no viable conversion from returned value of type 'std::unique_ptr<FunctionData>' to function return type 'unique_ptr<FunctionData>'

Check failure on line 46 in src/open_prompt_extension.cpp

View workflow job for this annotation

GitHub Actions / Build extension binaries / MacOS (osx_arm64, arm64, arm64-osx)

no viable conversion from returned value of type 'std::unique_ptr<FunctionData>' to function return type 'unique_ptr<FunctionData>'

Check failure on line 46 in src/open_prompt_extension.cpp

View workflow job for this annotation

GitHub Actions / Build extension binaries / DuckDB-Wasm (wasm_mvp, wasm32-emscripten)

no viable conversion from returned value of type 'std::unique_ptr<FunctionData>' to function return type 'unique_ptr<FunctionData>'

Check failure on line 46 in src/open_prompt_extension.cpp

View workflow job for this annotation

GitHub Actions / Build extension binaries / DuckDB-Wasm (wasm_mvp, wasm32-emscripten)

no viable conversion from returned value of type 'std::unique_ptr<FunctionData>' to function return type 'unique_ptr<FunctionData>'

Check failure on line 46 in src/open_prompt_extension.cpp

View workflow job for this annotation

GitHub Actions / Build extension binaries / DuckDB-Wasm (wasm_threads, wasm32-emscripten)

no viable conversion from returned value of type 'std::unique_ptr<FunctionData>' to function return type 'unique_ptr<FunctionData>'

Check failure on line 46 in src/open_prompt_extension.cpp

View workflow job for this annotation

GitHub Actions / Build extension binaries / DuckDB-Wasm (wasm_threads, wasm32-emscripten)

no viable conversion from returned value of type 'std::unique_ptr<FunctionData>' to function return type 'unique_ptr<FunctionData>'

Check failure on line 46 in src/open_prompt_extension.cpp

View workflow job for this annotation

GitHub Actions / Build extension binaries / DuckDB-Wasm (wasm_eh, wasm32-emscripten)

no viable conversion from returned value of type 'std::unique_ptr<FunctionData>' to function return type 'unique_ptr<FunctionData>'

Check failure on line 46 in src/open_prompt_extension.cpp

View workflow job for this annotation

GitHub Actions / Build extension binaries / DuckDB-Wasm (wasm_eh, wasm32-emscripten)

no viable conversion from returned value of type 'std::unique_ptr<FunctionData>' to function return type 'unique_ptr<FunctionData>'

Check failure on line 46 in src/open_prompt_extension.cpp

View workflow job for this annotation

GitHub Actions / Build extension binaries / MacOS (osx_arm64, arm64, arm64-osx)

no viable conversion from returned value of type 'std::unique_ptr<FunctionData>' to function return type 'unique_ptr<FunctionData>'

Check failure on line 46 in src/open_prompt_extension.cpp

View workflow job for this annotation

GitHub Actions / Build extension binaries / MacOS (osx_arm64, arm64, arm64-osx)

no viable conversion from returned value of type 'std::unique_ptr<FunctionData>' to function return type 'unique_ptr<FunctionData>'

Check failure on line 46 in src/open_prompt_extension.cpp

View workflow job for this annotation

GitHub Actions / Build extension binaries / DuckDB-Wasm (wasm_threads, wasm32-emscripten)

no viable conversion from returned value of type 'std::unique_ptr<FunctionData>' to function return type 'unique_ptr<FunctionData>'

Check failure on line 46 in src/open_prompt_extension.cpp

View workflow job for this annotation

GitHub Actions / Build extension binaries / DuckDB-Wasm (wasm_threads, wasm32-emscripten)

no viable conversion from returned value of type 'std::unique_ptr<FunctionData>' to function return type 'unique_ptr<FunctionData>'

Check failure on line 46 in src/open_prompt_extension.cpp

View workflow job for this annotation

GitHub Actions / Build extension binaries / DuckDB-Wasm (wasm_mvp, wasm32-emscripten)

no viable conversion from returned value of type 'std::unique_ptr<FunctionData>' to function return type 'unique_ptr<FunctionData>'

Check failure on line 46 in src/open_prompt_extension.cpp

View workflow job for this annotation

GitHub Actions / Build extension binaries / DuckDB-Wasm (wasm_mvp, wasm32-emscripten)

no viable conversion from returned value of type 'std::unique_ptr<FunctionData>' to function return type 'unique_ptr<FunctionData>'

Check failure on line 46 in src/open_prompt_extension.cpp

View workflow job for this annotation

GitHub Actions / Build extension binaries / DuckDB-Wasm (wasm_eh, wasm32-emscripten)

no viable conversion from returned value of type 'std::unique_ptr<FunctionData>' to function return type 'unique_ptr<FunctionData>'

Check failure on line 46 in src/open_prompt_extension.cpp

View workflow job for this annotation

GitHub Actions / Build extension binaries / DuckDB-Wasm (wasm_eh, wasm32-emscripten)

no viable conversion from returned value of type 'std::unique_ptr<FunctionData>' to function return type 'unique_ptr<FunctionData>'

Check failure on line 46 in src/open_prompt_extension.cpp

View workflow job for this annotation

GitHub Actions / Build extension binaries / DuckDB-Wasm (wasm_eh, wasm32-emscripten)

no viable conversion from returned value of type 'std::unique_ptr<FunctionData>' to function return type 'unique_ptr<FunctionData>'

Check failure on line 46 in src/open_prompt_extension.cpp

View workflow job for this annotation

GitHub Actions / Build extension binaries / DuckDB-Wasm (wasm_eh, wasm32-emscripten)

no viable conversion from returned value of type 'std::unique_ptr<FunctionData>' to function return type 'unique_ptr<FunctionData>'

Check failure on line 46 in src/open_prompt_extension.cpp

View workflow job for this annotation

GitHub Actions / Build extension binaries / DuckDB-Wasm (wasm_threads, wasm32-emscripten)

no viable conversion from returned value of type 'std::unique_ptr<FunctionData>' to function return type 'unique_ptr<FunctionData>'

Check failure on line 46 in src/open_prompt_extension.cpp

View workflow job for this annotation

GitHub Actions / Build extension binaries / DuckDB-Wasm (wasm_threads, wasm32-emscripten)

no viable conversion from returned value of type 'std::unique_ptr<FunctionData>' to function return type 'unique_ptr<FunctionData>'
};
bool Equals(const FunctionData &other) const {

Check warning on line 48 in src/open_prompt_extension.cpp

View workflow job for this annotation

GitHub Actions / Build extension binaries / MacOS (osx_arm64, arm64, arm64-osx)

'Equals' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]

Check warning on line 48 in src/open_prompt_extension.cpp

View workflow job for this annotation

GitHub Actions / Build extension binaries / MacOS (osx_arm64, arm64, arm64-osx)

'Equals' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]

Check warning on line 48 in src/open_prompt_extension.cpp

View workflow job for this annotation

GitHub Actions / Build extension binaries / MacOS (osx_arm64, arm64, arm64-osx)

'Equals' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]

Check warning on line 48 in src/open_prompt_extension.cpp

View workflow job for this annotation

GitHub Actions / Build extension binaries / MacOS (osx_arm64, arm64, arm64-osx)

'Equals' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]

Check warning on line 48 in src/open_prompt_extension.cpp

View workflow job for this annotation

GitHub Actions / Build extension binaries / DuckDB-Wasm (wasm_eh, wasm32-emscripten)

'Equals' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]

Check warning on line 48 in src/open_prompt_extension.cpp

View workflow job for this annotation

GitHub Actions / Build extension binaries / DuckDB-Wasm (wasm_eh, wasm32-emscripten)

'Equals' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]

Check warning on line 48 in src/open_prompt_extension.cpp

View workflow job for this annotation

GitHub Actions / Build extension binaries / DuckDB-Wasm (wasm_threads, wasm32-emscripten)

'Equals' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]

Check warning on line 48 in src/open_prompt_extension.cpp

View workflow job for this annotation

GitHub Actions / Build extension binaries / DuckDB-Wasm (wasm_threads, wasm32-emscripten)

'Equals' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
return model_idx == other.Cast<OpenPromptData>().model_idx &&
json_schema_idx == other.Cast<OpenPromptData>().json_schema_idx &&
Expand Down

0 comments on commit 5e05320

Please sign in to comment.