forked from apache/gravitino
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[apache#4962] feat(trino-connector): Support the Trino cascading conn…
…ector (apache#4935) ### What changes were proposed in this pull request? Support the Trino cascading connector ### Why are the changes needed? Fix: apache#4962 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Add some ut and Manually test
- Loading branch information
Showing
8 changed files
with
366 additions
and
78 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
91 changes: 91 additions & 0 deletions
91
...org/apache/gravitino/trino/connector/catalog/jdbc/trino/TrinoClusterConnectorAdapter.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,91 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.apache.gravitino.trino.connector.catalog.jdbc.trino; | ||
|
|
||
| import static org.apache.gravitino.trino.connector.GravitinoErrorCode.GRAVITINO_MISSING_CONFIG; | ||
| import static org.apache.gravitino.trino.connector.catalog.jdbc.JDBCCatalogPropertyConverter.JDBC_CONNECTION_PASSWORD_KEY; | ||
| import static org.apache.gravitino.trino.connector.catalog.jdbc.JDBCCatalogPropertyConverter.JDBC_CONNECTION_URL_KEY; | ||
| import static org.apache.gravitino.trino.connector.catalog.jdbc.JDBCCatalogPropertyConverter.JDBC_CONNECTION_USER_KEY; | ||
|
|
||
| import io.trino.spi.TrinoException; | ||
| import io.trino.spi.session.PropertyMetadata; | ||
| import java.util.Collections; | ||
| import java.util.HashMap; | ||
| import java.util.List; | ||
| import java.util.Map; | ||
| import org.apache.commons.lang3.StringUtils; | ||
| import org.apache.gravitino.trino.connector.catalog.CatalogConnectorAdapter; | ||
| import org.apache.gravitino.trino.connector.catalog.CatalogConnectorMetadataAdapter; | ||
| import org.apache.gravitino.trino.connector.catalog.HasPropertyMeta; | ||
| import org.apache.gravitino.trino.connector.metadata.GravitinoCatalog; | ||
|
|
||
| /** | ||
| * Support trino cluster connector. Transforming cluster connector configuration and components into | ||
| * Gravitino connector. | ||
| */ | ||
| public class TrinoClusterConnectorAdapter implements CatalogConnectorAdapter { | ||
|
|
||
| private static final String CONNECTOR_CLUSTER = "trino"; | ||
| public static final String TRINO_CLUSTER_URL_KEY = "cloud.trino.connection-url"; | ||
| public static final String TRINO_CLUSTER_USER_KEY = "cloud.trino.connection-user"; | ||
| public static final String TRINO_CLUSTER_PASSWORD_KEY = "cloud.trino.connection-password"; | ||
| public static final String TRINO_CLUSTER_DEFAULT_USER = "admin"; | ||
|
|
||
| private final HasPropertyMeta propertyMetadata; | ||
|
|
||
| public TrinoClusterConnectorAdapter() { | ||
| this.propertyMetadata = new TrinoClusterPropertyMeta(); | ||
| } | ||
|
|
||
| @Override | ||
| public Map<String, String> buildInternalConnectorConfig(GravitinoCatalog catalog) { | ||
| Map<String, String> config = new HashMap<>(); | ||
| String jdbcUrl = catalog.getProperty(TRINO_CLUSTER_URL_KEY, ""); | ||
| if (StringUtils.isEmpty(jdbcUrl)) { | ||
| throw new TrinoException( | ||
| GRAVITINO_MISSING_CONFIG, "Missing jdbc url config for the cluster catalog"); | ||
| } | ||
| jdbcUrl += "/" + catalog.getName(); | ||
| config.put(JDBC_CONNECTION_URL_KEY, jdbcUrl); | ||
|
|
||
| String user = catalog.getProperty(TRINO_CLUSTER_USER_KEY, TRINO_CLUSTER_DEFAULT_USER); | ||
| config.put(JDBC_CONNECTION_USER_KEY, user); | ||
|
|
||
| String password = catalog.getProperty(TRINO_CLUSTER_PASSWORD_KEY, ""); | ||
| config.put(JDBC_CONNECTION_PASSWORD_KEY, password); | ||
|
|
||
| return config; | ||
| } | ||
|
|
||
| @Override | ||
| public String internalConnectorName() { | ||
| return CONNECTOR_CLUSTER; | ||
| } | ||
|
|
||
| @Override | ||
| public CatalogConnectorMetadataAdapter getMetadataAdapter() { | ||
| return new TrinoClusterMetadataAdapter( | ||
| getTableProperties(), Collections.emptyList(), Collections.emptyList()); | ||
| } | ||
|
|
||
| @Override | ||
| public List<PropertyMetadata<?>> getTableProperties() { | ||
| return propertyMetadata.getTablePropertyMetadata(); | ||
| } | ||
| } |
36 changes: 36 additions & 0 deletions
36
.../org/apache/gravitino/trino/connector/catalog/jdbc/trino/TrinoClusterMetadataAdapter.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.apache.gravitino.trino.connector.catalog.jdbc.trino; | ||
|
|
||
| import io.trino.spi.session.PropertyMetadata; | ||
| import java.util.List; | ||
| import org.apache.gravitino.trino.connector.catalog.CatalogConnectorMetadataAdapter; | ||
| import org.apache.gravitino.trino.connector.util.GeneralDataTypeTransformer; | ||
|
|
||
| /** Support Trino cluster connector for testing. */ | ||
| public class TrinoClusterMetadataAdapter extends CatalogConnectorMetadataAdapter { | ||
|
|
||
| public TrinoClusterMetadataAdapter( | ||
| List<PropertyMetadata<?>> schemaProperties, | ||
| List<PropertyMetadata<?>> tableProperties, | ||
| List<PropertyMetadata<?>> columnProperties) { | ||
|
|
||
| super(schemaProperties, tableProperties, columnProperties, new GeneralDataTypeTransformer()); | ||
| } | ||
| } |
23 changes: 23 additions & 0 deletions
23
...ava/org/apache/gravitino/trino/connector/catalog/jdbc/trino/TrinoClusterPropertyMeta.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.apache.gravitino.trino.connector.catalog.jdbc.trino; | ||
|
|
||
| import org.apache.gravitino.trino.connector.catalog.HasPropertyMeta; | ||
|
|
||
| public class TrinoClusterPropertyMeta implements HasPropertyMeta {} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
64 changes: 64 additions & 0 deletions
64
...pache/gravitino/trino/connector/catalog/jdbc/mysql/TestMySQLCatalogPropertyConverter.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.apache.gravitino.trino.connector.catalog.jdbc.mysql; | ||
|
|
||
| import com.google.common.collect.ImmutableMap; | ||
| import java.util.Map; | ||
| import org.apache.gravitino.Catalog; | ||
| import org.apache.gravitino.trino.connector.metadata.GravitinoCatalog; | ||
| import org.apache.gravitino.trino.connector.metadata.TestGravitinoCatalog; | ||
| import org.junit.jupiter.api.Assertions; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| public class TestMySQLCatalogPropertyConverter { | ||
|
|
||
| @Test | ||
| @SuppressWarnings("unchecked") | ||
| public void testBuildMySqlConnectorProperties() throws Exception { | ||
| String name = "test_catalog"; | ||
| Map<String, String> properties = | ||
| ImmutableMap.<String, String>builder() | ||
| .put("jdbc-url", "jdbc:mysql://localhost:5432/test") | ||
| .put("jdbc-user", "test") | ||
| .put("jdbc-password", "test") | ||
| .put("trino.bypass.join-pushdown.strategy", "EAGER") | ||
| .put("unknown-key", "1") | ||
| .put("trino.bypass.unknown-key", "1") | ||
| .build(); | ||
| Catalog mockCatalog = | ||
| TestGravitinoCatalog.mockCatalog( | ||
| name, "jdbc-postgresql", "test catalog", Catalog.Type.RELATIONAL, properties); | ||
| MySQLConnectorAdapter adapter = new MySQLConnectorAdapter(); | ||
|
|
||
| Map<String, String> config = | ||
| adapter.buildInternalConnectorConfig(new GravitinoCatalog("test", mockCatalog)); | ||
|
|
||
| // test converted properties | ||
| Assertions.assertEquals(config.get("connection-url"), "jdbc:mysql://localhost:5432/test"); | ||
| Assertions.assertEquals(config.get("connection-user"), "test"); | ||
| Assertions.assertEquals(config.get("connection-password"), "test"); | ||
|
|
||
| // test trino passing properties | ||
| Assertions.assertEquals(config.get("join-pushdown.strategy"), "EAGER"); | ||
|
|
||
| // test unknown properties | ||
| Assertions.assertNull(config.get("hive.unknown-key")); | ||
| Assertions.assertNull(config.get("trino.bypass.unknown-key")); | ||
| } | ||
| } |
Oops, something went wrong.