Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check actual file size #879

Closed
wants to merge 1 commit into from

Conversation

ngocnhan-tran1996
Copy link

Closes #867

I think it's neccessary to add extra condition activeFile.length() >= maxFileSize.getSize() for checking the initial size of an existing log file

Signed-off-by: Tran Ngoc Nhan <[email protected]>
@ceki
Copy link
Member

ceki commented Oct 25, 2024

@ngocnhan-tran1996 Issue fixed in commit ecae664

@ceki ceki self-assigned this Oct 25, 2024
@ceki ceki added the DONE label Oct 25, 2024
@ceki ceki closed this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SizeAndTimeBasedRollingPolicy does not take into account the initial size of an existing log file
2 participants