115-offloadable-bloom-filter #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f4fa7e2.
|
@vovac12 please, fix merge conflicts |
…:qoollo/pearl into 115-offloadable-bloom-filter
vovac12
requested review from
piakushin and
idruzhitskiy
and removed request for
piakushin
ikopylov
reviewed
Nov 2, 2021
ikopylov
reviewed
Nov 2, 2021
ikopylov
reviewed
Nov 3, 2021
ikopylov
reviewed
Nov 3, 2021
ikopylov
reviewed
Nov 3, 2021
idruzhitskiy
reviewed
Nov 4, 2021
piakushin
suggested changes
Nov 8, 2021
src/blob/index/bptree/core.rs
Outdated
| if i >= self.header.meta_size as u64 { | ||
| return Err(anyhow::anyhow!("read meta out of range")); | ||
| } | ||
| let mut buf = vec![0; 1]; |
There was a problem hiding this comment.
You can use just an array here
src/blob/index/core.rs
Outdated
| if !self.range_filter.contains(key) { | ||
| FilterResult::NotContains | ||
| } else if self.params.bloom_is_on && !self.bloom_filter.contains(key) { | ||
| } else if self.params.bloom_is_on | ||
| && matches!(self.check_bloom_key(key).await, Ok(Some(false))) |
There was a problem hiding this comment.
It works fine. But we need to investigate errors somehow. And errors would be just dropped here. Maybe it makes sense to return Result<FilterResult> here
src/blob/index/core.rs
Outdated
| if !self.range_filter.contains(key) { | ||
| FilterResult::NotContains | ||
| } else if self.params.bloom_is_on | ||
| && self.bloom_filter.contains_in_memory(key) == Some(false) |
There was a problem hiding this comment.
You can squash this condition with previous
src/storage/core.rs
Outdated
| /// Returns memory allocated for bloom filter buffer | ||
| pub async fn filter_memory_allocated(&self) -> usize { | ||
| let safe = self.inner.safe.read().await; | ||
| let active = if let Some(ablob) = safe.active_blob.as_ref() { |
There was a problem hiding this comment.
It would be shorter with map_or()
…l into 115-offloadable-bloom-filter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #115