Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate the possibility of receiveing data as a slice #191

Closed
ikopylov opened this issue Aug 31, 2022 · 1 comment · Fixed by #213
Closed

Investigate the possibility of receiveing data as a slice #191

ikopylov opened this issue Aug 31, 2022 · 1 comment · Fixed by #213
Assignees
@idruzhitskiy
Labels
enhancement New feature or request performance

Comments

@ikopylov
Copy link
Member

Currently, data being passed as a vector, which requires data to be clonned on Bob's side. Probably, we can receive data as a slice &[u8]

https://github.com/qoollo/pearl/blob/master/src/storage/core.rs#L249
@ikopylov ikopylov added the enhancement New feature or request label Aug 31, 2022
@ikopylov ikopylov mentioned this issue Aug 31, 2022
Closed
@ikopylov ikopylov mentioned this issue Sep 5, 2022
Merged
@ikopylov
Copy link
Member Author

ikopylov commented Sep 5, 2022

We can use Bytes (https://docs.rs/bytes/latest/bytes/struct.Bytes.html) instead of slice, if it is impossible to use slice to achieve zero copying

@idruzhitskiy idruzhitskiy mentioned this issue Oct 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@idruzhitskiy idruzhitskiy

Labels
enhancement New feature or request performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

191 bytes arguments qoollo/pearl
2 participants
@ikopylov @idruzhitskiy