Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

506 avoid data cloning #525

Merged
merged 22 commits into from
Oct 12, 2022
Merged

506 avoid data cloning #525

merged 22 commits into from
Oct 12, 2022

Conversation

idruzhitskiy
Copy link
Contributor

closes #506

@idruzhitskiy idruzhitskiy marked this pull request as ready for review July 8, 2022 13:08
CHANGELOG.md Outdated Show resolved Hide resolved
@ikopylov
Copy link
Member

Please, fix warnings in bob-backend/src/pearl/data.rs

bob/src/cluster/quorum.rs Outdated Show resolved Hide resolved
@idruzhitskiy
Copy link
Contributor Author

@ikopylov
Copy link
Member

ikopylov commented Sep 5, 2022

Tests failing. Please, fix them

CHANGELOG.md Outdated Show resolved Hide resolved
bob-common/src/data.rs Outdated Show resolved Hide resolved
bob-common/src/data.rs Outdated Show resolved Hide resolved
bob-common/src/data.rs Outdated Show resolved Hide resolved
@ikopylov
Copy link
Member

ikopylov commented Oct 4, 2022

Can data be passed by reference here? (in quorum.rs):

impl Cluster for Quorum {
    async fn put(&self, key: BobKey, data: BobData) -> Result<(), Error> {
        self.put_at_least(key, data).await
    }

Copy link
Member

@ikopylov ikopylov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ikopylov ikopylov merged commit c85c7ab into master Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid data clonning
2 participants