feat: setup TypeScript #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vscav
force-pushed
the
typescript-setup
branch
from
9a17f19 to
1fc0b08
Compare
michelegera
approved these changes
Nov 3, 2023
vscav
force-pushed
the
typescript-setup
branch
from
1fc0b08 to
b74407b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we setup everything needed for the TypeScript migration.
For now, the declarations folder is not outputted when running glint. It is a known issue, and it's probably due to the
@glint-nocheckmention in our.hbsfiles. We can leave it as it is for now, or add a temporary exclude to our tsconfig to ignore the.hbs. Open to discussion.