Use require instead of import to make Embroider happy
#20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeppelin
force-pushed
the
inline-ember-interal-utils
branch
2 times, most recently
from
e71c3ac to
f8a696e
Compare
zeppelin
changed the title
require instead of import to make Embroider happy
zeppelin
force-pushed
the
inline-ember-interal-utils
branch
2 times, most recently
from
2d9c218 to
2e36134
Compare
zeppelin
force-pushed
the
inline-ember-interal-utils
branch
from
2e36134 to
cf64274
Compare
|
With this, we should now be compatible with Embroider, right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches to the
requireglobal to access what was previouslyimported. Since Embroider won't expose synthetic modules, only real ones that Node module resolution would be able access. As mentioned inside the comment, it's a recommended way of doing such things by the Ember Core team members.Also adds
focus-traptodevDependenciesto work around this issue. (focus-trapis a dependency ofember-bootstrapwhich is being used for the dummy app).The Embroider scenarios are all based on versions of Ember & Ember Data currently defined in
package.json, which are3.28at the moment.Special thanks to @mansona <3