-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a charge basis #170
Add a charge basis #170
Conversation
This looks good to me, but I would really appreciate an example of an interesting Hamiltonian for a system of actual interest dropped somewhere in a docstring, if you have the bandwidth for this. Otherwise I feel someone would see it in the documentation but struggle to think of a situation where they would want to use it. |
I restarted one of the tests to see whether codecov would pick things up now that the token is properly set. |
@Krastanov I have added a transmon Hamiltonian as an example (also hooked up the docs). |
Thanks! I am in favor of merging! |
@david-pl Are you happy with this? |
@Krastanov Any objections to a minor version bump? |
not at all -- you never need to ask me that, I am always in favor of quick releases after each PR |
Right, I just meant minor vs. patch. If we do minor, we'll need to bump compat on QO.jl too, but I think it's worth doing when the exported functions change a bunch. For example, this will help me migrate private code to use the charge basis. |
Apologies, I misunderstood. Yes, I believe your plan makes sense. |
Ok, great. I will also bump the QO.jl minor version, since it reexports QOB. |
This basis is a truncated U(1) irrep basis intended to represent quantized charge. The charge operator is defined as are the conjugate (shift) operators
e^(ikφ)
associated with the U(1) degree of freedom φ.Could do a minor version bump after this as we will export a bunch of new functions.