Improved-BR-tensor #266
Merged
Improved-BR-tensor #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Significantly reduced array allocations in loops and fixed a couple of abstract type declarations to make function faster.
Parallelized main loop in function using @sync @distributed for _ in ....
Need to think about how dependencies should work for parallel version.
Updating to match base fork
Codecov Report
@@ Coverage Diff @@
## master #266 +/- ##
==========================================
+ Coverage 97.90% 98.23% +0.33%
==========================================
Files 16 16
Lines 1143 1134 -9
==========================================
- Hits 1119 1114 -5
+ Misses 24 20 -4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some more concrete types and type stability fixes and cleaned up the main loop in the timeevolution.bloch_redfield_tensor function to increase efficiency.
This function is still the main bottleneck in my project and it seems like the main loop is still the most time consuming part of the function so I did look into parallelizing the loop but couldn't settle on a implementation I was happy with so have removed it for now. I may have another go at this in the future.