-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solve piracies and ambiguities #28
Conversation
Also this one should be it |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #28 +/- ##
==========================================
+ Coverage 15.60% 17.29% +1.68%
==========================================
Files 12 12
Lines 378 399 +21
==========================================
+ Hits 59 69 +10
- Misses 319 330 +11 ☔ View full report in Codecov by Sentry. |
Now tests should pass on all versions, the compat missed some entries and Aqua complained. So this could be merged I think |
apologies for the delay on responding here, I am running a summer workshop next week (qnumerics.org) and prep has taken some of my time. FYI, in case I do not finish reviewing this family of PRs this week, I might be in a bit of radio silence next week during the workshop |
No problem, I'm not in a rush to finish all of this, but this one should be relatively easy to review and merging it would allow be to test in CI the main one, so if you have some time for review for this one this it will make everything a bit faster |
the QuantumSavory failure is due to the upstreaming, so it is to be expected |
Part of QuantumSavory/QuantumSavory.jl#143