Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve piracies and ambiguities #28

Merged
merged 9 commits into from
Aug 10, 2024
Merged

Solve piracies and ambiguities #28

merged 9 commits into from
Aug 10, 2024

Conversation

Tortar
Copy link
Contributor

@Tortar Tortar commented Aug 3, 2024

@Tortar
Copy link
Contributor Author

Tortar commented Aug 4, 2024

Also this one should be it

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 17.29%. Comparing base (a3b09c2) to head (2b56209).
Report is 4 commits behind head on main.

Files Patch % Lines
src/embed_permute.jl 0.00% 2 Missing ⚠️
src/abstract_types.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
+ Coverage   15.60%   17.29%   +1.68%     
==========================================
  Files          12       12              
  Lines         378      399      +21     
==========================================
+ Hits           59       69      +10     
- Misses        319      330      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tortar
Copy link
Contributor Author

Tortar commented Aug 6, 2024

Now tests should pass on all versions, the compat missed some entries and Aqua complained. So this could be merged I think

@Krastanov
Copy link
Collaborator

apologies for the delay on responding here, I am running a summer workshop next week (qnumerics.org) and prep has taken some of my time. FYI, in case I do not finish reviewing this family of PRs this week, I might be in a bit of radio silence next week during the workshop

@Tortar
Copy link
Contributor Author

Tortar commented Aug 9, 2024

No problem, I'm not in a rush to finish all of this, but this one should be relatively easy to review and merging it would allow be to test in CI the main one, so if you have some time for review for this one this it will make everything a bit faster

@Krastanov
Copy link
Collaborator

the QuantumSavory failure is due to the upstreaming, so it is to be expected

@Krastanov Krastanov merged commit 521a05b into qojulia:main Aug 10, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants