-
-
Notifications
You must be signed in to change notification settings - Fork 39.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto shift: support repeats and early registration #9826
Merged
Merged
+186
−64
Commits on Nov 26, 2020
-
Auto shift: support repeats and early registration (qmk#7048)
Instead of waiting for the next record to tap the autoshiftable key, expose a matrix_scan function that will check the timeout and register the key immediately if the timeout period has elapsed. This means the user gets immediate feedback about their press and doesn't have to guess whether it's been long enough. Additionally, don't unregister the keypress immediately. This means that auto-shifted keys can be held down. Removes the 'autoshift_on' function (which had external linkage but was not exposed in the header). Fixes qmk#7048
Configuration menu - View commit details
-
Copy full SHA for f513cc8 - Browse repository at this point
Copy the full SHA f513cc8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b83ff4 - Browse repository at this point
Copy the full SHA 0b83ff4View commit details -
Support tap-then-hold for auto shift
Make auto-shift keys like dual-function keys insofar as they can be repeated by tapping then immediately (within TAPPING_TERM) holding again.
Configuration menu - View commit details
-
Copy full SHA for 65fe438 - Browse repository at this point
Copy the full SHA 65fe438View commit details -
When processing a different keypress record, register the outstanding key from the auto-shift.
Configuration menu - View commit details
-
Copy full SHA for 1ab316f - Browse repository at this point
Copy the full SHA 1ab316fView commit details -
Configuration menu - View commit details
-
Copy full SHA for b0a3cd4 - Browse repository at this point
Copy the full SHA b0a3cd4View commit details -
Configuration menu - View commit details
-
Copy full SHA for d2e4383 - Browse repository at this point
Copy the full SHA d2e4383View commit details -
Update the auto shift docs to reflect that repeats now work.
Configuration menu - View commit details
-
Copy full SHA for ac7dfaf - Browse repository at this point
Copy the full SHA ac7dfafView commit details -
Configuration menu - View commit details
-
Copy full SHA for e576132 - Browse repository at this point
Copy the full SHA e576132View commit details -
Configuration menu - View commit details
-
Copy full SHA for 451fcc7 - Browse repository at this point
Copy the full SHA 451fcc7View commit details -
Configuration menu - View commit details
-
Copy full SHA for be23535 - Browse repository at this point
Copy the full SHA be23535View commit details -
Don't trust record->event.time
Manual testing has shown event.time is not reliable on some keyboards. Perform a timer_read() instead.
Configuration menu - View commit details
-
Copy full SHA for 4c7f736 - Browse repository at this point
Copy the full SHA 4c7f736View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.