-
-
Notifications
You must be signed in to change notification settings - Fork 40.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shell.nix improvements, and fix problems on Darwin #9551
Conversation
dfu-programmer and teensy-loader-cli are already listed as supported on darwin in nixpkgs.
Edit: actually that does not look that good considering there must be nearly 100 boards failing. Did you test Also running the tests with |
I guess the key question is whether you get more or fewer failures/successes with or without this PR. I can imagine blanking out |
I had failures before, too and it was about the same number. So it does not look like your PR makes things worse on linux. |
Cool, thanks for confirming - this should be unproblematic to merge, then. |
Improvements to shell.nix were made in #8910 by @thorstenweber83, but the result was that the nix shell no longer worked on Darwin.
I have tidied up and improved some of the Nix expression, fixing this issue along the way. If someone would be kind enough to test this on Linux too, that would be appreciated, though I don't expect issues.
Description
bin/qmk
Types of Changes
Issues Fixed or Closed by This PR
Checklist