The Key Company project consolidation

[TerryMathews]

Description

Consolidated all projects into tkc project folder.
Update make commands referenced in readmes.
Increase keymap count in VIA keymaps to 4.

Types of Changes

• Core
• Bugfix
• New feature
• Enhancement/optimization
• Keyboard (addition or update)
• Keymap/layout/userspace (addition or update)
• Documentation

Issues Fixed or Closed by This PR

Checklist

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• I have tested the changes and verified that they work and don't break anything (as well as I can manage).

[wilba]

You can use #define DYNAMIC_KEYMAP_EEPROM_MAX_ADDR 2047 in the config.h to use more EEPROM. AT90USB1286 has 4K.

[TerryMathews]

@Wilba6582 I thought there should be no way that it was running out of EEPROM... I can do that, but should the core maybe be fixed instead? It seems like the issue here is that the build isn't correctly detecting the amount of EEPROM space this MCU has.

[TerryMathews]

I had meant for the EEPROM size detect fix to be a separate PR but it got rolled up in here. Sorry! Thoughts?

[wilba]

I chose not to do this initially and leave it up to the keyboards with more than 1K to explicitly set it.... but this seems reasonable enough for the AT90 and will give those keyboards more macro space as well.

[wilba]

All the memory between the end of the "keymaps" and the end of the "allocated" EEPROM is used for macros. It makes sense then to be explit about how much EEPROM gets used by dynamic keymaps rather than just use it all up.

This is the reason I didn't make it use E2END in the first place. Dynamic keymaps should use a sensible amount by default, not "all available EEPROM".

[fauxpark]

All the memory between the end of the "keymaps" and the end of the "allocated" EEPROM is used for macros

So then there is no room for macros on the 32U4? 0x3FF == 1023, so you are using up all available EEPROM for dynamic keymaps on like 90% of boards.

[wilba]

"dynamic keymaps" as a feature uses up to DYNAMIC_KEYMAP_EEPROM_MAX_ADDR, the memory between the "keymaps" and that end address is used for macros. So for ATmega32u4, it is using all the EEPROM, giving a few hundred bytes for macros, depending on switch matrix size (i.e. macro pads have a lot more macro space than a TKL). For other MCUs, I thought it was preferrable not to set that end address by default to the maximum for the MCU, so it doesn't use something like 3K or so for macros on an AT90USB1286. But if you think it's better to do something like if AVR, use E2END then go for it.

[TerryMathews]

So I've f-ed up my fork somehow pretty badly. Any possibility this gets merged into future fairly soon, so I can not worry about preserving the PR?

[Erovia]

This PR should target the develop branch instead of master as it is a breaking change.
I'm not very found of mixing keyboard/keymap stuff with core changes either.

---

How did you mess up your fork?
Feel free to reach out to me on Discord, it's probably fixable.

[TerryMathews]

So is everything good with this now or do I need to make more changes to it?

[fauxpark]

I've changed the base branch of this PR (you just click the Edit button):

The commit log afterwards looks the same 👍

[TerryMathews]

OK, I didn't know how to do that. Thanks!

[noroadsleft]

Thanks!