Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove inclusion of adafruit_ble.h from ssd1306.c #9355

Merged
merged 1 commit into from
Jun 17, 2020

Conversation

fauxpark
Copy link
Member

Description

Nothing declared in this header is used by the SSD1306 code - not even the Comet46 which is a wireless split that uses the same BLE module but not the Adafruit firmware.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team June 10, 2020 08:27
@zvecr zvecr requested a review from a team June 10, 2020 16:07
@fauxpark fauxpark merged commit aa45c43 into qmk:develop Jun 17, 2020
@fauxpark fauxpark deleted the ssd1306-remove-adafruit-header branch June 17, 2020 11:42
nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request Sep 6, 2020
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request Sep 30, 2020
kjganz pushed a commit to kjganz/qmk_firmware that referenced this pull request Oct 28, 2020
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants