Increase the infinity60 system tick frequency #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tianminc if you have the chance, would you be willing to test these changes? It appears that you're the only one with an infinity60 that I could find :) |
|
@jackhumbert Sure thing. Is there something other than normal typing experience that I need to test for? |
|
I think for now, testing the normal typing experience is enough. |
|
I tested this change on Infinity60 v1.1 (with LEDs) and it works well. Whether console output is enabled or not, the keyboard is very responsive and does not drop any key even when swiping across keys quickly. Thank you very much for the fix! |
|
Awesome! |
belak
added a commit
to belak-forks/qmk_firmware
that referenced
this pull request
Jan 9, 2017
Based off of PR qmk#866 which did the same thing for the infinity60
SjB
pushed a commit
to SjB/qmk_firmware
that referenced
this pull request
Jan 16, 2017
Based off of PR qmk#866 which did the same thing for the infinity60
tusing
pushed a commit
to tusing/qmk_firmware
that referenced
this pull request
Aug 3, 2017
Based off of PR qmk#866 which did the same thing for the infinity60
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The system tick frequency was set to 1000, so the minimum waitable time is 1ms. This causes a slow matrix scan as reported in #855. This sets it to 100000 or 10us.
I don't own an Infinity 60, so I haven't been able to test this myself, therefore I need someone to test it before it can be merged. The code is the same as I use for the Infinity Ergodox so at least it works there. However the Infinity 60 has a weaker processor so the magic 20us wait in the matrix scan might not be correct for that keyboard.