Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: Hide json-keymap subcommand, as it's been deprecated. #8477

Merged
merged 1 commit into from
Mar 18, 2020
Merged

CLI: Hide json-keymap subcommand, as it's been deprecated. #8477

merged 1 commit into from
Mar 18, 2020

Conversation

Erovia
Copy link
Member

@Erovia Erovia commented Mar 18, 2020

Description

The json-keymap subcommand was deprecated in #8372.
The new command json2c is right under it with the same description.
In order to avoid confusion, this one should be hidden until we remove it.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@Erovia Erovia requested a review from skullydazed March 18, 2020 17:14
@skullydazed skullydazed merged commit 8123dd2 into qmk:master Mar 18, 2020
@Erovia Erovia deleted the cli/hide_json-keymap branch March 18, 2020 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skullydazed skullydazed skullydazed approved these changes

Assignees
No one assigned
Labels
cli qmk cli command enhancement python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Erovia @skullydazed