Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed #8259 #8333

Merged
merged 1 commit into from
Mar 7, 2020
Merged

fixed #8259 #8333

merged 1 commit into from
Mar 7, 2020

Conversation

yulei
Copy link
Contributor

@yulei yulei commented Mar 7, 2020 •
edited by zvecr
Loading

Description

upgrade board configurations to the latest chibios and fixed #8259

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc requested a review from a team March 7, 2020 05:16
@tzarc tzarc requested a review from a team March 7, 2020 05:17
noroadsleft
noroadsleft approved these changes Mar 7, 2020
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

__attribute__ ((weak)) ✔️

@zvecr zvecr merged commit e0d15e6 into qmk:master Mar 7, 2020
c0psrul3 pushed a commit to c0psrul3/qmk_firmware that referenced this pull request Mar 23, 2020
@yulei @c0psrul3
fixed qmk#8259 (qmk#8333)
acc382d
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request Apr 2, 2020
@yulei @sowbug
fixed qmk#8259 (qmk#8333)
2cac2be
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Apr 10, 2020
@yulei @HokieGeek
fixed qmk#8259 (qmk#8333)
d9ea919
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@yulei @kujawakk
fixed qmk#8259 (qmk#8333)
889c056
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@yulei @jakobaa
fixed qmk#8259 (qmk#8333)
3403d54
jakeisnt pushed a commit to jakeisnt/qmk_firmware that referenced this pull request Aug 20, 2020
@yulei @jakeisnt
fixed qmk#8259 (qmk#8333)
4b9c751
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@fauxpark fauxpark fauxpark approved these changes

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
bug keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] [matrix/noah] Mod-Tap requires 2 taps to initiate
5 participants
@yulei @tzarc @fauxpark @noroadsleft @zvecr