Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Keyboard: SiddersKB Majbritt (Pronounced My Brit) #8260

Merged
merged 12 commits into from
Mar 4, 2020
Merged

New Keyboard: SiddersKB Majbritt (Pronounced My Brit) #8260

merged 12 commits into from
Mar 4, 2020

Conversation

mechmerlin
Copy link
Contributor

@mechmerlin mechmerlin commented Feb 27, 2020 •
edited
Loading

Description

New Keyboard - Alice Style with arrows.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

drashna
drashna requested changes Mar 1, 2020
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nitpick or two.

keyboards/sidderskb/majbritt/majbritt.c Outdated Show resolved Hide resolved
fauxpark
fauxpark requested changes Mar 1, 2020
View reviewed changes
keyboards/sidderskb/majbritt/rules.mk Outdated Show resolved Hide resolved
keyboards/sidderskb/majbritt/keymaps/default/config.h Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team March 4, 2020 08:47
@Duckle29 Duckle29 merged commit 23eb9f4 into qmk:master Mar 4, 2020
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Mar 5, 2020
@mechmerlin @drashna
@fauxpark @HokieGeek
New Keyboard: SiddersKB Majbritt (Pronounced My Brit) (qmk#8260)
5c0ee45 
* Initial commit of majbritt

* Add QMK and VIA support to majbritt

* Change vendor and product id

* Change name

* Change make path

* Move Majbritt into sidderskb directory

* Update keyboards/sidderskb/majbritt/majbritt.c

Co-Authored-By: Drashna Jaelre <[email protected]>
Co-Authored-By: Ryan <[email protected]>

* Update keyboards/sidderskb/majbritt/keymaps/default/config.h
Co-Authored-By: Ryan <[email protected]>

* remove unused file
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
nesth pushed a commit to nesth/qmk_firmware that referenced this pull request Mar 5, 2020
Merge remote-tracking branch 'upstream/master'
4aeb119 
* upstream/master: (37 commits)
  Add RGB lighting through one of the free pins (qmk#8294)
  [Keymap] Adding the 4sStylZ xd75 (qmk#8285)
  YD60MQ refactor and Configurator layout support (qmk#8313)
  [Keyboard] Forget to ifdef Super16 led config (qmk#8314)
  [Keyboard] Switch to RGB Matrix for Super16 (qmk#8305)
  [Keymap] Keymap Update (qmk#8309)
  New Keyboard: SiddersKB Majbritt (Pronounced My Brit) (qmk#8260)
  [Keyboard] VIA Support: Tada68 (qmk#8289)
  [Keyboard] LFK78 refactor (qmk#7835)
  [Keymap] new userspace for ibnuda (qmk#8221)
  [Keymap] Add crd's equinox keymap (qmk#8251)
  [Keymap] Feature/alfrdmalr/keymap update (qmk#8174)
  Fix bootloader definition for namecard2x4 (qmk#8301)
  Update Hungarian keymap and add sendstring LUT (qmk#8220)
  Remove "ugly hack in usb_main.c" comments (qmk#8296)
  Update encoder functions for Iris VIA keymap (qmk#8295)
  Reduce PROGMEM usage for sendstring LUT (qmk#8109)
  [Docs] Update ISP Flashing guide (qmk#8149)
  Rewrite the Bathroom Epiphanies Frosty Flake matrix and LED handling (qmk#8243)
  Add onekey keymap for testing reset to bootloader. (qmk#8288)
  ...
c0psrul3 pushed a commit to c0psrul3/qmk_firmware that referenced this pull request Mar 23, 2020
@mechmerlin @drashna
@fauxpark @c0psrul3
New Keyboard: SiddersKB Majbritt (Pronounced My Brit) (qmk#8260)
bc262a1 
* Initial commit of majbritt

* Add QMK and VIA support to majbritt

* Change vendor and product id

* Change name

* Change make path

* Move Majbritt into sidderskb directory

* Update keyboards/sidderskb/majbritt/majbritt.c

Co-Authored-By: Drashna Jaelre <[email protected]>
Co-Authored-By: Ryan <[email protected]>

* Update keyboards/sidderskb/majbritt/keymaps/default/config.h
Co-Authored-By: Ryan <[email protected]>

* remove unused file
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request Apr 2, 2020
@mechmerlin @drashna
@fauxpark @sowbug
New Keyboard: SiddersKB Majbritt (Pronounced My Brit) (qmk#8260)
49b22a6 
* Initial commit of majbritt

* Add QMK and VIA support to majbritt

* Change vendor and product id

* Change name

* Change make path

* Move Majbritt into sidderskb directory

* Update keyboards/sidderskb/majbritt/majbritt.c

Co-Authored-By: Drashna Jaelre <[email protected]>
Co-Authored-By: Ryan <[email protected]>

* Update keyboards/sidderskb/majbritt/keymaps/default/config.h
Co-Authored-By: Ryan <[email protected]>

* remove unused file
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
@mechmerlin mechmerlin deleted the feature/majbritt branch April 18, 2020 03:16
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@mechmerlin @drashna
@fauxpark @kujawakk
New Keyboard: SiddersKB Majbritt (Pronounced My Brit) (qmk#8260)
210546d 
* Initial commit of majbritt

* Add QMK and VIA support to majbritt

* Change vendor and product id

* Change name

* Change make path

* Move Majbritt into sidderskb directory

* Update keyboards/sidderskb/majbritt/majbritt.c

Co-Authored-By: Drashna Jaelre <[email protected]>
Co-Authored-By: Ryan <[email protected]>

* Update keyboards/sidderskb/majbritt/keymaps/default/config.h
Co-Authored-By: Ryan <[email protected]>

* remove unused file
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
jakeisnt pushed a commit to jakeisnt/qmk_firmware that referenced this pull request Aug 20, 2020
@mechmerlin @drashna
@fauxpark @jakeisnt
New Keyboard: SiddersKB Majbritt (Pronounced My Brit) (qmk#8260)
a075ab4 
* Initial commit of majbritt

* Add QMK and VIA support to majbritt

* Change vendor and product id

* Change name

* Change make path

* Move Majbritt into sidderskb directory

* Update keyboards/sidderskb/majbritt/majbritt.c

Co-Authored-By: Drashna Jaelre <[email protected]>
Co-Authored-By: Ryan <[email protected]>

* Update keyboards/sidderskb/majbritt/keymaps/default/config.h
Co-Authored-By: Ryan <[email protected]>

* remove unused file
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Duckle29 Duckle29 Duckle29 left review comments

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mechmerlin @drashna @Duckle29 @fauxpark