-
-
Notifications
You must be signed in to change notification settings - Fork 40.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc update zh-cn #8147
doc update zh-cn #8147
Conversation
Timestamp was added at the end of the document, it can help me manage version easier.
Could you please change the encoding to UTF-8? It looks like this locally: Related: #7665 |
notepad++ default to GB2312, already fixed. |
Sorry, there were no changes in that last commit. |
Much better, thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a general comment:
Adding a timestamp as you've done here is fine, but the group that's been doing our Japanese translations has been using the original commit hash to track the source English doc:
This has the advantage that it's not specific to a time zone as your method is, in the event someone who perhaps speaks Chinese but doesn't live in China wants to check changes to the English doc that may need updating on the translation.
Anyway, looks good to me. Thank you for your contributions!
Also, I'm a Notepad++ user myself; you can change the default file encoding under Settings / Preferences / New Document / Encoding (in English, anyway 😃), if it suits. Encoding of an existing file can be changed in the Encoding menu. |
Your method looks very good, but I can't find the way to generate the string of"eae21eed7" with "docs/arm_debugging.md" ,"eae21eed7" is not the commit hash "52c18ef02" and even not md5/sha1 of the document. |
Already set but don't work, maybe something wrong with the program. I‘d better use vscode.Thanks. |
The The line with |
Thanks. I will learn to use Git. |
* update zh-cn translate Timestamp was added at the end of the document, it can help me manage version easier. * fix _summary.md to utf-8 * fix _summary.md with vscode
* update zh-cn translate Timestamp was added at the end of the document, it can help me manage version easier. * fix _summary.md to utf-8 * fix _summary.md with vscode
* update zh-cn translate Timestamp was added at the end of the document, it can help me manage version easier. * fix _summary.md to utf-8 * fix _summary.md with vscode
* update zh-cn translate Timestamp was added at the end of the document, it can help me manage version easier. * fix _summary.md to utf-8 * fix _summary.md with vscode
* update zh-cn translate Timestamp was added at the end of the document, it can help me manage version easier. * fix _summary.md to utf-8 * fix _summary.md with vscode
Timestamp was added at the end of the document, it can help me manage version easier.
Description
QMK has changed a lot, so has the documents.
Timestamp was added at the end of the document.
It is suggested to add a timestamp to the document to facilitate the translator to manage the version.
武汉加油!
Types of Changes
Issues Fixed or Closed by This PR
Checklist