Fix ChibiOS timer overflow for 16-bit system clock devices. #8078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
approved these changes
Feb 5, 2020
|
Tested on Planck EZ (STM32F303), seems to work fine. |
@drashna Did you change the ChibiOS config to use another timer than TIM2? (Just working out which pathways have been tested) |
|
Nope, but I can/will test that. Though, the EZ is using PWM on TIM3 |
|
To add fuel to the fire, was already using TIM21 on my L082. |
tzarc
force-pushed
the
future_16bit_systick
branch
from
4b31cea to
ce36a9c
Compare
|
Rebased to fix conflicts. |
tzarc
changed the title
tzarc
force-pushed
the
future_16bit_systick
branch
from
ce36a9c to
2cf89ed
Compare
noroadsleft
approved these changes
Feb 15, 2020
noroadsleft
added
the
breaking_change
noroadsleft
pushed a commit
to noroadsleft/qmk_firmware
that referenced
this pull request
Feb 21, 2020
noroadsleft
pushed a commit
that referenced
this pull request
Feb 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When running a high SysTick frequency on 16-bit devices, the "simplified" timer implementation on the original PR #7597 was not tested thoroughly enough and was incorrectly ignoring overflows.
This PR support for overflow when running on 16-bit devices.
It also updates
timer_expiredandtimer_expired32to be defines, as when compiling for debug mode, the linker has already stripped out the inline functions.Types of Changes
Checklist