Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skog Lite: disable Console; update info.json #8058

Merged
merged 3 commits into from
Feb 1, 2020

Conversation

noroadsleft
Copy link
Member

Description

Had a report on Discord from a user who kept getting a "22 bytes too big" error when compiling the Skog Lite. Checked it myself; you can't get firmware if you add a layer, because the default compiles with only 178 bytes free in Configurator, out of the box.

Disabled Console to claw back some firmware space.

Also updated the JSON because this board's got quite an interesting layout for a TKL.

Types of Changes

  • Enhancement/optimization
  • Keyboard (addition or update)

Checklist

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Add comments regarding the rules, to more closely match the ps2avrgb template.
This board has a quite interesting take on the standard TKL; why not show it off?
@zvecr zvecr requested a review from a team February 1, 2020 02:30
@noroadsleft noroadsleft merged commit 1858c3e into qmk:master Feb 1, 2020
@noroadsleft noroadsleft deleted the cf/skog_lite branch February 1, 2020 08:42
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
* disable Console to save firmware space

* rules.mk templating

Add comments regarding the rules, to more closely match the ps2avrgb template.

* update info.json

This board has a quite interesting take on the standard TKL; why not show it off?
c0psrul3 pushed a commit to c0psrul3/qmk_firmware that referenced this pull request Mar 23, 2020
* disable Console to save firmware space

* rules.mk templating

Add comments regarding the rules, to more closely match the ps2avrgb template.

* update info.json

This board has a quite interesting take on the standard TKL; why not show it off?
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
* disable Console to save firmware space

* rules.mk templating

Add comments regarding the rules, to more closely match the ps2avrgb template.

* update info.json

This board has a quite interesting take on the standard TKL; why not show it off?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants