[keymap(kyria), refactor] created kyria keymap. refactored ninjonas userspace #8053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…serspace and keyboards
Duckle29
approved these changes
Jan 31, 2020
Duckle29
requested changes
Jan 31, 2020
Thanks @Duckle29 for the code review. Just pushed the changes requested. |
Duckle29
approved these changes
Jan 31, 2020
noroadsleft
reviewed
Feb 1, 2020
noroadsleft
approved these changes
Feb 1, 2020
|
Thanks! |
HokieGeek
pushed a commit
to HokieGeek/qmk_firmware
that referenced
this pull request
Feb 21, 2020
…serspace (qmk#8053) * [keymap(kyria), refactor] created kyria keymap. refactored ninjonas userspace and keyboards * [fix(qmk#8053)] removed redundant code based off Duckle29's code review * [fix(qmk#8053)] fixing typos * [refactor(qmk#8053)] updating oled timeout * [fix(8053) resolved code review issues identified by noroadsleft
c0psrul3
pushed a commit
to c0psrul3/qmk_firmware
that referenced
this pull request
Mar 23, 2020
…serspace (qmk#8053) * [keymap(kyria), refactor] created kyria keymap. refactored ninjonas userspace and keyboards * [fix(qmk#8053)] removed redundant code based off Duckle29's code review * [fix(qmk#8053)] fixing typos * [refactor(qmk#8053)] updating oled timeout * [fix(8053) resolved code review issues identified by noroadsleft
kylekuj
pushed a commit
to kylekuj/qmk_firmware
that referenced
this pull request
Apr 21, 2020
…serspace (qmk#8053) * [keymap(kyria), refactor] created kyria keymap. refactored ninjonas userspace and keyboards * [fix(qmk#8053)] removed redundant code based off Duckle29's code review * [fix(qmk#8053)] fixing typos * [refactor(qmk#8053)] updating oled timeout * [fix(8053) resolved code review issues identified by noroadsleft
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
…serspace (qmk#8053) * [keymap(kyria), refactor] created kyria keymap. refactored ninjonas userspace and keyboards * [fix(qmk#8053)] removed redundant code based off Duckle29's code review * [fix(qmk#8053)] fixing typos * [refactor(qmk#8053)] updating oled timeout * [fix(8053) resolved code review issues identified by noroadsleft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist