Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Drink Me #8039

Merged
merged 4 commits into from
Jan 30, 2020
Merged

Add support for Drink Me #8039

merged 4 commits into from
Jan 30, 2020

Conversation

yatara-cc
Copy link
Contributor

Add support and keymaps for Drink Me by Yatara

Contains default, via and several other example keymaps.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

None

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

drashna
drashna requested changes Jan 29, 2020
View reviewed changes
keyboards/yatara/drink_me/keymaps/queen/keymap.c Outdated Show resolved Hide resolved
keyboards/yatara/drink_me/keymaps/queen/keymap.c Outdated Show resolved Hide resolved
keyboards/yatara/drink_me/keymaps/queen/keymap.c Outdated Show resolved Hide resolved
keyboards/yatara/drink_me/keymaps/queen/keymap.c Outdated Show resolved Hide resolved
ridingqwerty
ridingqwerty approved these changes Jan 30, 2020
View reviewed changes
Copy link
Contributor

@ridingqwerty ridingqwerty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, following the amendments suggested by @drashna

@yatara-cc yatara-cc removed the request for review from drashna January 30, 2020 16:21
noroadsleft
noroadsleft requested changes Jan 30, 2020
View reviewed changes
keyboards/yatara/drink_me/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/yatara/drink_me/readme.md Show resolved Hide resolved
keyboards/yatara/drink_me/rules.mk Show resolved Hide resolved
keyboards/yatara/drink_me/rules.mk Show resolved Hide resolved
yatara-cc and others added 2 commits January 30, 2020 21:25
@yatara-cc @noroadsleft
Apply suggestions from code review
f854419 
Co-Authored-By: James Young <[email protected]>
@yatara-cc
Add transparent layers in VIA layout so there are four layers in tota…
17f8af4 
…l. Amend closing bracket indentation in keymap.c files.
@yatara-cc
Copy link
Contributor Author

@noroadsleft @drashna Thank you both for your clear and explanatory suggestions. This is my first time using the GitHub code review process. It's not really clear to me whether I am supposed to click the "re-request review" buttons after responding to suggestions, or perform some other action to say that they've been committed. If one of you could clarify that would be appreciated.

I also wanted to say that I really appreciate all the work that has been put in to this project, both in terms of the software itself and all the support and interaction with the community.

noroadsleft
noroadsleft approved these changes Jan 30, 2020
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@noroadsleft
Copy link
Member

It's not really clear to me whether I am supposed to click the "re-request review" buttons after responding to suggestions, or perform some other action to say that they've been committed. If one of you could clarify that would be appreciated.

You can if you want. I try to regularly check pull requests that I review (once a day at least, if they have updates).

Thanks for the kind words, and your interest in contributing!

@noroadsleft noroadsleft merged commit 31e4583 into qmk:master Jan 30, 2020
This was referenced Jan 31, 2020
Merged
Merged
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
@yatara-cc @HokieGeek
[Keyboard] Add support for Drink Me (qmk#8039)
c6edfd6 
* Add initial configuration and keymaps for Yatara Drink Me.

* Apply suggestions from code review

* Apply suggestions from code review

* Add transparent layers in VIA layout so there are four layers in total. Amend closing bracket indentation in keymap.c files.
c0psrul3 pushed a commit to c0psrul3/qmk_firmware that referenced this pull request Mar 23, 2020
@yatara-cc @c0psrul3
[Keyboard] Add support for Drink Me (qmk#8039)
56776a6 
* Add initial configuration and keymaps for Yatara Drink Me.

* Apply suggestions from code review

* Apply suggestions from code review

* Add transparent layers in VIA layout so there are four layers in total. Amend closing bracket indentation in keymap.c files.
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@yatara-cc @kujawakk
[Keyboard] Add support for Drink Me (qmk#8039)
ae33e5f 
* Add initial configuration and keymaps for Yatara Drink Me.

* Apply suggestions from code review

* Apply suggestions from code review

* Add transparent layers in VIA layout so there are four layers in total. Amend closing bracket indentation in keymap.c files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna requested changes

@ridingqwerty ridingqwerty ridingqwerty approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yatara-cc @noroadsleft @drashna @ridingqwerty