Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce definition of DIODE_DIRECTION for non-custom matrix boards #7915

Merged
merged 4 commits into from
Jan 19, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions keyboards/40percentclub/luddite/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@
#define MATRIX_COL_PINS { F4, F5, F6, F7, B1, B3, B2, B6 }
#define UNUSED_PINS

#define DIODE_DIRECTION COL2ROW

/* number of backlight levels */
#define BACKLIGHT_PIN B5
#ifdef BACKLIGHT_PIN
Expand Down
2 changes: 2 additions & 0 deletions keyboards/7skb/rev1/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#define MATRIX_ROW_PINS { D4, C6, D7, E6, B4 }
#define MATRIX_COL_PINS { F4, F5, F6, F7, B1, B3, B2, B5 }

#define DIODE_DIRECTION COL2ROW

/* Set 0 if debouncing isn't needed */
#define DEBOUNCE 5

Expand Down
2 changes: 2 additions & 0 deletions keyboards/adkb96/rev1/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#define MATRIX_ROW_PINS { D4, C6, D7, E6, B4, B5 }
#define MATRIX_COL_PINS { B6, B2, B3, B1, F7, F6, F5, F4 }

#define DIODE_DIRECTION COL2ROW

#define SOFT_SERIAL_PIN D0

/* define tapping term */
Expand Down
2 changes: 2 additions & 0 deletions keyboards/alps64/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#define MATRIX_ROW_PINS { D0, D1, D2, D3, D4, D5, D6, C2 }
#define UNUSED_PINS

#define DIODE_DIRECTION COL2ROW

/* define if matrix has ghost */
//#define MATRIX_HAS_GHOST

Expand Down
2 changes: 2 additions & 0 deletions keyboards/blackplum/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@
#define MATRIX_COL_PINS { D0, D1, D2, F7, F6, F5, F4, F1 }
#define UNUSED_PINS

#define DIODE_DIRECTION COL2ROW

/* Set 0 if debouncing isn't needed */
#define DEBOUNCE 5

Expand Down
2 changes: 2 additions & 0 deletions keyboards/db/db63/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#define MATRIX_COL_PINS { A0, A1, A2, A3, A4, A5, A6, A7, C7, C6, C5, C4, C3, C2 }
#define UNUSED_PINS

#define DIODE_DIRECTION COL2ROW

#define RGBLED_NUM 18
#define RGBLIGHT_ANIMATIONS

Expand Down
2 changes: 2 additions & 0 deletions keyboards/ergodash/mini/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#define MATRIX_COL_PINS { F4, F5, F6, F7, B1, B3, B2 }
// #define MATRIX_COL_PINS { B2, B3, B1, F7, F6, F5, F4 } //uncomment this line and comment line above if you need to reverse left-to-right key order

#define DIODE_DIRECTION COL2ROW

/* define tapping term */
#define TAPPING_TERM 120

Expand Down
2 changes: 2 additions & 0 deletions keyboards/ergodash/rev1/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#define MATRIX_COL_PINS { F4, F5, F6, F7, B1, B3, B2 }
// #define MATRIX_COL_PINS { B2, B3, B1, F7, F6, F5, F4 } //uncomment this line and comment line above if you need to reverse left-to-right key order

#define DIODE_DIRECTION COL2ROW

/* define tapping term */
#define TAPPING_TERM 120

Expand Down
2 changes: 2 additions & 0 deletions keyboards/handwired/aek64/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#define MATRIX_ROW_PINS { E0, E1, C0, C1, C2 }
#define UNUSED_PINS

#define DIODE_DIRECTION COL2ROW

/* Set 0 if debouncing isn't needed */
#define DEBOUNCE 5

Expand Down
2 changes: 2 additions & 0 deletions keyboards/handwired/dactyl_manuform/4x5/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
// #define MATRIX_COL_PINS { B5, B4, E6, D7, C6 }
#define MATRIX_COL_PINS { C6, D7, E6, B4, B5 }

#define DIODE_DIRECTION COL2ROW

/* define if matrix has ghost */
//#define MATRIX_HAS_GHOST

Expand Down
2 changes: 2 additions & 0 deletions keyboards/handwired/dactyl_manuform/5x6/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#define MATRIX_COL_PINS { D4, C6, D7, E6, B4, B5 }
#define MATRIX_ROW_PINS { F6, F7, B1, B3, B2, B6 }

#define DIODE_DIRECTION COL2ROW

// WS2812 RGB LED strip input and number of LEDs
#define RGB_DI_PIN D3
#define RGBLED_NUM 12
Expand Down
2 changes: 2 additions & 0 deletions keyboards/handwired/dactyl_manuform/5x7/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#define MATRIX_ROW_PINS { D4, C6, D7, E6, B4, B5 }
#define MATRIX_COL_PINS { F5, F6, F7, B1, B3, B2, B6 }

#define DIODE_DIRECTION COL2ROW

// WS2812 RGB LED strip input and number of LEDs
#define RGB_DI_PIN D3
#define RGBLED_NUM 12
2 changes: 2 additions & 0 deletions keyboards/handwired/dactyl_manuform/6x6/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#define MATRIX_COL_PINS { D4, C6, D7, E6, B4, B5 }
#define MATRIX_ROW_PINS { F5, F6, F7, B1, B3, B2, B6 }

#define DIODE_DIRECTION COL2ROW

// WS2812 RGB LED strip input and number of LEDs
#define RGB_DI_PIN D3
#define RGBLED_NUM 12
2 changes: 2 additions & 0 deletions keyboards/handwired/dactyl_manuform/dmote/62key/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@
#define MATRIX_ROW_PINS { F6, F7, B1, B3, B2, B6 }
#define MATRIX_COL_PINS { D4, C6, D7, E6, B4, B5 }

#define DIODE_DIRECTION COL2ROW

// WS2812 RGB LED, normally used to indicate keyboard state:
#define RGBLIGHT_EFFECT_KNIGHT
#define RGBLIGHT_EFFECT_KNIGHT_LENGTH 2
Expand Down
2 changes: 2 additions & 0 deletions keyboards/handwired/dactyl_promicro/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#define MATRIX_COL_PINS { D4, C6, D7, E6, B4, B5 }
#define MATRIX_ROW_PINS { F6, F7, B1, B3, B2, B6 }

#define DIODE_DIRECTION COL2ROW

/* USB Device descriptor parameter */
#define VENDOR_ID 0xFEED
#define PRODUCT_ID 0x3060
Expand Down
4 changes: 2 additions & 2 deletions keyboards/handwired/hacked_motospeed/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#define UNUSED_PINS

/* COL2ROW, ROW2COL*/
//#define DIODE_DIRECTION COL2ROW
#define DIODE_DIRECTION COL2ROW

/*
* Split Keyboard specific options, make sure you have 'SPLIT_KEYBOARD = yes' in your rules.mk, and define SOFT_SERIAL_PIN.
Expand Down Expand Up @@ -245,4 +245,4 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.

/* Bootmagic Lite key configuration */
// #define BOOTMAGIC_LITE_ROW 0
// #define BOOTMAGIC_LITE_COLUMN 0
// #define BOOTMAGIC_LITE_COLUMN 0
2 changes: 2 additions & 0 deletions keyboards/handwired/lovelive9/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@
#define MATRIX_ROW_PINS { NO_PIN }
#define MATRIX_COL_PINS { B4, B6, B2, D7, B1, F7, F6, F5, F4 }

#define DIODE_DIRECTION COL2ROW

#define UNUSED_PINS

/* ws2812 RGB LED */
Expand Down
2 changes: 2 additions & 0 deletions keyboards/handwired/nicekey/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#define MATRIX_ROW_PINS { B6 }
#define UNUSED_PINS

#define DIODE_DIRECTION COL2ROW

/* define if matrix has ghost */
//#define MATRIX_HAS_GHOST

Expand Down
2 changes: 2 additions & 0 deletions keyboards/handwired/onekey/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#define MATRIX_ROWS 1
#define MATRIX_COLS 1

#define DIODE_DIRECTION COL2ROW

/* define if matrix has ghost */
//#define MATRIX_HAS_GHOST

Expand Down
2 changes: 2 additions & 0 deletions keyboards/handwired/splittest/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#define MATRIX_ROWS 2
#define MATRIX_COLS 1

#define DIODE_DIRECTION COL2ROW

/* define if matrix has ghost */
//#define MATRIX_HAS_GHOST

Expand Down
2 changes: 2 additions & 0 deletions keyboards/handwired/wulkan/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@
#define MATRIX_ROW_PINS { B8, A0, A1, A2 }
#define MATRIX_COL_PINS { B13, B14, B15, B9, B7, B6, B5, B4, B3, B2, B1, B0 }

#define DIODE_DIRECTION COL2ROW

/* Debounce reduces chatter (unintended double-presses) - set 0 if debouncing is not needed */
#define DEBOUNCE 5

Expand Down
2 changes: 2 additions & 0 deletions keyboards/keebio/bfo9000/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#define MATRIX_ROW_PINS { D3, D2, D4, C6, D7, E6 }
#define MATRIX_COL_PINS { B5, B6, B2, B3, B1, F7, F6, F5, F4 }

#define DIODE_DIRECTION COL2ROW

/* Set 0 if debouncing isn't needed */
#define DEBOUNCE 5

Expand Down
2 changes: 2 additions & 0 deletions keyboards/keebio/fourier/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#define MATRIX_ROW_PINS { F4, D7, E6, B4 }
#define MATRIX_COL_PINS { F5, F6, F7, B1, B3, B2, B6 }

#define DIODE_DIRECTION COL2ROW

#define QMK_ESC_OUTPUT F5
#define QMK_ESC_INPUT F4
#define QMK_LED B0
Expand Down
2 changes: 2 additions & 0 deletions keyboards/keebio/levinson/rev1/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#define MATRIX_ROW_PINS { D7, E6, B4, B5 }
#define MATRIX_COL_PINS { F6, F7, B1, B3, B2, B6 }

#define DIODE_DIRECTION COL2ROW

/* Set 0 if debouncing isn't needed */
#define DEBOUNCE 5

Expand Down
2 changes: 2 additions & 0 deletions keyboards/keebio/levinson/rev2/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#define MATRIX_ROW_PINS { D4, D7, E6, B4 }
#define MATRIX_COL_PINS { F6, F7, B1, B3, B2, B6 }

#define DIODE_DIRECTION COL2ROW

/* Set 0 if debouncing isn't needed */
#define DEBOUNCE 5

Expand Down
2 changes: 2 additions & 0 deletions keyboards/keebio/levinson/rev3/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#define MATRIX_COL_PINS_RIGHT { F4, F7, D3, B5, B4, E6 }
#define SPLIT_HAND_PIN D2

#define DIODE_DIRECTION COL2ROW

/* Set 0 if debouncing isn't needed */
#define DEBOUNCE 5

Expand Down
2 changes: 2 additions & 0 deletions keyboards/keebio/quefrency/rev1/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#define MATRIX_COL_PINS_RIGHT { F5, F6, F7, B1, B3, B2, B6, C6 }
#define SPLIT_HAND_PIN D2

#define DIODE_DIRECTION COL2ROW

/* Set 0 if debouncing isn't needed */
#define DEBOUNCE 5

Expand Down
2 changes: 2 additions & 0 deletions keyboards/keebio/wavelet/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#define MATRIX_ROW_PINS { F4, F5, F7, B3, D2, D1, D4, D7 }
#define MATRIX_COL_PINS { F6, B1, B2, B6, B4, E6 }

#define DIODE_DIRECTION COL2ROW

/* Set 0 if debouncing isn't needed */
#define DEBOUNCE 5

Expand Down
2 changes: 2 additions & 0 deletions keyboards/lets_split/rev1/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#define MATRIX_COL_PINS { F4, F5, F6, F7, B1, B3 }
// #define MATRIX_COL_PINS { B3, B1, F7, F6, F5, F4 } //uncomment this line and comment line above if you need to reverse left-to-right key order

#define DIODE_DIRECTION COL2ROW

/* define if matrix has ghost */
//#define MATRIX_HAS_GHOST

Expand Down
2 changes: 2 additions & 0 deletions keyboards/lets_split/rev2/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#define MATRIX_COL_PINS { F6, F7, B1, B3, B2, B6 }
// #define MATRIX_COL_PINS { B6, B2, B3, B1, F7, F6 } //uncomment this line and comment line above if you need to reverse left-to-right key order

#define DIODE_DIRECTION COL2ROW

/* define if matrix has ghost */
//#define MATRIX_HAS_GHOST

Expand Down
2 changes: 2 additions & 0 deletions keyboards/lets_split/sockets/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#define MATRIX_COL_PINS { F4, F7, D7, B3, B2, B6}
// #define MATRIX_COL_PINS { B6, B2, B3, D7, F7, F4} //uncomment this line and comment line above if you need to reverse left-to-right key order

#define DIODE_DIRECTION COL2ROW

/* define if matrix has ghost */
//#define MATRIX_HAS_GHOST

Expand Down
2 changes: 2 additions & 0 deletions keyboards/nafuda/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#define MATRIX_ROW_PINS { D1, D0, D4 }
#define MATRIX_COL_PINS { F4, F5, F6 }

#define DIODE_DIRECTION COL2ROW

/* Set 0 if debouncing isn't needed */
#define DEBOUNCE 5

Expand Down
2 changes: 2 additions & 0 deletions keyboards/naked48/rev1/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#define MATRIX_ROW_PINS_RIGHT { D4, C6, D7, E6 }
#define MATRIX_COL_PINS_RIGHT { F4, F5, F6, F7, B1, B3, B2, B6, B4, B5, B2, B2 }

#define DIODE_DIRECTION COL2ROW

/* Set 0 if debouncing isn't needed */
#define DEBOUNCE 5

Expand Down
2 changes: 2 additions & 0 deletions keyboards/naked60/rev1/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
//#define MATRIX_ROW_PINS_RIGHT { D1, D0, D4, C6, B6 }
//#define MATRIX_COL_PINS_RIGHT { F4, F5, F6, F7, B1, B3, B2, D7, E6, B4, B5, D3 }

#define DIODE_DIRECTION COL2ROW

/* Set 0 if debouncing isn't needed */
#define DEBOUNCE 5

Expand Down
2 changes: 2 additions & 0 deletions keyboards/naked64/rev1/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#define MATRIX_ROW_PINS_RIGHT { D4, C6, D7, E6, B4, B5, B2, B2 }
#define MATRIX_COL_PINS_RIGHT { F4, F5, F6, F7, B1, B3, B2, B6 }

#define DIODE_DIRECTION COL2ROW

/* Set 0 if debouncing isn't needed */
#define DEBOUNCE 5

Expand Down
2 changes: 2 additions & 0 deletions keyboards/rgbkb/sol/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#define MATRIX_COLS 7
#define MATRIX_COL_PINS { F0, F1, F4, F5, F6, F7, C7 }

#define DIODE_DIRECTION COL2ROW

/* Set 0 if debouncing isn't needed */
#define DEBOUNCE 5

Expand Down
2 changes: 2 additions & 0 deletions keyboards/rgbkb/zygomorph/rev1/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#define MATRIX_COLS 6
#define MATRIX_COL_PINS { F4, F6, C7, C6, B6, D4 }

#define DIODE_DIRECTION COL2ROW

#define SOFT_SERIAL_PIN D3

#define ENCODERS_PAD_A { D2 }
Expand Down
2 changes: 2 additions & 0 deletions keyboards/runner3680/3x6/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@
#define MATRIX_COL_PINS { F6, F7, B1, B3, B2 ,B6 }
// #define MATRIX_COL_PINS { B6, B2, B3, B1, F7, F6} //uncomment this line and comment line above if you need to reverse left-to-right key order

#define DIODE_DIRECTION COL2ROW

/* define tapping term */
#define TAPPING_TERM 120

Expand Down
2 changes: 2 additions & 0 deletions keyboards/runner3680/3x7/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@
#define MATRIX_COL_PINS { F5, F6, F7, B1, B3, B2 ,B6 }
// #define MATRIX_COL_PINS { B6, B2, B3, B1, F7, F6, F5 } //uncomment this line and comment line above if you need to reverse left-to-right key order

#define DIODE_DIRECTION COL2ROW

/* define tapping term */
#define TAPPING_TERM 120

Expand Down
2 changes: 2 additions & 0 deletions keyboards/runner3680/3x8/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@
#define MATRIX_COL_PINS { F4, F5, F6, F7, B1, B3, B2 ,B6 }
// #define MATRIX_COL_PINS { B6, B2, B3, B1, F7, F6, F5, F4 } //uncomment this line and comment line above if you need to reverse left-to-right key order

#define DIODE_DIRECTION COL2ROW

/* define tapping term */
#define TAPPING_TERM 120

Expand Down
2 changes: 2 additions & 0 deletions keyboards/runner3680/4x6/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@
#define MATRIX_COL_PINS { F6, F7, B1, B3, B2 ,B6 }
// #define MATRIX_COL_PINS { B6, B2, B3, B1, F7, F6} //uncomment this line and comment line above if you need to reverse left-to-right key order

#define DIODE_DIRECTION COL2ROW

/* define tapping term */
#define TAPPING_TERM 120

Expand Down
2 changes: 2 additions & 0 deletions keyboards/runner3680/4x7/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@
#define MATRIX_COL_PINS { F5, F6, F7, B1, B3, B2 ,B6 }
// #define MATRIX_COL_PINS { B6, B2, B3, B1, F7, F6, F5 } //uncomment this line and comment line above if you need to reverse left-to-right key order

#define DIODE_DIRECTION COL2ROW

/* define tapping term */
#define TAPPING_TERM 120

Expand Down
2 changes: 2 additions & 0 deletions keyboards/runner3680/4x8/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@
#define MATRIX_COL_PINS { F4, F5, F6, F7, B1, B3, B2 ,B6 }
// #define MATRIX_COL_PINS { B6, B2, B3, B1, F7, F6, F5, F4 } //uncomment this line and comment line above if you need to reverse left-to-right key order

#define DIODE_DIRECTION COL2ROW

/* define tapping term */
#define TAPPING_TERM 120

Expand Down
Loading