Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove backlight_init_ports from duck/orion/v3 #7878

Merged
merged 1 commit into from
Jan 13, 2020

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jan 13, 2020

Description

Broken with #7273, empty function without the correct custom driver stuff now produces:

Linking: .build/duck_orion_v3_default.elf                                                           [ERRORS]
 | 
 | .build/obj_duck_orion_v3_default/quantum/backlight/backlight_avr.o: In function `backlight_init_ports':
 | /home/zvecr/Desktop/qmk_firmware/quantum/backlight/backlight_avr.c:449: multiple definition of `backlight_init_ports'
 | .build/obj_duck_orion_v3_default/matrix.o:matrix.c:(.text.backlight_init_ports+0x0): first defined here
 | collect2: error: ld returned 1 exit status

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested a review from a team January 13, 2020 03:40
@zvecr zvecr merged commit af03ff1 into qmk:master Jan 13, 2020
@zvecr zvecr deleted the feature/duck_backlight branch January 21, 2020 15:51
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants