Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add h75-singa ver. #7667

Merged
merged 3 commits into from
Dec 26, 2019
Merged

Add h75-singa ver. #7667

merged 3 commits into from
Dec 26, 2019

Conversation

hineybush
Copy link
Contributor

@hineybush hineybush commented Dec 18, 2019 •
edited
Loading

Description

Add the h75_singa PCB - a 75% keyboard designed for the Singa v3.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team December 18, 2019 08:31
@drashna
Copy link
Member

drashna commented Dec 18, 2019

I know you made a comment on discord about this, but your PR looks clean AF! :)

@hineybush
Copy link
Contributor Author

I know you made a comment on discord about this, but your PR looks clean AF! :)

I might finally be learning..

fauxpark
fauxpark requested changes Dec 18, 2019
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a handful of things, looks good otherwise 👍

keyboards/hineybush/h75_singa/h75_singa.c Outdated Show resolved Hide resolved
keyboards/hineybush/h75_singa/keymaps/default/config.h Outdated Show resolved Hide resolved
keyboards/hineybush/h75_singa/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/hineybush/h75_singa/keymaps/wkl_std/config.h Outdated Show resolved Hide resolved
keyboards/hineybush/h75_singa/keymaps/wkl_std/keymap.c Outdated Show resolved Hide resolved
keyboards/hineybush/h75_singa/readme.md Show resolved Hide resolved
mechmerlin
mechmerlin approved these changes Dec 26, 2019
View reviewed changes
Copy link
Contributor

@mechmerlin mechmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@mechmerlin mechmerlin merged commit a14339e into qmk:master Dec 26, 2019
patrl pushed a commit to patrl/qmk_firmware that referenced this pull request Dec 29, 2019
@hineybush @patrl
Add h75-singa ver. (qmk#7667)
deeaa70 
* add h75_singa

* delete some stuff

* update to remove extra crap
@hineybush hineybush deleted the h75-singa branch January 5, 2020 18:16
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
@hineybush @HokieGeek
Add h75-singa ver. (qmk#7667)
293e074 
* add h75_singa

* delete some stuff

* update to remove extra crap
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@hineybush @kujawakk
Add h75-singa ver. (qmk#7667)
ff0a4f6 
* add h75_singa

* delete some stuff

* update to remove extra crap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mechmerlin mechmerlin mechmerlin approved these changes

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hineybush @drashna @fauxpark @mechmerlin