Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Heisenberg handwired keyboard added #7643

Merged
merged 6 commits into from
Dec 17, 2019
Merged

Heisenberg handwired keyboard added #7643

merged 6 commits into from
Dec 17, 2019

Conversation

Ardakilic
Copy link
Contributor

@Ardakilic Ardakilic commented Dec 15, 2019 •
edited
Loading

Description

Heisenberg - A handwired 40% ortholinear keyboard

heisenberg

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

drashna
drashna reviewed Dec 16, 2019
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hate to ask, but could you rename the board to something that isn't so close to "planck"?

Aside from that, everything looks good. I just have a couple of sections flagged that could be cleaned up a bit.

Also, it may be worth adding a keymap_turkish.h and a sendstring_turkish.h in the future. You can see examples of these for other languages here:
https://github.com/qmk/qmk_firmware/tree/master/quantum/keymap_extras
(though, this shouldn't be added to this PR)

keyboards/handwired/chotanck/chotanck.c Outdated Show resolved Hide resolved
keyboards/handwired/chotanck/keymaps/default/keymap.c Outdated Show resolved Hide resolved
@Ardakilic Ardakilic requested a review from drashna December 16, 2019 10:43
@Ardakilic Ardakilic changed the title Chotanck handwired keyboard added Heisenberg handwired keyboard added Dec 16, 2019
@Ardakilic
Copy link
Contributor Author

Ardakilic commented Dec 16, 2019 •
edited
Loading

I renamed it to Heisenberg, I hope it's okay 😄

@drashna
Copy link
Member

drashna commented Dec 16, 2019

Perfect, and actually, that's a pretty awesome name. :)

@drashna drashna requested a review from a team December 16, 2019 19:24
@Ardakilic
Copy link
Contributor Author

Ardakilic commented Dec 16, 2019 •
edited
Loading

Awesome, Thanks @drashna !

By the way, are there any guides for creating a sendstring_language.h file? By looking at them I got lost at this file.

fauxpark
fauxpark requested changes Dec 16, 2019
View reviewed changes
keyboards/handwired/heisenberg/heisenberg.c Outdated Show resolved Hide resolved
keyboards/handwired/heisenberg/heisenberg.h Outdated Show resolved Hide resolved
keyboards/handwired/heisenberg/keymaps/default/config.h Outdated Show resolved Hide resolved
keyboards/handwired/heisenberg/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/handwired/heisenberg/readme.md Outdated Show resolved Hide resolved
keyboards/handwired/heisenberg/rules.mk Outdated Show resolved Hide resolved
keyboards/handwired/heisenberg/rules.mk Outdated Show resolved Hide resolved
keyboards/handwired/heisenberg/rules.mk Outdated Show resolved Hide resolved
keyboards/handwired/heisenberg/rules.mk Outdated Show resolved Hide resolved
keyboards/handwired/heisenberg/rules.mk Outdated Show resolved Hide resolved
@fauxpark
Copy link
Member

@Ardakilic I suppose you're after a Turkish one? I have a bunch of keymap_extras additions and cleanups queued up already, I'll PR the Turkish stuff when I get home :)
But basically, the sendstring LUTs are best used with the keymap_*.h in the same folder, to map the ASCII table to the correct keycodes for the input language/keyboard layout selected in the OS.

@Ardakilic
Copy link
Contributor Author

Ardakilic commented Dec 17, 2019 •
edited
Loading

@fauxpark Indeed, as @drashna suggested. I believe I understood the keymap_*.h, but the structure of sendstring_*.h got me lost there.

Oh and, I commited the changes you requested. I hope it's okay now.

@Ardakilic Ardakilic requested a review from fauxpark December 17, 2019 10:04
fauxpark
fauxpark requested changes Dec 17, 2019
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple more things, looks good otherwise.

keyboards/handwired/heisenberg/info.json Outdated Show resolved Hide resolved
keyboards/handwired/heisenberg/readme.md Outdated Show resolved Hide resolved
keyboards/handwired/heisenberg/rules.mk Outdated Show resolved Hide resolved
@Ardakilic Ardakilic requested a review from fauxpark December 17, 2019 22:28
@fauxpark
Copy link
Member

Thanks! 👍

@fauxpark fauxpark merged commit 78ffc4f into qmk:master Dec 17, 2019
@Ardakilic
Copy link
Contributor Author

Awesome, thank you again @drashna and @fauxpark for the review and the merge!

@Ardakilic Ardakilic deleted the chotanck branch December 17, 2019 23:44
benjaminmikiten added a commit to benjaminmikiten/qmk_firmware that referenced this pull request Dec 18, 2019
@benjaminmikiten
Merge branch 'master' into develop
db79a5b 
* master: (99 commits)
  [Keymap] Added userspace for d4mation. Included their keymap for the Atreus62 (qmk#7483)
  [Keymap] Custom user keymap for Think6.5 with LED range control (qmk#7603)
  [Keymap] CRKBD Custom Keymap - KidBrazil (qmk#7630)
  [Keymap] Add pico 70 keys keymap (qmk#7654)
  Tidy up dztech default keymaps and info.json (qmk#7608)
  Heisenberg handwired keyboard added (qmk#7643)
  [Keyboard] Added Filco Majestouch TKL Pegasus Hoof ISO Layout (qmk#7647)
  Ported J80 to QMK (qmk#7488)
  [Keyboard] Magnavox Videowriter conversion with Pro Micro (qmk#7634)
  [Docs] add japanese translation (basic part) (qmk#7461)
  Tidy up dztech rules.mk
  Relocate RGB keycode processing (qmk#7508)
  Move kwerdenker's personal keymap from RGB (qmk#7645)
  Remove QMK_KEYBOARD_CONFIG_H from boards (qmk#7635)
  Disable usb on slave half to resolve random 'lockup' (qmk#7649)
  [Core] Optimize matrix processing (qmk#7621)
  [Keymap] boy_314's satisfaction75 layout (qmk#7638)
  [Keyboard] XD68 65% ATMega32U4 based (qmk#7395)
  [keyboard] Plain60 cleanups (qmk#7644)
  update default h88 keymap (qmk#7646)
  ...
Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Dec 26, 2019
@Shinichi-Ohki
Merge branch 'master' of https://github.com/qmk/qmk_firmware
01b7405 
* 'master' of https://github.com/qmk/qmk_firmware: (226 commits)
  Make the keyboard beep when Audio is enabled and `\a` is encountered in a sendstring
  Turn off RGB Matrix LEDs when keyboard sleeps (qmk#7713)
  Add backwards compatibility for oled_write_raw_P on ARM
  Update toshi0383 keymap (qmk#7700)
  Completely remove i2c_transmit_receive function (qmk#7686)
  Readded lost pgm_read_word code to encoder array lookups (qmk#7577)
  Add central location for ChibiOS defines (qmk#7542)
  Add TADA68 keymap/rules/config for QMK bootloader (qmk#7679)
  [Docs] fix docs (qmk#7642)
  [Keyboard] Clueboard 60 fix col 11 12 mixup (qmk#7685)
  Missed these LTO blocks
  I corrected my name.
  [Keymap] Added userspace for d4mation. Included their keymap for the Atreus62 (qmk#7483)
  [Keymap] Custom user keymap for Think6.5 with LED range control (qmk#7603)
  [Keymap] CRKBD Custom Keymap - KidBrazil (qmk#7630)
  [Keymap] Add pico 70 keys keymap (qmk#7654)
  Improve docs "Edit Document" footer
  Tidy up dztech config.h
  Tidy up dztech default keymaps and info.json (qmk#7608)
  Heisenberg handwired keyboard added (qmk#7643)
  ...
akrob pushed a commit to akrob/qmk_firmware that referenced this pull request Dec 28, 2019
Merge remote-tracking branch 'upstream/master'
6edd8aa 
* upstream/master: (1080 commits)
  Update toshi0383 keymap (qmk#7700)
  Completely remove i2c_transmit_receive function (qmk#7686)
  Readded lost pgm_read_word code to encoder array lookups (qmk#7577)
  Add central location for ChibiOS defines (qmk#7542)
  Add TADA68 keymap/rules/config for QMK bootloader (qmk#7679)
  [Docs] fix docs (qmk#7642)
  [Keyboard] Clueboard 60 fix col 11 12 mixup (qmk#7685)
  Missed these LTO blocks
  I corrected my name.
  [Keymap] Added userspace for d4mation. Included their keymap for the Atreus62 (qmk#7483)
  [Keymap] Custom user keymap for Think6.5 with LED range control (qmk#7603)
  [Keymap] CRKBD Custom Keymap - KidBrazil (qmk#7630)
  [Keymap] Add pico 70 keys keymap (qmk#7654)
  Improve docs "Edit Document" footer
  Tidy up dztech config.h
  Tidy up dztech default keymaps and info.json (qmk#7608)
  Heisenberg handwired keyboard added (qmk#7643)
  [Keyboard] Added Filco Majestouch TKL Pegasus Hoof ISO Layout (qmk#7647)
  Ported J80 to QMK (qmk#7488)
  [Keyboard] Magnavox Videowriter conversion with Pro Micro (qmk#7634)
  ...
patrl pushed a commit to patrl/qmk_firmware that referenced this pull request Dec 29, 2019
@Ardakilic @fauxpark @patrl
Heisenberg handwired keyboard added (qmk#7643)
3667967 
* Chotanck keyboard added

* Chotanck renamed to Heisenberg

* Further updates to Heisenberg Keyboard done

* Update keyboards/handwired/heisenberg/info.json

Co-Authored-By: fauxpark <[email protected]>

* Update keyboards/handwired/heisenberg/rules.mk

Co-Authored-By: fauxpark <[email protected]>

* Update keyboards/handwired/heisenberg/readme.md

Co-Authored-By: fauxpark <[email protected]>
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
@Ardakilic @fauxpark @HokieGeek
Heisenberg handwired keyboard added (qmk#7643)
7babe99 
* Chotanck keyboard added

* Chotanck renamed to Heisenberg

* Further updates to Heisenberg Keyboard done

* Update keyboards/handwired/heisenberg/info.json

Co-Authored-By: fauxpark <[email protected]>

* Update keyboards/handwired/heisenberg/rules.mk

Co-Authored-By: fauxpark <[email protected]>

* Update keyboards/handwired/heisenberg/readme.md

Co-Authored-By: fauxpark <[email protected]>
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@Ardakilic @fauxpark @kujawakk
Heisenberg handwired keyboard added (qmk#7643)
d473240 
* Chotanck keyboard added

* Chotanck renamed to Heisenberg

* Further updates to Heisenberg Keyboard done

* Update keyboards/handwired/heisenberg/info.json

Co-Authored-By: fauxpark <[email protected]>

* Update keyboards/handwired/heisenberg/rules.mk

Co-Authored-By: fauxpark <[email protected]>

* Update keyboards/handwired/heisenberg/readme.md

Co-Authored-By: fauxpark <[email protected]>
@Ardakilic Ardakilic mentioned this pull request Jul 28, 2021
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ardakilic @drashna @fauxpark