-
-
Notifications
You must be signed in to change notification settings - Fork 40.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove force of debug on within rgblight - causes lockups waiting for hid_listen #7330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackhumbert
approved these changes
Nov 11, 2019
drashna
approved these changes
Nov 11, 2019
This was referenced Nov 14, 2019
Closed
drashna
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
Nov 17, 2019
ripxorip
pushed a commit
to ripxorip/qmk_firmware
that referenced
this pull request
Dec 3, 2019
drashna
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
Dec 6, 2019
patrl
pushed a commit
to patrl/qmk_firmware
that referenced
this pull request
Dec 29, 2019
drashna
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
Jan 2, 2020
fdidron
added a commit
to zsa/qmk_firmware
that referenced
this pull request
Jan 6, 2020
* ARM - ws2812 bitbang (qmk#7173) * Initial ARM bitbang ws2812 driver * Unify chibios platform to run rgblight_task * Remove 'avr only' comments from ws2812 docs * Remove 'avr only' comments from ws2812 docs * Unify chibios platform to run rgblight_task - review comments * Remove debug flags from keymap * Add comments from review * Add defines for STM32L0XX * Attempt to get arm ws2812 working on multiple gcc versions * Support RGBLIGHT_SLEEP when ChibiOS boards suspend (qmk#7280) Copypasta from the AVR suspend implementation with a Teensy-specific hack removed * Unify RGB and RGBW commands (qmk#7297) * Fix unicode in comments Co-Authored-By: fauxpark <[email protected]> * Remove separate RGBW implementation for a unified function * Set White to 0 in RGBW LEDs This is just to get this working, later, proper brightness can be handled elsewhere. * Use us instead of nanoseconds(?) since it renders correctly on web * Remove RGBW function from arm/ws2812.h * Remove RGBW function from arm/ws2812.c * Formatting changes * Add doc info * Remove force of debug on within rgblight - causes lockups waiting for hid_listen (qmk#7330) * Move Ergodox EZ RGB Light code to custom driver (qmk#7309) * Move Ergodox EZ RGB code to custom driver Also implements full addressing of Ergodox EZ's LED Strip, as written by seebs Co-authored-by: Seebs <[email protected]> * Make Clipping range accessible for custom drivers * Remove RGBW_BB_TWI from driver and docs * Revert changes to clipping range support * Use just rgblight_set instead of full custom driver * Convert to i2c_master commands * Rename rgblight driver and clean up includes * Use White channel on RGBW LEDs * SPI DMA based RGB Underglow for STM32 (qmk#7674) * Initial stash of ws2812 spi driver * Update comment, add sync backup plan * Add testing notes to spi ws2812 driver * Align RGBW error messages Co-authored-by: Joel Challis <[email protected]> Co-authored-by: Jonathan Rascher <[email protected]> Co-authored-by: Florian Didron <[email protected]>
fdidron
added a commit
to zsa/qmk_firmware
that referenced
this pull request
Jan 8, 2020
* ARM - ws2812 bitbang (qmk#7173) * Initial ARM bitbang ws2812 driver * Unify chibios platform to run rgblight_task * Remove 'avr only' comments from ws2812 docs * Remove 'avr only' comments from ws2812 docs * Unify chibios platform to run rgblight_task - review comments * Remove debug flags from keymap * Add comments from review * Add defines for STM32L0XX * Attempt to get arm ws2812 working on multiple gcc versions * Support RGBLIGHT_SLEEP when ChibiOS boards suspend (qmk#7280) Copypasta from the AVR suspend implementation with a Teensy-specific hack removed * Unify RGB and RGBW commands (qmk#7297) * Fix unicode in comments Co-Authored-By: fauxpark <[email protected]> * Remove separate RGBW implementation for a unified function * Set White to 0 in RGBW LEDs This is just to get this working, later, proper brightness can be handled elsewhere. * Use us instead of nanoseconds(?) since it renders correctly on web * Remove RGBW function from arm/ws2812.h * Remove RGBW function from arm/ws2812.c * Formatting changes * Add doc info * Remove force of debug on within rgblight - causes lockups waiting for hid_listen (qmk#7330) * Move Ergodox EZ RGB Light code to custom driver (qmk#7309) * Move Ergodox EZ RGB code to custom driver Also implements full addressing of Ergodox EZ's LED Strip, as written by seebs Co-authored-by: Seebs <[email protected]> * Make Clipping range accessible for custom drivers * Remove RGBW_BB_TWI from driver and docs * Revert changes to clipping range support * Use just rgblight_set instead of full custom driver * Convert to i2c_master commands * Rename rgblight driver and clean up includes * Use White channel on RGBW LEDs * SPI DMA based RGB Underglow for STM32 (qmk#7674) * Initial stash of ws2812 spi driver * Update comment, add sync backup plan * Add testing notes to spi ws2812 driver * Align RGBW error messages Co-authored-by: Joel Challis <[email protected]> Co-authored-by: Jonathan Rascher <[email protected]> Co-authored-by: Florian Didron <[email protected]>
HokieGeek
pushed a commit
to HokieGeek/qmk_firmware
that referenced
this pull request
Feb 21, 2020
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reports have started slowly filtering in about the recent RGB changes on ChibiOS, mostly within the context of the Planck v6.
I have reproduced locally, with the default keymap. However if i run hid_listen, then the board works.
Disabling console and the board responds fine. A guess at the core issue, is its like it tries to log, and blocks waiting for someone host side to read. When you disable console, those log functions are compiled out.
Tracking down the logging theme, resulting in chopping out code till the board worked again, resulting in the following line being the culprit:
Seems to resolve the reported Chibios + RGBLIGHT sleep issues too.
Future work
Types of Changes
Issues Fixed or Closed by This PR
Checklist