Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove force of debug on within rgblight - causes lockups waiting for hid_listen #7330

Merged
merged 1 commit into from
Nov 11, 2019

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Nov 11, 2019

Description

Reports have started slowly filtering in about the recent RGB changes on ChibiOS, mostly within the context of the Planck v6.

I have reproduced locally, with the default keymap. However if i run hid_listen, then the board works.
Disabling console and the board responds fine. A guess at the core issue, is its like it tries to log, and blocks waiting for someone host side to read. When you disable console, those log functions are compiled out.

Tracking down the logging theme, resulting in chopping out code till the board worked again, resulting in the following line being the culprit:

diff --git a/quantum/rgblight.c b/quantum/rgblight.c
index a4cbe513e..ea54a349f 100644
--- a/quantum/rgblight.c
+++ b/quantum/rgblight.c
@@ -189,7 +189,7 @@ void rgblight_init(void) {
         return;
     }
 
-    debug_enable = 1;  // Debug ON!
+    //debug_enable = 1;  // Debug ON!
     dprintf("rgblight_init called.\n");
     dprintf("rgblight_init start!\n");
     if (!eeconfig_is_enabled()) {

Seems to resolve the reported Chibios + RGBLIGHT sleep issues too.

Future work

  • figure out why early logging causes issues

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added the bug label Nov 11, 2019
@zvecr zvecr requested a review from a team November 11, 2019 20:24
@zvecr zvecr merged commit f48986d into qmk:master Nov 11, 2019
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request Nov 17, 2019
ripxorip pushed a commit to ripxorip/qmk_firmware that referenced this pull request Dec 3, 2019
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request Dec 6, 2019
patrl pushed a commit to patrl/qmk_firmware that referenced this pull request Dec 29, 2019
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request Jan 2, 2020
fdidron added a commit to zsa/qmk_firmware that referenced this pull request Jan 6, 2020
* ARM - ws2812 bitbang (qmk#7173)

* Initial ARM bitbang ws2812 driver

* Unify chibios platform to run rgblight_task

* Remove 'avr only' comments from ws2812 docs

* Remove 'avr only' comments from ws2812 docs

* Unify chibios platform to run rgblight_task - review comments

* Remove debug flags from keymap

* Add comments from review

* Add defines for STM32L0XX

* Attempt to get arm ws2812 working on multiple gcc versions

* Support RGBLIGHT_SLEEP when ChibiOS boards suspend (qmk#7280)

Copypasta from the AVR suspend implementation with a Teensy-specific
hack removed

* Unify RGB and RGBW commands (qmk#7297)

* Fix unicode in comments

Co-Authored-By: fauxpark <[email protected]>

* Remove separate RGBW implementation for a unified function

* Set White to 0 in RGBW LEDs

This is just to get this working, later, proper brightness can be handled elsewhere.

* Use us instead of nanoseconds(?) since it renders correctly on web

* Remove RGBW function from arm/ws2812.h

* Remove RGBW function from arm/ws2812.c

* Formatting changes

* Add doc info

* Remove force of debug on within rgblight - causes lockups waiting for hid_listen (qmk#7330)

* Move Ergodox EZ RGB Light code to custom driver  (qmk#7309)

* Move Ergodox EZ RGB code to custom driver

Also implements full addressing of Ergodox EZ's LED Strip, as written by seebs
Co-authored-by: Seebs <[email protected]>

* Make Clipping range accessible for custom drivers

* Remove RGBW_BB_TWI from driver and docs

* Revert changes to clipping range support

* Use just rgblight_set instead of full custom driver

* Convert to i2c_master commands

* Rename rgblight driver and clean up includes

* Use White channel on RGBW LEDs

* SPI DMA based RGB Underglow for STM32 (qmk#7674)

* Initial stash of ws2812 spi driver

* Update comment, add sync backup plan

* Add testing notes to spi ws2812 driver

* Align RGBW error messages

Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Jonathan Rascher <[email protected]>
Co-authored-by: Florian Didron <[email protected]>
fdidron added a commit to zsa/qmk_firmware that referenced this pull request Jan 8, 2020
* ARM - ws2812 bitbang (qmk#7173)

* Initial ARM bitbang ws2812 driver

* Unify chibios platform to run rgblight_task

* Remove 'avr only' comments from ws2812 docs

* Remove 'avr only' comments from ws2812 docs

* Unify chibios platform to run rgblight_task - review comments

* Remove debug flags from keymap

* Add comments from review

* Add defines for STM32L0XX

* Attempt to get arm ws2812 working on multiple gcc versions

* Support RGBLIGHT_SLEEP when ChibiOS boards suspend (qmk#7280)

Copypasta from the AVR suspend implementation with a Teensy-specific
hack removed

* Unify RGB and RGBW commands (qmk#7297)

* Fix unicode in comments

Co-Authored-By: fauxpark <[email protected]>

* Remove separate RGBW implementation for a unified function

* Set White to 0 in RGBW LEDs

This is just to get this working, later, proper brightness can be handled elsewhere.

* Use us instead of nanoseconds(?) since it renders correctly on web

* Remove RGBW function from arm/ws2812.h

* Remove RGBW function from arm/ws2812.c

* Formatting changes

* Add doc info

* Remove force of debug on within rgblight - causes lockups waiting for hid_listen (qmk#7330)

* Move Ergodox EZ RGB Light code to custom driver  (qmk#7309)

* Move Ergodox EZ RGB code to custom driver

Also implements full addressing of Ergodox EZ's LED Strip, as written by seebs
Co-authored-by: Seebs <[email protected]>

* Make Clipping range accessible for custom drivers

* Remove RGBW_BB_TWI from driver and docs

* Revert changes to clipping range support

* Use just rgblight_set instead of full custom driver

* Convert to i2c_master commands

* Rename rgblight driver and clean up includes

* Use White channel on RGBW LEDs

* SPI DMA based RGB Underglow for STM32 (qmk#7674)

* Initial stash of ws2812 spi driver

* Update comment, add sync backup plan

* Add testing notes to spi ws2812 driver

* Align RGBW error messages

Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Jonathan Rascher <[email protected]>
Co-authored-by: Florian Didron <[email protected]>
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
@zvecr zvecr deleted the feature/console_rgb_lockup branch April 28, 2020 00:57
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Planck/Preonic works on boot in linux, but if I replug the keyboard it doesn't send signals
3 participants