Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thai translation #7032

Closed
wants to merge 4 commits into from
Closed

Thai translation #7032

wants to merge 4 commits into from

Conversation

narze
Copy link
Contributor

@narze narze commented Oct 14, 2019

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@@ -2,3 +2,4 @@
- [:uk: English](/)
- [:cn: 中文](/zh-cn/)
- [:fr: Français](/fr-fr/)
- [🇹🇭 ไทย](/th-th/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GitHub emoji code for the Thai flag is :thailand: however this doesn't seem to work in Docsify.

There is an open PR for extending the emoji support, but the URL that would be generated for the Thai flag 404s. Maybe we should just use the Unicode character directly for all languages as has been done here.

@drashna drashna requested a review from a team October 16, 2019 18:39
@stale
Copy link

stale bot commented Dec 2, 2019

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@tzarc
Copy link
Member

tzarc commented Nov 9, 2020

This PR hasn't seen progress in quite some time. As such, I'm removing the labels that prevent stalebot from auto-closing this PR. You're free to add commits or comments to keep it alive, but for now there's no reason to keep it open if it's going to sit here inactive, even if it's currently just a draft.

The requirements for PRs have changed since it was raised, so if you'd like to continue the process of getting this into QMK, please refer to the PR Checklist and make the required changes in your next batch of commits. Feel free to reach out to any of the collaborators if you're unsure of things, or even better, ping one of the collaborators on Discord and we can take it from there. Thanks!

@tzarc tzarc added pr_checklist_pending Needs changes as per the PR checklist and removed on hold labels Nov 9, 2020
@stale
Copy link

stale bot commented Dec 25, 2020

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@stale
Copy link

stale bot commented Jan 24, 2021

Thank you for your contribution!
This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready.

@stale stale bot closed this Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants