feat: infinite timeout for leader key #6580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
requested changes
Aug 21, 2019
drashna
requested changes
Oct 16, 2019
13 tasks
|
Thank you for your contribution! |
|
There's a couple merge conflicts in |
I think I properly resolved them |
|
Thank you for your contribution! |
danielo515
force-pushed
the
feat/infinite-leader-timeout
branch
from
a1b1a97
to
559da1f
Compare
drashna
approved these changes
Apr 28, 2020
4 tasks
|
Thank you for your contribution! |
|
If we are all happy with the implementation, I will work on the docs, but I want confirmation first |
|
Thank you for your contribution! |
|
I, I asked some time ago if this was good already to know if I should spend time on the documentation. Could anyone confirm it ? I don't want to write the docs if the idea or the implementation are not going to be accepted. |
That alters the default behavior and makes the feature not work at all because you will not have a leader timeout to compare with for the rest of the sequence. |
|
Just added the missing docs. Could you please validate it? |
|
This is just a friendly reminder, and to avoid it becoming stale. |
|
I'm very interesting in this feature. As a user of QMK, the doc is self-explanatory. |
tzarc
approved these changes
Apr 25, 2021
|
Thanks for taking care @tzarc |
QMK requires any core changes to go to the |
zvecr
pushed a commit
that referenced
this pull request
Apr 28, 2021
|
Thank you very much for the explanation |
14 tasks
14 tasks
noroadsleft
added a commit
that referenced
this pull request
May 29, 2021
* Add Per Key functionality for AutoShift (#11536) * LED Matrix: Reactive effect buffers & advanced indicators (#12588) * [Keyboard] kint36: switch to sym_eager_pk debouncing (#12626) * [Keyboard] kint2pp: reduce input latency by ≈10ms (#12625) * LED Matrix: Split (#12633) * [CI] Format code according to conventions (#12650) * feat: infinite timeout for leader key (#6580) * feat: implement leader_no_timeout logic * docs(leader_key): infinite leader timeout docs * Format code according to conventions (#12680) * Update ADC driver for STM32F1xx, STM32F3xx, STM32F4xx (#12403) * Fix default ADC_RESOLUTION for ADCv3 (and ADCv4) Recent ChibiOS update removed ADC_CFGR1_RES_10BIT from the ADCv3 headers (that macro should not have been there, because ADCv3 has CFGR instead of CFGR1). Fix the default value for ADC_RESOLUTION to use ADC_CFGR_RES_10BITS if it is defined (that name is used for ADCv3 and ADCv4). * Update ADC docs to match the actually used resolution ADC driver for ChibiOS actually uses the 10-bit resolution by default (probably to match AVR); fix the documentation accordingly. Also add both ADC_CFGR_RES_10BITS and ADC_CFGR1_RES_10BIT constants (these names differ according to the ADC implementation in the particular MCU). * Fix pinToMux() for B12 and B13 on STM32F3xx Testing on STM32F303CCT6 revealed that the ADC mux values for B12 and B13 pins were wrong. * Add support for all possible analog pins on STM32F1xx Added ADC mux values for pins A0...A7, B0, B1, C0...C5 on STM32F1xx (they are the same at least for STM32F103x8 and larger F103 devices, and also F102, F105, F107 families). Actually tested on STM32F103C8T6 (therefore pins C0...C5 were not tested). Pins F6...F10, which are present on STM32F103x[C-G] in 144-pin packages, cannot be supported at the moment, because those pins are connected only to ADC3, but the ChibiOS ADC driver for STM32F1xx supports only ADC1. * Add support for all possible analog pins on STM32F4xx Added ADC mux values for pins A0...A7, B0, B1, C0...C5 and optionally F3...F10 (if STM32_ADC_USE_ADC3 is enabled). These mux values are apparently the same for all F4xx devices, except some smaller devices may not have ADC3. Actually tested on STM32F401CCU6, STM32F401CEU6, STM32F411CEU6 (using various WeAct “Blackpill” boards); only pins A0...A7, B0, B1 were tested. Pins F3...F10 are inside `#if STM32_ADC_USE_ADC3` because some devices which don't have ADC3 also don't have the GPIOF port, therefore the code which refers to Fx pins does not compile. * Fix STM32F3xx ADC mux table in documentation The ADC driver documentation had some errors in the mux table for STM32F3xx. Fix this table to match the datasheet and the actual code (mux settings for B12 and B13 were also tested on a real STM32F303CCT6 chip). * Add STM32F1xx ADC pins to the documentation * Add STM32F4xx ADC pins to the documentation * Add initial support for tinyuf2 bootloader (when hosted on F411 blackpill) (#12600) * Add support for jumping to tinyuf2 bootloader. Adds blackpill UF2 example. * Update flashing.md * Update chconf.h * Update config.h * Update halconf.h * Update mcuconf.h * eeprom driver: Refactor where eeprom driver initialisation (and EEPROM emulation initialisation) occurs to make it non-target-specific. (#12671) * Add support for MCU = STM32F446 (#12619) * Add support for MCU = STM32F446 * Update platforms/chibios/GENERIC_STM32_F446XE/configs/config.h * Restore mcuconf.h to the one used by RT-STM32F446RE-NUCLEO64 * stm32f446: update mcuconf.h and board.h for 16MHz operation, with USB enabled, and other peripherals disabled. * Format code according to conventions (#12682) * Format code according to conventions (#12687) * Add STM32L433 and L443 support (#12063) * initial L433 commit * change to XC * fix L433 * disable all peripherals * update system and peripheral clocks * 433 change * use its own board files * revert its own board files * l433 specific change * fix stm32l432xx define * remove duplicate #define * fix bootloader jump * move to L443xx and add i2c2, spi2, usart3 to mcuconf.h * move to L443 * move to L443 * fix sdmmc in mcuconf.h * include STM32L443 * add L443 * Include L443 in compatible microcontrollers * Include L443 in compatible microcontrollers * Update config bootloader jump description * Update ChibiOS define reasoning * Update quantum/mcu_selection.mk * fix git conflict * Updated Function96 with V2 files and removed chconf.h and halconf.h (#12613) * Fix bad PR merge for #6580. (#12721) * Change RGB/LED Matrix to use a simple define for USB suspend (#12697) * [CI] Format code according to conventions (#12731) * Fixing transport's led/rgb matrix suspend state logic (#12770) * [CI] Format code according to conventions (#12772) * Fix comment parsing (#12750) * Added OLED fade out support (#12086) * fix some references to bin/qmk that slipped in (#12832) * Resolve a number of warnings in `qmk generate-api` (#12833) * New command: qmk console (#12828) * stash poc * stash * tidy up implementation * Tidy up slightly for review * Tidy up slightly for review * Bodge environment to make tests pass * Refactor away from asyncio due to windows issues * Filter devices * align vid/pid printing * Add hidapi to the installers * start preparing for multiple hid_listeners * udev rules for hid_listen * refactor to move closer to end state * very basic implementation of the threaded model * refactor how vid/pid/index are supplied and parsed * windows improvements * read the report directly when usage page isn't available * add per-device colors, the choice to show names or numbers, and refactor * add timestamps * Add support for showing bootloaders * tweak the color for bootloaders * Align bootloader disconnect with connect color * add support for showing all bootloaders * fix the pyusb check * tweaks * fix exception * hide a stack trace behind -v * add --no-bootloaders option * add documentation for qmk console * Apply suggestions from code review * pyformat * clean up and flesh out KNOWN_BOOTLOADERS * Remove pointless SERIAL_LINK_ENABLE rules (#12846) * Make Swap Hands use PROGMEM (#12284) This converts the array that the Swap Hands feature uses to use PROGMEM, and to read from that array, as such. Since this array never changes at runtime, there is no reason to keep it in memory. Especially for AVR boards, as memory is a precious resource. * Fix another bin/qmk reference (#12856) * [Keymap] Turn OLED off on suspend in soundmonster keymap (#10419) * Fixup build errors on `develop` branch. (#12723) * LED Matrix: Effects! (#12651) * Fix syntax error when compiling for ARM (#12866) * Remove KEYMAP and LAYOUT_kc (#12160) * alias KEYMAP to LAYOUT * remove KEYMAP and LAYOUT_kc * Add setup, clone, and env to the list of commands we allow even with broken modules (#12868) * Rename `point_t` -> `led_point_t` (#12864) * [Keyboard] updated a vendor name / fixed minor keymap issues (#12881) * Add missing LED Matrix suspend code to suspend.c (#12878) * LED Matrix: Documentation (#12685) * Deprecate `send_unicode_hex_string()` (#12602) * Fix spelling mistake regarding LED Matrix in split_common. (#12888) * [Keymap] Fix QWERTY/DVORAK status output for kzar keymap (#12895) * Use milc.subcommand.config instead of qmk.cli.config (#12915) * Use milc.subcommand.config instead * pyformat * remove the config test * Add function to allow repeated blinking of one layer (#12237) * Implement function rgblight_blink_layer_repeat to allow repeated blinking of one layer at a time * Update doc * Rework rgblight blinking according to requested change * optimize storage * Fixup housekeeping from being invoked twice per loop. (#12933) * matrix: wait for row signal to go HIGH for every row (#12945) I noticed this discrepancy (last row of the matrix treated differently than the others) when optimizing the input latency of my keyboard controller, see also https://michael.stapelberg.ch/posts/2021-05-08-keyboard-input-latency-qmk-kinesis/ Before this commit, when tuning the delays I noticed ghost key presses when pressing the F2 key, which is on the last row of the keyboard matrix: the dead_grave key, which is on the first row of the keyboard matrix, would be incorrectly detected as pressed. After this commit, all keyboard matrix rows are interpreted correctly. I suspect that my setup is more susceptible to this nuance than others because I use GPIO_INPUT_PIN_DELAY=0 and hence don’t have another delay that might mask the problem. * ensure we do not conflict with existing keymap aliases (#12976) * Add support for up to 4 IS31FL3733 drivers (#12342) * Convert Encoder callbacks to be boolean functions (#12805) * [Keyboard] Fix Terrazzo build failure (#12977) * Do not hard set config in CPTC files (#11864) * [Keyboard] Corne - Remove legacy revision support (#12226) * [Keymap] Update to Drashna keymap and user code (based on develop) (#12936) * Add Full-duplex serial driver for ARM boards (#9842) * Document LED_MATRIX_FRAMEBUFFER_EFFECTS (#12987) * Backlight: add defines for default level and breathing state (#12560) * Add dire message about LUFA mass storage bootloader (#13014) * [Keyboard] Remove redundant legacy and common headers for crkbd (#13023) Was causing compiler errors on some systems. * Fix keyboards/keymaps for boolean encoder callback changes (#12985) * `backlight.c`: include `eeprom.h` (#13024) * Add changelog for 2021-05-29 Breaking Changes merge (#12939) * Add ChangeLog for 2021-05-29 Breaking Changes Merge: initial version * Add recent develop changes * Sort recent develop changes * Remove sections for ChibiOS changes per tzarc No ChibiOS changes this round. * Add and sort recent develop changes * add notes about keyboard moves/deletions * import changelog for PR 12172 Documents the change to BOOTMAGIC_ENABLE. * update section headings * re-sort changelog * add additional note regarding Bootmagic changes * remove changelog timestamp * update dates in main Breaking Changes docs * fix broken section anchors in previous changelogs * add link to backlight/eeprom patch to changelog * highlight some more changes * link PRs from section headers * Restore standard readme * run: qmk cformat --core-only
spRite75
added a commit
to spRite75/qmk_firmware
that referenced
this pull request
Jun 7, 2021
* Keyboard: Planck THK (qmk#12597) Co-authored-by: Ryan <[email protected]> Co-authored-by: Jack Humbert <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]> * [Keymap] update gunp layout for Planck (qmk#12926) Co-authored-by: Ryan <[email protected]> * [Keyboard] SKErgo (qmk#12923) Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]> * [Keyboard] Adjustments to Gust Rev1.2 (qmk#12716) Co-authored-by: Eithan Shavit <[email protected]> * [Keyboard] Add RGB Matrix support for Bear65 PCB (qmk#12961) Co-authored-by: Drashna Jaelre <[email protected]> * [Keymap] Add mercutio keymap and update readme.md for layouts (qmk#12973) Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]> Co-authored-by: Jonavin <=> * [Keymap] Add new keymap for ut472 (qmk#12974) * [Keyboard] Removed LAYOUTS = ortho_6x16 (qmk#12983) Removed ortho_6x16 community layout support by commenting out the line. This can be reversed if that layout ever gets added. * Document RGB_MATRIX_FRAMEBUFFER_EFFECTS (qmk#12984) * [Keyboard] Fix Clawsome/Sedan matrix and default keymap (qmk#13007) * Add keymap with scrolling mode for the Ploopy Nano trackball (qmk#13013) Co-authored-by: Drashna Jaelre <[email protected]> * [Keyboard] Fix Delilah VIA Keymap (qmk#13008) Co-authored-by: Drashna Jaelre <[email protected]> * [Keyboard] Add F.Me Macropad (qmk#12658) Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]> * [Keyboard] Add VIA to Aves65 (qmk#12990) * [Keyboard] Add Jabberwocky Keyboard (qmk#12500) Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]> Co-authored-by: Rossman360 <[email protected]> * [Keyboard] Corgi keyboard (qmk#12311) Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]> * [Keymap] add personal keymap files, and sofle_rgb default maps, (qmk#12267) * Sofle rev1 Keymap - featuring keyboard pets (qmk#12499) Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]> * CLI/c2json: Print 'cpp' error when executed in verbose mode (qmk#12869) Co-authored-by: Ryan <[email protected]> * World domination (qmk#13021) Co-authored-by: Nick Brassel <[email protected]> Co-authored-by: Ryan <[email protected]> * 2021 May 29 Breaking Changes Update (qmk#13034) * Add Per Key functionality for AutoShift (qmk#11536) * LED Matrix: Reactive effect buffers & advanced indicators (qmk#12588) * [Keyboard] kint36: switch to sym_eager_pk debouncing (qmk#12626) * [Keyboard] kint2pp: reduce input latency by ≈10ms (qmk#12625) * LED Matrix: Split (qmk#12633) * [CI] Format code according to conventions (qmk#12650) * feat: infinite timeout for leader key (qmk#6580) * feat: implement leader_no_timeout logic * docs(leader_key): infinite leader timeout docs * Format code according to conventions (qmk#12680) * Update ADC driver for STM32F1xx, STM32F3xx, STM32F4xx (qmk#12403) * Fix default ADC_RESOLUTION for ADCv3 (and ADCv4) Recent ChibiOS update removed ADC_CFGR1_RES_10BIT from the ADCv3 headers (that macro should not have been there, because ADCv3 has CFGR instead of CFGR1). Fix the default value for ADC_RESOLUTION to use ADC_CFGR_RES_10BITS if it is defined (that name is used for ADCv3 and ADCv4). * Update ADC docs to match the actually used resolution ADC driver for ChibiOS actually uses the 10-bit resolution by default (probably to match AVR); fix the documentation accordingly. Also add both ADC_CFGR_RES_10BITS and ADC_CFGR1_RES_10BIT constants (these names differ according to the ADC implementation in the particular MCU). * Fix pinToMux() for B12 and B13 on STM32F3xx Testing on STM32F303CCT6 revealed that the ADC mux values for B12 and B13 pins were wrong. * Add support for all possible analog pins on STM32F1xx Added ADC mux values for pins A0...A7, B0, B1, C0...C5 on STM32F1xx (they are the same at least for STM32F103x8 and larger F103 devices, and also F102, F105, F107 families). Actually tested on STM32F103C8T6 (therefore pins C0...C5 were not tested). Pins F6...F10, which are present on STM32F103x[C-G] in 144-pin packages, cannot be supported at the moment, because those pins are connected only to ADC3, but the ChibiOS ADC driver for STM32F1xx supports only ADC1. * Add support for all possible analog pins on STM32F4xx Added ADC mux values for pins A0...A7, B0, B1, C0...C5 and optionally F3...F10 (if STM32_ADC_USE_ADC3 is enabled). These mux values are apparently the same for all F4xx devices, except some smaller devices may not have ADC3. Actually tested on STM32F401CCU6, STM32F401CEU6, STM32F411CEU6 (using various WeAct “Blackpill” boards); only pins A0...A7, B0, B1 were tested. Pins F3...F10 are inside `#if STM32_ADC_USE_ADC3` because some devices which don't have ADC3 also don't have the GPIOF port, therefore the code which refers to Fx pins does not compile. * Fix STM32F3xx ADC mux table in documentation The ADC driver documentation had some errors in the mux table for STM32F3xx. Fix this table to match the datasheet and the actual code (mux settings for B12 and B13 were also tested on a real STM32F303CCT6 chip). * Add STM32F1xx ADC pins to the documentation * Add STM32F4xx ADC pins to the documentation * Add initial support for tinyuf2 bootloader (when hosted on F411 blackpill) (qmk#12600) * Add support for jumping to tinyuf2 bootloader. Adds blackpill UF2 example. * Update flashing.md * Update chconf.h * Update config.h * Update halconf.h * Update mcuconf.h * eeprom driver: Refactor where eeprom driver initialisation (and EEPROM emulation initialisation) occurs to make it non-target-specific. (qmk#12671) * Add support for MCU = STM32F446 (qmk#12619) * Add support for MCU = STM32F446 * Update platforms/chibios/GENERIC_STM32_F446XE/configs/config.h * Restore mcuconf.h to the one used by RT-STM32F446RE-NUCLEO64 * stm32f446: update mcuconf.h and board.h for 16MHz operation, with USB enabled, and other peripherals disabled. * Format code according to conventions (qmk#12682) * Format code according to conventions (qmk#12687) * Add STM32L433 and L443 support (qmk#12063) * initial L433 commit * change to XC * fix L433 * disable all peripherals * update system and peripheral clocks * 433 change * use its own board files * revert its own board files * l433 specific change * fix stm32l432xx define * remove duplicate #define * fix bootloader jump * move to L443xx and add i2c2, spi2, usart3 to mcuconf.h * move to L443 * move to L443 * fix sdmmc in mcuconf.h * include STM32L443 * add L443 * Include L443 in compatible microcontrollers * Include L443 in compatible microcontrollers * Update config bootloader jump description * Update ChibiOS define reasoning * Update quantum/mcu_selection.mk * fix git conflict * Updated Function96 with V2 files and removed chconf.h and halconf.h (qmk#12613) * Fix bad PR merge for qmk#6580. (qmk#12721) * Change RGB/LED Matrix to use a simple define for USB suspend (qmk#12697) * [CI] Format code according to conventions (qmk#12731) * Fixing transport's led/rgb matrix suspend state logic (qmk#12770) * [CI] Format code according to conventions (qmk#12772) * Fix comment parsing (qmk#12750) * Added OLED fade out support (qmk#12086) * fix some references to bin/qmk that slipped in (qmk#12832) * Resolve a number of warnings in `qmk generate-api` (qmk#12833) * New command: qmk console (qmk#12828) * stash poc * stash * tidy up implementation * Tidy up slightly for review * Tidy up slightly for review * Bodge environment to make tests pass * Refactor away from asyncio due to windows issues * Filter devices * align vid/pid printing * Add hidapi to the installers * start preparing for multiple hid_listeners * udev rules for hid_listen * refactor to move closer to end state * very basic implementation of the threaded model * refactor how vid/pid/index are supplied and parsed * windows improvements * read the report directly when usage page isn't available * add per-device colors, the choice to show names or numbers, and refactor * add timestamps * Add support for showing bootloaders * tweak the color for bootloaders * Align bootloader disconnect with connect color * add support for showing all bootloaders * fix the pyusb check * tweaks * fix exception * hide a stack trace behind -v * add --no-bootloaders option * add documentation for qmk console * Apply suggestions from code review * pyformat * clean up and flesh out KNOWN_BOOTLOADERS * Remove pointless SERIAL_LINK_ENABLE rules (qmk#12846) * Make Swap Hands use PROGMEM (qmk#12284) This converts the array that the Swap Hands feature uses to use PROGMEM, and to read from that array, as such. Since this array never changes at runtime, there is no reason to keep it in memory. Especially for AVR boards, as memory is a precious resource. * Fix another bin/qmk reference (qmk#12856) * [Keymap] Turn OLED off on suspend in soundmonster keymap (qmk#10419) * Fixup build errors on `develop` branch. (qmk#12723) * LED Matrix: Effects! (qmk#12651) * Fix syntax error when compiling for ARM (qmk#12866) * Remove KEYMAP and LAYOUT_kc (qmk#12160) * alias KEYMAP to LAYOUT * remove KEYMAP and LAYOUT_kc * Add setup, clone, and env to the list of commands we allow even with broken modules (qmk#12868) * Rename `point_t` -> `led_point_t` (qmk#12864) * [Keyboard] updated a vendor name / fixed minor keymap issues (qmk#12881) * Add missing LED Matrix suspend code to suspend.c (qmk#12878) * LED Matrix: Documentation (qmk#12685) * Deprecate `send_unicode_hex_string()` (qmk#12602) * Fix spelling mistake regarding LED Matrix in split_common. (qmk#12888) * [Keymap] Fix QWERTY/DVORAK status output for kzar keymap (qmk#12895) * Use milc.subcommand.config instead of qmk.cli.config (qmk#12915) * Use milc.subcommand.config instead * pyformat * remove the config test * Add function to allow repeated blinking of one layer (qmk#12237) * Implement function rgblight_blink_layer_repeat to allow repeated blinking of one layer at a time * Update doc * Rework rgblight blinking according to requested change * optimize storage * Fixup housekeeping from being invoked twice per loop. (qmk#12933) * matrix: wait for row signal to go HIGH for every row (qmk#12945) I noticed this discrepancy (last row of the matrix treated differently than the others) when optimizing the input latency of my keyboard controller, see also https://michael.stapelberg.ch/posts/2021-05-08-keyboard-input-latency-qmk-kinesis/ Before this commit, when tuning the delays I noticed ghost key presses when pressing the F2 key, which is on the last row of the keyboard matrix: the dead_grave key, which is on the first row of the keyboard matrix, would be incorrectly detected as pressed. After this commit, all keyboard matrix rows are interpreted correctly. I suspect that my setup is more susceptible to this nuance than others because I use GPIO_INPUT_PIN_DELAY=0 and hence don’t have another delay that might mask the problem. * ensure we do not conflict with existing keymap aliases (qmk#12976) * Add support for up to 4 IS31FL3733 drivers (qmk#12342) * Convert Encoder callbacks to be boolean functions (qmk#12805) * [Keyboard] Fix Terrazzo build failure (qmk#12977) * Do not hard set config in CPTC files (qmk#11864) * [Keyboard] Corne - Remove legacy revision support (qmk#12226) * [Keymap] Update to Drashna keymap and user code (based on develop) (qmk#12936) * Add Full-duplex serial driver for ARM boards (qmk#9842) * Document LED_MATRIX_FRAMEBUFFER_EFFECTS (qmk#12987) * Backlight: add defines for default level and breathing state (qmk#12560) * Add dire message about LUFA mass storage bootloader (qmk#13014) * [Keyboard] Remove redundant legacy and common headers for crkbd (qmk#13023) Was causing compiler errors on some systems. * Fix keyboards/keymaps for boolean encoder callback changes (qmk#12985) * `backlight.c`: include `eeprom.h` (qmk#13024) * Add changelog for 2021-05-29 Breaking Changes merge (qmk#12939) * Add ChangeLog for 2021-05-29 Breaking Changes Merge: initial version * Add recent develop changes * Sort recent develop changes * Remove sections for ChibiOS changes per tzarc No ChibiOS changes this round. * Add and sort recent develop changes * add notes about keyboard moves/deletions * import changelog for PR 12172 Documents the change to BOOTMAGIC_ENABLE. * update section headings * re-sort changelog * add additional note regarding Bootmagic changes * remove changelog timestamp * update dates in main Breaking Changes docs * fix broken section anchors in previous changelogs * add link to backlight/eeprom patch to changelog * highlight some more changes * link PRs from section headers * Restore standard readme * run: qmk cformat --core-only * CLI: Fix automagic (qmk#13046) * merge/um70:via: Avoid sprintf() to make the code fit into flash (qmk#12919) The code using sprintf() did not fit into flash when `merge/um70:via` was compiled with avr-gcc 5.4.0: * The firmware is too large! 29756/28672 (1084 bytes over) Replacing `sprintf(wpm_str, " %03d", current_wpm);` with custom formatting code reduces the firmware size by 1504 bytes, which is enough to make the `merge/um70:via` firmware fit: * The firmware size is approaching the maximum - 28252/28672 (98%, 420 bytes free) * [Keyboard] jabberwocky via support (qmk#13029) * [Keyboard] Added BOP support (qmk#12991) Co-authored-by: Ryan <[email protected]> Co-authored-by: Brandon Lewis <[email protected]> * [Keyboard] Unicomp Mini M (qmk#12892) * [Keyboard] Add Rubi Numpad (qmk#12283) Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]> * [Keymap] lja83's Planck keymap (qmk#12809) Co-authored-by: Ryan <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Jeff Apczynski <[email protected]> * VIA compile fixes (qmk#13054) * fix missing arg (qmk#13068) * [Keymap] merge jdelkins userspace and associated keymaps (qmk#11276) * [Keymap] merge jdelkins userspace and associated keymaps * Add copyright & license info * Change rgblight_config.enable to rgblight_is_enabled() * Update keyboards/dz60/keymaps/jdelkins/keymap.c Co-authored-by: Drashna Jaelre <[email protected]> * Update keyboards/dz60/keymaps/jdelkins/keymap.c Co-authored-by: Drashna Jaelre <[email protected]> * Update keyboards/dz60/keymaps/jdelkins/keymap.c Co-authored-by: Drashna Jaelre <[email protected]> * Remove superfluous includes * Change EXTRAFLAGS+=-flto to LTO_ENABLE=yes * Remove unnecessary jdelkins_ss symlink in users * Add copyright and license notices * Use preferred way to determine capslock / numlock state Co-authored-by: Drashna Jaelre <[email protected]> * Add #pragma once to a header Co-authored-by: Drashna Jaelre <[email protected]> * Include QMK_KEYBOARD_H only once, in userspace header * Remove unnecessary initialization in matrix_init_keymap * Do process_record_keymap before cases handled in process_record_user * Reorganize & simplify secrets feature enablement * Use tap_code16 Co-authored-by: Ryan <[email protected]> * Remove superfluous break Co-authored-by: Ryan <[email protected]> * Remove copyright from rules.mk Co-authored-by: Ryan <[email protected]> * Remove copyright from rules.mk Co-authored-by: Ryan <[email protected]> * Use tap_code16 Co-authored-by: Ryan <[email protected]> * include "print.h" instead of <print.h> Co-authored-by: Ryan <[email protected]> * Use tap_cod16 Co-authored-by: Ryan <[email protected]> * Use tap_code16 Co-authored-by: Ryan <[email protected]> * Use tap_code16 Co-authored-by: Ryan <[email protected]> * Use tap_code16 Co-authored-by: Ryan <[email protected]> * Remove copyright from rules.mk Co-authored-by: Ryan <[email protected]> * add #pragma once to a header Co-authored-by: Ryan <[email protected]> * include "print.h" instead of <print.h> Co-authored-by: Ryan <[email protected]> * Remove copyright from rules.mk Co-authored-by: Ryan <[email protected]> * Remove copyright from rules.mk Co-authored-by: Ryan <[email protected]> * Remove copyright from rules.mk Co-authored-by: Ryan <[email protected]> * Use tap_code16 Co-authored-by: Ryan <[email protected]> * Use tap_code16 Co-authored-by: Ryan <[email protected]> * Use :flash target where possible * Remove special case flash target and use PROGRAM_CMD * dz60/jdelkins_ss: use tap_code16 Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]> * Fix up WS2812 SPI driver on F072. (qmk#13022) * Update noroadsleft userspace and keymaps (2021-06-02) (qmk#13086) * Tidy up spi_master includes (qmk#13053) * `qmk multibuild`: Fix bug with Path objects (qmk#13093) * [Keymap] Update bcat's split_3x6_3 for Crkbd legacy removal (qmk#13097) * Fix caps lock indicator on Bear65 PCB (qmk#12966) * kbdfans/kbd67/rev2: add LAYOUT_65_ansi_split_space layout data (qmk#13102) * Fix includes for pmw3360 driver (qmk#13108) * update feature_layers.md translation (qmk#12752) * Update Japanese document (qmk#10670) Co-authored-by: Takeshi ISHII <[email protected]> * JETVAN: Add initial support (qmk#12790) Co-authored-by: Ryan <[email protected]> * Corrected Number-pad numbers (qmk#13057) * [Keymap] add id80/ansi/keymaps/msf (qmk#11957) * Fixed ISO keyboard layout for the Mysterium rev1.1 board (qmk#12531) * [Keyboard] add molecule (qmk#12601) Co-authored-by: Ryan <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]> * [Keyboard] Add program yoink via keymap (qmk#12645) Co-authored-by: Ryan <[email protected]> * [Docs] added basic midi documention of common features (qmk#13113) Co-authored-by: precondition <[email protected]> Co-authored-by: Ryan <[email protected]> Co-authored-by: Joel Challis <[email protected]> * Add default `ortho_1x1` layout (qmk#13118) Co-authored-by: Erovia <[email protected]> Co-authored-by: Ryan <[email protected]> Co-authored-by: Jack Humbert <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Gun Pinyo <[email protected]> Co-authored-by: C1intMason <[email protected]> Co-authored-by: Eithan Shavit <[email protected]> Co-authored-by: Eithan Shavit <[email protected]> Co-authored-by: stanrc85 <[email protected]> Co-authored-by: Jonavin <[email protected]> Co-authored-by: Stefano Pace <[email protected]> Co-authored-by: James Young <[email protected]> Co-authored-by: peepeetee <[email protected]> Co-authored-by: Sean Browning <[email protected]> Co-authored-by: Maddie O'Brien <[email protected]> Co-authored-by: rainkeebs <[email protected]> Co-authored-by: thompson-ele <[email protected]> Co-authored-by: Evelien-Lillian Dekkers <[email protected]> Co-authored-by: nopunin10did <[email protected]> Co-authored-by: Rossman360 <[email protected]> Co-authored-by: Christian Sandven <[email protected]> Co-authored-by: DaneEvans <[email protected]> Co-authored-by: CodeFreak <[email protected]> Co-authored-by: Nick Brassel <[email protected]> Co-authored-by: Sergey Vlasov <[email protected]> Co-authored-by: lukeski14 <[email protected]> Co-authored-by: Brandon Lewis <[email protected]> Co-authored-by: Brandon Lewis <[email protected]> Co-authored-by: Lander <[email protected]> Co-authored-by: Gregorio <[email protected]> Co-authored-by: Jeff Apczynski <[email protected]> Co-authored-by: Jeff Apczynski <[email protected]> Co-authored-by: Xelus22 <[email protected]> Co-authored-by: Joel Elkins <[email protected]> Co-authored-by: Jonathan Rascher <[email protected]> Co-authored-by: umi <[email protected]> Co-authored-by: shela <[email protected]> Co-authored-by: Takeshi ISHII <[email protected]> Co-authored-by: TerryMathews <[email protected]> Co-authored-by: Nathan_Blais <[email protected]> Co-authored-by: Miguel Filipe <[email protected]> Co-authored-by: HalfHeuslerAlloy <[email protected]> Co-authored-by: bbrfkr <[email protected]> Co-authored-by: Matthew Dias <[email protected]> Co-authored-by: wxyangf <[email protected]> Co-authored-by: precondition <[email protected]> Co-authored-by: Joel Challis <[email protected]>
HokieGeek
pushed a commit
to HokieGeek/qmk_firmware
that referenced
this pull request
Jul 11, 2021
* Add Per Key functionality for AutoShift (qmk#11536) * LED Matrix: Reactive effect buffers & advanced indicators (qmk#12588) * [Keyboard] kint36: switch to sym_eager_pk debouncing (qmk#12626) * [Keyboard] kint2pp: reduce input latency by ≈10ms (qmk#12625) * LED Matrix: Split (qmk#12633) * [CI] Format code according to conventions (qmk#12650) * feat: infinite timeout for leader key (qmk#6580) * feat: implement leader_no_timeout logic * docs(leader_key): infinite leader timeout docs * Format code according to conventions (qmk#12680) * Update ADC driver for STM32F1xx, STM32F3xx, STM32F4xx (qmk#12403) * Fix default ADC_RESOLUTION for ADCv3 (and ADCv4) Recent ChibiOS update removed ADC_CFGR1_RES_10BIT from the ADCv3 headers (that macro should not have been there, because ADCv3 has CFGR instead of CFGR1). Fix the default value for ADC_RESOLUTION to use ADC_CFGR_RES_10BITS if it is defined (that name is used for ADCv3 and ADCv4). * Update ADC docs to match the actually used resolution ADC driver for ChibiOS actually uses the 10-bit resolution by default (probably to match AVR); fix the documentation accordingly. Also add both ADC_CFGR_RES_10BITS and ADC_CFGR1_RES_10BIT constants (these names differ according to the ADC implementation in the particular MCU). * Fix pinToMux() for B12 and B13 on STM32F3xx Testing on STM32F303CCT6 revealed that the ADC mux values for B12 and B13 pins were wrong. * Add support for all possible analog pins on STM32F1xx Added ADC mux values for pins A0...A7, B0, B1, C0...C5 on STM32F1xx (they are the same at least for STM32F103x8 and larger F103 devices, and also F102, F105, F107 families). Actually tested on STM32F103C8T6 (therefore pins C0...C5 were not tested). Pins F6...F10, which are present on STM32F103x[C-G] in 144-pin packages, cannot be supported at the moment, because those pins are connected only to ADC3, but the ChibiOS ADC driver for STM32F1xx supports only ADC1. * Add support for all possible analog pins on STM32F4xx Added ADC mux values for pins A0...A7, B0, B1, C0...C5 and optionally F3...F10 (if STM32_ADC_USE_ADC3 is enabled). These mux values are apparently the same for all F4xx devices, except some smaller devices may not have ADC3. Actually tested on STM32F401CCU6, STM32F401CEU6, STM32F411CEU6 (using various WeAct “Blackpill” boards); only pins A0...A7, B0, B1 were tested. Pins F3...F10 are inside `#if STM32_ADC_USE_ADC3` because some devices which don't have ADC3 also don't have the GPIOF port, therefore the code which refers to Fx pins does not compile. * Fix STM32F3xx ADC mux table in documentation The ADC driver documentation had some errors in the mux table for STM32F3xx. Fix this table to match the datasheet and the actual code (mux settings for B12 and B13 were also tested on a real STM32F303CCT6 chip). * Add STM32F1xx ADC pins to the documentation * Add STM32F4xx ADC pins to the documentation * Add initial support for tinyuf2 bootloader (when hosted on F411 blackpill) (qmk#12600) * Add support for jumping to tinyuf2 bootloader. Adds blackpill UF2 example. * Update flashing.md * Update chconf.h * Update config.h * Update halconf.h * Update mcuconf.h * eeprom driver: Refactor where eeprom driver initialisation (and EEPROM emulation initialisation) occurs to make it non-target-specific. (qmk#12671) * Add support for MCU = STM32F446 (qmk#12619) * Add support for MCU = STM32F446 * Update platforms/chibios/GENERIC_STM32_F446XE/configs/config.h * Restore mcuconf.h to the one used by RT-STM32F446RE-NUCLEO64 * stm32f446: update mcuconf.h and board.h for 16MHz operation, with USB enabled, and other peripherals disabled. * Format code according to conventions (qmk#12682) * Format code according to conventions (qmk#12687) * Add STM32L433 and L443 support (qmk#12063) * initial L433 commit * change to XC * fix L433 * disable all peripherals * update system and peripheral clocks * 433 change * use its own board files * revert its own board files * l433 specific change * fix stm32l432xx define * remove duplicate #define * fix bootloader jump * move to L443xx and add i2c2, spi2, usart3 to mcuconf.h * move to L443 * move to L443 * fix sdmmc in mcuconf.h * include STM32L443 * add L443 * Include L443 in compatible microcontrollers * Include L443 in compatible microcontrollers * Update config bootloader jump description * Update ChibiOS define reasoning * Update quantum/mcu_selection.mk * fix git conflict * Updated Function96 with V2 files and removed chconf.h and halconf.h (qmk#12613) * Fix bad PR merge for qmk#6580. (qmk#12721) * Change RGB/LED Matrix to use a simple define for USB suspend (qmk#12697) * [CI] Format code according to conventions (qmk#12731) * Fixing transport's led/rgb matrix suspend state logic (qmk#12770) * [CI] Format code according to conventions (qmk#12772) * Fix comment parsing (qmk#12750) * Added OLED fade out support (qmk#12086) * fix some references to bin/qmk that slipped in (qmk#12832) * Resolve a number of warnings in `qmk generate-api` (qmk#12833) * New command: qmk console (qmk#12828) * stash poc * stash * tidy up implementation * Tidy up slightly for review * Tidy up slightly for review * Bodge environment to make tests pass * Refactor away from asyncio due to windows issues * Filter devices * align vid/pid printing * Add hidapi to the installers * start preparing for multiple hid_listeners * udev rules for hid_listen * refactor to move closer to end state * very basic implementation of the threaded model * refactor how vid/pid/index are supplied and parsed * windows improvements * read the report directly when usage page isn't available * add per-device colors, the choice to show names or numbers, and refactor * add timestamps * Add support for showing bootloaders * tweak the color for bootloaders * Align bootloader disconnect with connect color * add support for showing all bootloaders * fix the pyusb check * tweaks * fix exception * hide a stack trace behind -v * add --no-bootloaders option * add documentation for qmk console * Apply suggestions from code review * pyformat * clean up and flesh out KNOWN_BOOTLOADERS * Remove pointless SERIAL_LINK_ENABLE rules (qmk#12846) * Make Swap Hands use PROGMEM (qmk#12284) This converts the array that the Swap Hands feature uses to use PROGMEM, and to read from that array, as such. Since this array never changes at runtime, there is no reason to keep it in memory. Especially for AVR boards, as memory is a precious resource. * Fix another bin/qmk reference (qmk#12856) * [Keymap] Turn OLED off on suspend in soundmonster keymap (qmk#10419) * Fixup build errors on `develop` branch. (qmk#12723) * LED Matrix: Effects! (qmk#12651) * Fix syntax error when compiling for ARM (qmk#12866) * Remove KEYMAP and LAYOUT_kc (qmk#12160) * alias KEYMAP to LAYOUT * remove KEYMAP and LAYOUT_kc * Add setup, clone, and env to the list of commands we allow even with broken modules (qmk#12868) * Rename `point_t` -> `led_point_t` (qmk#12864) * [Keyboard] updated a vendor name / fixed minor keymap issues (qmk#12881) * Add missing LED Matrix suspend code to suspend.c (qmk#12878) * LED Matrix: Documentation (qmk#12685) * Deprecate `send_unicode_hex_string()` (qmk#12602) * Fix spelling mistake regarding LED Matrix in split_common. (qmk#12888) * [Keymap] Fix QWERTY/DVORAK status output for kzar keymap (qmk#12895) * Use milc.subcommand.config instead of qmk.cli.config (qmk#12915) * Use milc.subcommand.config instead * pyformat * remove the config test * Add function to allow repeated blinking of one layer (qmk#12237) * Implement function rgblight_blink_layer_repeat to allow repeated blinking of one layer at a time * Update doc * Rework rgblight blinking according to requested change * optimize storage * Fixup housekeeping from being invoked twice per loop. (qmk#12933) * matrix: wait for row signal to go HIGH for every row (qmk#12945) I noticed this discrepancy (last row of the matrix treated differently than the others) when optimizing the input latency of my keyboard controller, see also https://michael.stapelberg.ch/posts/2021-05-08-keyboard-input-latency-qmk-kinesis/ Before this commit, when tuning the delays I noticed ghost key presses when pressing the F2 key, which is on the last row of the keyboard matrix: the dead_grave key, which is on the first row of the keyboard matrix, would be incorrectly detected as pressed. After this commit, all keyboard matrix rows are interpreted correctly. I suspect that my setup is more susceptible to this nuance than others because I use GPIO_INPUT_PIN_DELAY=0 and hence don’t have another delay that might mask the problem. * ensure we do not conflict with existing keymap aliases (qmk#12976) * Add support for up to 4 IS31FL3733 drivers (qmk#12342) * Convert Encoder callbacks to be boolean functions (qmk#12805) * [Keyboard] Fix Terrazzo build failure (qmk#12977) * Do not hard set config in CPTC files (qmk#11864) * [Keyboard] Corne - Remove legacy revision support (qmk#12226) * [Keymap] Update to Drashna keymap and user code (based on develop) (qmk#12936) * Add Full-duplex serial driver for ARM boards (qmk#9842) * Document LED_MATRIX_FRAMEBUFFER_EFFECTS (qmk#12987) * Backlight: add defines for default level and breathing state (qmk#12560) * Add dire message about LUFA mass storage bootloader (qmk#13014) * [Keyboard] Remove redundant legacy and common headers for crkbd (qmk#13023) Was causing compiler errors on some systems. * Fix keyboards/keymaps for boolean encoder callback changes (qmk#12985) * `backlight.c`: include `eeprom.h` (qmk#13024) * Add changelog for 2021-05-29 Breaking Changes merge (qmk#12939) * Add ChangeLog for 2021-05-29 Breaking Changes Merge: initial version * Add recent develop changes * Sort recent develop changes * Remove sections for ChibiOS changes per tzarc No ChibiOS changes this round. * Add and sort recent develop changes * add notes about keyboard moves/deletions * import changelog for PR 12172 Documents the change to BOOTMAGIC_ENABLE. * update section headings * re-sort changelog * add additional note regarding Bootmagic changes * remove changelog timestamp * update dates in main Breaking Changes docs * fix broken section anchors in previous changelogs * add link to backlight/eeprom patch to changelog * highlight some more changes * link PRs from section headers * Restore standard readme * run: qmk cformat --core-only
nhongooi
pushed a commit
to nhongooi/qmk_firmware
that referenced
this pull request
Dec 5, 2021
* feat: implement leader_no_timeout logic * docs(leader_key): infinite leader timeout docs
nhongooi
pushed a commit
to nhongooi/qmk_firmware
that referenced
this pull request
Dec 5, 2021
nhongooi
pushed a commit
to nhongooi/qmk_firmware
that referenced
this pull request
Dec 5, 2021
* Add Per Key functionality for AutoShift (qmk#11536) * LED Matrix: Reactive effect buffers & advanced indicators (qmk#12588) * [Keyboard] kint36: switch to sym_eager_pk debouncing (qmk#12626) * [Keyboard] kint2pp: reduce input latency by ≈10ms (qmk#12625) * LED Matrix: Split (qmk#12633) * [CI] Format code according to conventions (qmk#12650) * feat: infinite timeout for leader key (qmk#6580) * feat: implement leader_no_timeout logic * docs(leader_key): infinite leader timeout docs * Format code according to conventions (qmk#12680) * Update ADC driver for STM32F1xx, STM32F3xx, STM32F4xx (qmk#12403) * Fix default ADC_RESOLUTION for ADCv3 (and ADCv4) Recent ChibiOS update removed ADC_CFGR1_RES_10BIT from the ADCv3 headers (that macro should not have been there, because ADCv3 has CFGR instead of CFGR1). Fix the default value for ADC_RESOLUTION to use ADC_CFGR_RES_10BITS if it is defined (that name is used for ADCv3 and ADCv4). * Update ADC docs to match the actually used resolution ADC driver for ChibiOS actually uses the 10-bit resolution by default (probably to match AVR); fix the documentation accordingly. Also add both ADC_CFGR_RES_10BITS and ADC_CFGR1_RES_10BIT constants (these names differ according to the ADC implementation in the particular MCU). * Fix pinToMux() for B12 and B13 on STM32F3xx Testing on STM32F303CCT6 revealed that the ADC mux values for B12 and B13 pins were wrong. * Add support for all possible analog pins on STM32F1xx Added ADC mux values for pins A0...A7, B0, B1, C0...C5 on STM32F1xx (they are the same at least for STM32F103x8 and larger F103 devices, and also F102, F105, F107 families). Actually tested on STM32F103C8T6 (therefore pins C0...C5 were not tested). Pins F6...F10, which are present on STM32F103x[C-G] in 144-pin packages, cannot be supported at the moment, because those pins are connected only to ADC3, but the ChibiOS ADC driver for STM32F1xx supports only ADC1. * Add support for all possible analog pins on STM32F4xx Added ADC mux values for pins A0...A7, B0, B1, C0...C5 and optionally F3...F10 (if STM32_ADC_USE_ADC3 is enabled). These mux values are apparently the same for all F4xx devices, except some smaller devices may not have ADC3. Actually tested on STM32F401CCU6, STM32F401CEU6, STM32F411CEU6 (using various WeAct “Blackpill” boards); only pins A0...A7, B0, B1 were tested. Pins F3...F10 are inside `#if STM32_ADC_USE_ADC3` because some devices which don't have ADC3 also don't have the GPIOF port, therefore the code which refers to Fx pins does not compile. * Fix STM32F3xx ADC mux table in documentation The ADC driver documentation had some errors in the mux table for STM32F3xx. Fix this table to match the datasheet and the actual code (mux settings for B12 and B13 were also tested on a real STM32F303CCT6 chip). * Add STM32F1xx ADC pins to the documentation * Add STM32F4xx ADC pins to the documentation * Add initial support for tinyuf2 bootloader (when hosted on F411 blackpill) (qmk#12600) * Add support for jumping to tinyuf2 bootloader. Adds blackpill UF2 example. * Update flashing.md * Update chconf.h * Update config.h * Update halconf.h * Update mcuconf.h * eeprom driver: Refactor where eeprom driver initialisation (and EEPROM emulation initialisation) occurs to make it non-target-specific. (qmk#12671) * Add support for MCU = STM32F446 (qmk#12619) * Add support for MCU = STM32F446 * Update platforms/chibios/GENERIC_STM32_F446XE/configs/config.h * Restore mcuconf.h to the one used by RT-STM32F446RE-NUCLEO64 * stm32f446: update mcuconf.h and board.h for 16MHz operation, with USB enabled, and other peripherals disabled. * Format code according to conventions (qmk#12682) * Format code according to conventions (qmk#12687) * Add STM32L433 and L443 support (qmk#12063) * initial L433 commit * change to XC * fix L433 * disable all peripherals * update system and peripheral clocks * 433 change * use its own board files * revert its own board files * l433 specific change * fix stm32l432xx define * remove duplicate #define * fix bootloader jump * move to L443xx and add i2c2, spi2, usart3 to mcuconf.h * move to L443 * move to L443 * fix sdmmc in mcuconf.h * include STM32L443 * add L443 * Include L443 in compatible microcontrollers * Include L443 in compatible microcontrollers * Update config bootloader jump description * Update ChibiOS define reasoning * Update quantum/mcu_selection.mk * fix git conflict * Updated Function96 with V2 files and removed chconf.h and halconf.h (qmk#12613) * Fix bad PR merge for qmk#6580. (qmk#12721) * Change RGB/LED Matrix to use a simple define for USB suspend (qmk#12697) * [CI] Format code according to conventions (qmk#12731) * Fixing transport's led/rgb matrix suspend state logic (qmk#12770) * [CI] Format code according to conventions (qmk#12772) * Fix comment parsing (qmk#12750) * Added OLED fade out support (qmk#12086) * fix some references to bin/qmk that slipped in (qmk#12832) * Resolve a number of warnings in `qmk generate-api` (qmk#12833) * New command: qmk console (qmk#12828) * stash poc * stash * tidy up implementation * Tidy up slightly for review * Tidy up slightly for review * Bodge environment to make tests pass * Refactor away from asyncio due to windows issues * Filter devices * align vid/pid printing * Add hidapi to the installers * start preparing for multiple hid_listeners * udev rules for hid_listen * refactor to move closer to end state * very basic implementation of the threaded model * refactor how vid/pid/index are supplied and parsed * windows improvements * read the report directly when usage page isn't available * add per-device colors, the choice to show names or numbers, and refactor * add timestamps * Add support for showing bootloaders * tweak the color for bootloaders * Align bootloader disconnect with connect color * add support for showing all bootloaders * fix the pyusb check * tweaks * fix exception * hide a stack trace behind -v * add --no-bootloaders option * add documentation for qmk console * Apply suggestions from code review * pyformat * clean up and flesh out KNOWN_BOOTLOADERS * Remove pointless SERIAL_LINK_ENABLE rules (qmk#12846) * Make Swap Hands use PROGMEM (qmk#12284) This converts the array that the Swap Hands feature uses to use PROGMEM, and to read from that array, as such. Since this array never changes at runtime, there is no reason to keep it in memory. Especially for AVR boards, as memory is a precious resource. * Fix another bin/qmk reference (qmk#12856) * [Keymap] Turn OLED off on suspend in soundmonster keymap (qmk#10419) * Fixup build errors on `develop` branch. (qmk#12723) * LED Matrix: Effects! (qmk#12651) * Fix syntax error when compiling for ARM (qmk#12866) * Remove KEYMAP and LAYOUT_kc (qmk#12160) * alias KEYMAP to LAYOUT * remove KEYMAP and LAYOUT_kc * Add setup, clone, and env to the list of commands we allow even with broken modules (qmk#12868) * Rename `point_t` -> `led_point_t` (qmk#12864) * [Keyboard] updated a vendor name / fixed minor keymap issues (qmk#12881) * Add missing LED Matrix suspend code to suspend.c (qmk#12878) * LED Matrix: Documentation (qmk#12685) * Deprecate `send_unicode_hex_string()` (qmk#12602) * Fix spelling mistake regarding LED Matrix in split_common. (qmk#12888) * [Keymap] Fix QWERTY/DVORAK status output for kzar keymap (qmk#12895) * Use milc.subcommand.config instead of qmk.cli.config (qmk#12915) * Use milc.subcommand.config instead * pyformat * remove the config test * Add function to allow repeated blinking of one layer (qmk#12237) * Implement function rgblight_blink_layer_repeat to allow repeated blinking of one layer at a time * Update doc * Rework rgblight blinking according to requested change * optimize storage * Fixup housekeeping from being invoked twice per loop. (qmk#12933) * matrix: wait for row signal to go HIGH for every row (qmk#12945) I noticed this discrepancy (last row of the matrix treated differently than the others) when optimizing the input latency of my keyboard controller, see also https://michael.stapelberg.ch/posts/2021-05-08-keyboard-input-latency-qmk-kinesis/ Before this commit, when tuning the delays I noticed ghost key presses when pressing the F2 key, which is on the last row of the keyboard matrix: the dead_grave key, which is on the first row of the keyboard matrix, would be incorrectly detected as pressed. After this commit, all keyboard matrix rows are interpreted correctly. I suspect that my setup is more susceptible to this nuance than others because I use GPIO_INPUT_PIN_DELAY=0 and hence don’t have another delay that might mask the problem. * ensure we do not conflict with existing keymap aliases (qmk#12976) * Add support for up to 4 IS31FL3733 drivers (qmk#12342) * Convert Encoder callbacks to be boolean functions (qmk#12805) * [Keyboard] Fix Terrazzo build failure (qmk#12977) * Do not hard set config in CPTC files (qmk#11864) * [Keyboard] Corne - Remove legacy revision support (qmk#12226) * [Keymap] Update to Drashna keymap and user code (based on develop) (qmk#12936) * Add Full-duplex serial driver for ARM boards (qmk#9842) * Document LED_MATRIX_FRAMEBUFFER_EFFECTS (qmk#12987) * Backlight: add defines for default level and breathing state (qmk#12560) * Add dire message about LUFA mass storage bootloader (qmk#13014) * [Keyboard] Remove redundant legacy and common headers for crkbd (qmk#13023) Was causing compiler errors on some systems. * Fix keyboards/keymaps for boolean encoder callback changes (qmk#12985) * `backlight.c`: include `eeprom.h` (qmk#13024) * Add changelog for 2021-05-29 Breaking Changes merge (qmk#12939) * Add ChangeLog for 2021-05-29 Breaking Changes Merge: initial version * Add recent develop changes * Sort recent develop changes * Remove sections for ChibiOS changes per tzarc No ChibiOS changes this round. * Add and sort recent develop changes * add notes about keyboard moves/deletions * import changelog for PR 12172 Documents the change to BOOTMAGIC_ENABLE. * update section headings * re-sort changelog * add additional note regarding Bootmagic changes * remove changelog timestamp * update dates in main Breaking Changes docs * fix broken section anchors in previous changelogs * add link to backlight/eeprom patch to changelog * highlight some more changes * link PRs from section headers * Restore standard readme * run: qmk cformat --core-only
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
* feat: implement leader_no_timeout logic * docs(leader_key): infinite leader timeout docs
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
* Add Per Key functionality for AutoShift (qmk#11536) * LED Matrix: Reactive effect buffers & advanced indicators (qmk#12588) * [Keyboard] kint36: switch to sym_eager_pk debouncing (qmk#12626) * [Keyboard] kint2pp: reduce input latency by ≈10ms (qmk#12625) * LED Matrix: Split (qmk#12633) * [CI] Format code according to conventions (qmk#12650) * feat: infinite timeout for leader key (qmk#6580) * feat: implement leader_no_timeout logic * docs(leader_key): infinite leader timeout docs * Format code according to conventions (qmk#12680) * Update ADC driver for STM32F1xx, STM32F3xx, STM32F4xx (qmk#12403) * Fix default ADC_RESOLUTION for ADCv3 (and ADCv4) Recent ChibiOS update removed ADC_CFGR1_RES_10BIT from the ADCv3 headers (that macro should not have been there, because ADCv3 has CFGR instead of CFGR1). Fix the default value for ADC_RESOLUTION to use ADC_CFGR_RES_10BITS if it is defined (that name is used for ADCv3 and ADCv4). * Update ADC docs to match the actually used resolution ADC driver for ChibiOS actually uses the 10-bit resolution by default (probably to match AVR); fix the documentation accordingly. Also add both ADC_CFGR_RES_10BITS and ADC_CFGR1_RES_10BIT constants (these names differ according to the ADC implementation in the particular MCU). * Fix pinToMux() for B12 and B13 on STM32F3xx Testing on STM32F303CCT6 revealed that the ADC mux values for B12 and B13 pins were wrong. * Add support for all possible analog pins on STM32F1xx Added ADC mux values for pins A0...A7, B0, B1, C0...C5 on STM32F1xx (they are the same at least for STM32F103x8 and larger F103 devices, and also F102, F105, F107 families). Actually tested on STM32F103C8T6 (therefore pins C0...C5 were not tested). Pins F6...F10, which are present on STM32F103x[C-G] in 144-pin packages, cannot be supported at the moment, because those pins are connected only to ADC3, but the ChibiOS ADC driver for STM32F1xx supports only ADC1. * Add support for all possible analog pins on STM32F4xx Added ADC mux values for pins A0...A7, B0, B1, C0...C5 and optionally F3...F10 (if STM32_ADC_USE_ADC3 is enabled). These mux values are apparently the same for all F4xx devices, except some smaller devices may not have ADC3. Actually tested on STM32F401CCU6, STM32F401CEU6, STM32F411CEU6 (using various WeAct “Blackpill” boards); only pins A0...A7, B0, B1 were tested. Pins F3...F10 are inside `#if STM32_ADC_USE_ADC3` because some devices which don't have ADC3 also don't have the GPIOF port, therefore the code which refers to Fx pins does not compile. * Fix STM32F3xx ADC mux table in documentation The ADC driver documentation had some errors in the mux table for STM32F3xx. Fix this table to match the datasheet and the actual code (mux settings for B12 and B13 were also tested on a real STM32F303CCT6 chip). * Add STM32F1xx ADC pins to the documentation * Add STM32F4xx ADC pins to the documentation * Add initial support for tinyuf2 bootloader (when hosted on F411 blackpill) (qmk#12600) * Add support for jumping to tinyuf2 bootloader. Adds blackpill UF2 example. * Update flashing.md * Update chconf.h * Update config.h * Update halconf.h * Update mcuconf.h * eeprom driver: Refactor where eeprom driver initialisation (and EEPROM emulation initialisation) occurs to make it non-target-specific. (qmk#12671) * Add support for MCU = STM32F446 (qmk#12619) * Add support for MCU = STM32F446 * Update platforms/chibios/GENERIC_STM32_F446XE/configs/config.h * Restore mcuconf.h to the one used by RT-STM32F446RE-NUCLEO64 * stm32f446: update mcuconf.h and board.h for 16MHz operation, with USB enabled, and other peripherals disabled. * Format code according to conventions (qmk#12682) * Format code according to conventions (qmk#12687) * Add STM32L433 and L443 support (qmk#12063) * initial L433 commit * change to XC * fix L433 * disable all peripherals * update system and peripheral clocks * 433 change * use its own board files * revert its own board files * l433 specific change * fix stm32l432xx define * remove duplicate #define * fix bootloader jump * move to L443xx and add i2c2, spi2, usart3 to mcuconf.h * move to L443 * move to L443 * fix sdmmc in mcuconf.h * include STM32L443 * add L443 * Include L443 in compatible microcontrollers * Include L443 in compatible microcontrollers * Update config bootloader jump description * Update ChibiOS define reasoning * Update quantum/mcu_selection.mk * fix git conflict * Updated Function96 with V2 files and removed chconf.h and halconf.h (qmk#12613) * Fix bad PR merge for qmk#6580. (qmk#12721) * Change RGB/LED Matrix to use a simple define for USB suspend (qmk#12697) * [CI] Format code according to conventions (qmk#12731) * Fixing transport's led/rgb matrix suspend state logic (qmk#12770) * [CI] Format code according to conventions (qmk#12772) * Fix comment parsing (qmk#12750) * Added OLED fade out support (qmk#12086) * fix some references to bin/qmk that slipped in (qmk#12832) * Resolve a number of warnings in `qmk generate-api` (qmk#12833) * New command: qmk console (qmk#12828) * stash poc * stash * tidy up implementation * Tidy up slightly for review * Tidy up slightly for review * Bodge environment to make tests pass * Refactor away from asyncio due to windows issues * Filter devices * align vid/pid printing * Add hidapi to the installers * start preparing for multiple hid_listeners * udev rules for hid_listen * refactor to move closer to end state * very basic implementation of the threaded model * refactor how vid/pid/index are supplied and parsed * windows improvements * read the report directly when usage page isn't available * add per-device colors, the choice to show names or numbers, and refactor * add timestamps * Add support for showing bootloaders * tweak the color for bootloaders * Align bootloader disconnect with connect color * add support for showing all bootloaders * fix the pyusb check * tweaks * fix exception * hide a stack trace behind -v * add --no-bootloaders option * add documentation for qmk console * Apply suggestions from code review * pyformat * clean up and flesh out KNOWN_BOOTLOADERS * Remove pointless SERIAL_LINK_ENABLE rules (qmk#12846) * Make Swap Hands use PROGMEM (qmk#12284) This converts the array that the Swap Hands feature uses to use PROGMEM, and to read from that array, as such. Since this array never changes at runtime, there is no reason to keep it in memory. Especially for AVR boards, as memory is a precious resource. * Fix another bin/qmk reference (qmk#12856) * [Keymap] Turn OLED off on suspend in soundmonster keymap (qmk#10419) * Fixup build errors on `develop` branch. (qmk#12723) * LED Matrix: Effects! (qmk#12651) * Fix syntax error when compiling for ARM (qmk#12866) * Remove KEYMAP and LAYOUT_kc (qmk#12160) * alias KEYMAP to LAYOUT * remove KEYMAP and LAYOUT_kc * Add setup, clone, and env to the list of commands we allow even with broken modules (qmk#12868) * Rename `point_t` -> `led_point_t` (qmk#12864) * [Keyboard] updated a vendor name / fixed minor keymap issues (qmk#12881) * Add missing LED Matrix suspend code to suspend.c (qmk#12878) * LED Matrix: Documentation (qmk#12685) * Deprecate `send_unicode_hex_string()` (qmk#12602) * Fix spelling mistake regarding LED Matrix in split_common. (qmk#12888) * [Keymap] Fix QWERTY/DVORAK status output for kzar keymap (qmk#12895) * Use milc.subcommand.config instead of qmk.cli.config (qmk#12915) * Use milc.subcommand.config instead * pyformat * remove the config test * Add function to allow repeated blinking of one layer (qmk#12237) * Implement function rgblight_blink_layer_repeat to allow repeated blinking of one layer at a time * Update doc * Rework rgblight blinking according to requested change * optimize storage * Fixup housekeeping from being invoked twice per loop. (qmk#12933) * matrix: wait for row signal to go HIGH for every row (qmk#12945) I noticed this discrepancy (last row of the matrix treated differently than the others) when optimizing the input latency of my keyboard controller, see also https://michael.stapelberg.ch/posts/2021-05-08-keyboard-input-latency-qmk-kinesis/ Before this commit, when tuning the delays I noticed ghost key presses when pressing the F2 key, which is on the last row of the keyboard matrix: the dead_grave key, which is on the first row of the keyboard matrix, would be incorrectly detected as pressed. After this commit, all keyboard matrix rows are interpreted correctly. I suspect that my setup is more susceptible to this nuance than others because I use GPIO_INPUT_PIN_DELAY=0 and hence don’t have another delay that might mask the problem. * ensure we do not conflict with existing keymap aliases (qmk#12976) * Add support for up to 4 IS31FL3733 drivers (qmk#12342) * Convert Encoder callbacks to be boolean functions (qmk#12805) * [Keyboard] Fix Terrazzo build failure (qmk#12977) * Do not hard set config in CPTC files (qmk#11864) * [Keyboard] Corne - Remove legacy revision support (qmk#12226) * [Keymap] Update to Drashna keymap and user code (based on develop) (qmk#12936) * Add Full-duplex serial driver for ARM boards (qmk#9842) * Document LED_MATRIX_FRAMEBUFFER_EFFECTS (qmk#12987) * Backlight: add defines for default level and breathing state (qmk#12560) * Add dire message about LUFA mass storage bootloader (qmk#13014) * [Keyboard] Remove redundant legacy and common headers for crkbd (qmk#13023) Was causing compiler errors on some systems. * Fix keyboards/keymaps for boolean encoder callback changes (qmk#12985) * `backlight.c`: include `eeprom.h` (qmk#13024) * Add changelog for 2021-05-29 Breaking Changes merge (qmk#12939) * Add ChangeLog for 2021-05-29 Breaking Changes Merge: initial version * Add recent develop changes * Sort recent develop changes * Remove sections for ChibiOS changes per tzarc No ChibiOS changes this round. * Add and sort recent develop changes * add notes about keyboard moves/deletions * import changelog for PR 12172 Documents the change to BOOTMAGIC_ENABLE. * update section headings * re-sort changelog * add additional note regarding Bootmagic changes * remove changelog timestamp * update dates in main Breaking Changes docs * fix broken section anchors in previous changelogs * add link to backlight/eeprom patch to changelog * highlight some more changes * link PRs from section headers * Restore standard readme * run: qmk cformat --core-only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds an infinite timeout to the leder key while keeping the rest of the keys under the normal timeout. In my case (and I think some others) the leader key is not as accesible to other keys on the home row. For that reason it is hard to me to complete the sequence after hitting the leader key. This allows you to hit the leader key on a relaxed way and then just hit the sequence using keys that are easier/faster to type. Something very similar to one shot mods.
Types of Changes
Issues Fixed or Closed by This PR
Checklist