Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand bootloader target to support most AVR boards #6255

Merged
merged 3 commits into from
Jul 16, 2019

Conversation

drashna
Copy link
Member

@drashna drashna commented Jul 5, 2019

This expands the :bootloader target, so that it should work with any non-V-USB AVR device. Primarily, the ATMega32U4 and the AT90USB1286 boards.

This is accomplished by soft setting the settings in the makefile for LUFA's DFU firmware, and passing along the needed values to make.

Types of Changes

  • Core
  • Enhancement/optimization

Issues Fixed or Closed by This PR

big thanks to @yanfali for helping me figure out the mess of make commands to get this working.

@yanfali
Copy link
Contributor

yanfali commented Jul 5, 2019

Oh, you got it working! Good work.

Copy link
Contributor

@yanfali yanfali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on an 8Mhz pro micro. now it works.

@yanfali
Copy link
Contributor

yanfali commented Jul 5, 2019

ok spoke too soon. They won't go back into bootloader.

Copy link
Contributor

@yanfali yanfali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to figure out why they won't return to bootloader

Copy link
Contributor

@yanfali yanfali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

false alarm, just had a bad flag

@drashna
Copy link
Member Author

drashna commented Jul 5, 2019

lol. Yeah, sounds like the issue was a fuse setting issue.

@skullydazed skullydazed merged commit f859375 into qmk:master Jul 16, 2019
@drashna drashna deleted the feature/at90_qmk_dfu branch July 16, 2019 08:36
drashna added a commit to zsa/qmk_firmware that referenced this pull request Jul 16, 2019
* Update the :bootloader target to pass along correct hardware info

* Update make scripts to properly grab the settings (a big thanks to @yanfali)

* Remove LUFA debug warnings
fdidron pushed a commit to zsa/qmk_firmware that referenced this pull request Jul 19, 2019
* Update the :bootloader target to pass along correct hardware info

* Update make scripts to properly grab the settings (a big thanks to @yanfali)

* Remove LUFA debug warnings
doughsay pushed a commit to doughsay/qmk_firmware that referenced this pull request Aug 31, 2019
* Update the :bootloader target to pass along correct hardware info

* Update make scripts to properly grab the settings (a big thanks to @yanfali)

* Remove LUFA debug warnings
swanmatch pushed a commit to swanmatch/qmk_firmware that referenced this pull request Sep 3, 2019
* Update the :bootloader target to pass along correct hardware info

* Update make scripts to properly grab the settings (a big thanks to @yanfali)

* Remove LUFA debug warnings
ripxorip pushed a commit to ripxorip/qmk_firmware that referenced this pull request Dec 3, 2019
* Update the :bootloader target to pass along correct hardware info

* Update make scripts to properly grab the settings (a big thanks to @yanfali)

* Remove LUFA debug warnings
ridingqwerty pushed a commit to ridingqwerty/qmk_firmware that referenced this pull request Jan 10, 2020
* Update the :bootloader target to pass along correct hardware info

* Update make scripts to properly grab the settings (a big thanks to @yanfali)

* Remove LUFA debug warnings
swamp09 pushed a commit to swamp09/qmk_firmware that referenced this pull request Mar 11, 2020
* Update the :bootloader target to pass along correct hardware info

* Update make scripts to properly grab the settings (a big thanks to @yanfali)

* Remove LUFA debug warnings
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
* Update the :bootloader target to pass along correct hardware info

* Update make scripts to properly grab the settings (a big thanks to @yanfali)

* Remove LUFA debug warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expand :bootloader target to use keyboard's hardware config
3 participants