Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Keyboard(s): Red Scarf II+ RS68 and RS78 #6084

Merged
merged 18 commits into from
Jun 7, 2019
Merged

New Keyboard(s): Red Scarf II+ RS68 and RS78 #6084

merged 18 commits into from
Jun 7, 2019

Conversation

mechmerlin
Copy link
Contributor

@mechmerlin mechmerlin commented Jun 6, 2019 •
edited
Loading

Description

Leveraging off of @Maartenwut code that he sent me.

I put in support for the RS68 (VerC) which uses the same matrix as the RS78.

Filing the PR now just to separate more of the changes. Will still need to put in VerA and VerD along with lighting support.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

This fixes PR #1025

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

fauxpark
fauxpark requested changes Jun 6, 2019
View reviewed changes
keyboards/redscarf_iiplus/verb/config.h Outdated Show resolved Hide resolved
keyboards/redscarf_iiplus/verc/config.h Outdated Show resolved Hide resolved
noroadsleft
noroadsleft reviewed Jun 6, 2019
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ver.C doesn't use row 5 at all; seems to me you should be able to shrink its matrix. (Might require editing its matrix.c to quicken the loop, but that's above my skill set.)

keyboards/redscarf_iiplus/verc/config.h Show resolved Hide resolved
keyboards/redscarf_iiplus/verc/verc.h Show resolved Hide resolved
keyboards/redscarf_iiplus/verc/verc.h Show resolved Hide resolved
@mechmerlin
Copy link
Contributor Author

Ver.C doesn't use row 5 at all; seems to me you should be able to shrink its matrix. (Might require editing its matrix.c to quicken the loop, but that's above my skill set.)

I'm planning on decoupling the matrix.c and matrix definitions in a future PR to be more generic across all these boards. Id rather not make this a "custom electrical matrix".

noroadsleft
noroadsleft approved these changes Jun 6, 2019
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

@mechmerlin
Copy link
Contributor Author

This is actually not a LAYOUT_65_ansi layout, I'm going to have to poke at the PCB a bit and change the names here.

@noroadsleft
Copy link
Member

noroadsleft commented Jun 6, 2019 •
edited
Loading

This is actually not a LAYOUT_65_ansi layout, I'm going to have to poke at the PCB a bit and change the names here.

Good spot, Merlin. Split Backspace seems to be the only difference, so the layout is supported in hardware, just not in the code. I'm fine with this for your purposes; I can tackle it later if desired.

@mechmerlin
Copy link
Contributor Author

All should be good now. =)

drashna
drashna approved these changes Jun 7, 2019
View reviewed changes
Copy link
Member

@drashna drashna left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No RGB?!?! No pass. :D

J/k. Looks good!

@drashna drashna merged commit 2cb3232 into qmk:master Jun 7, 2019
@mechmerlin mechmerlin deleted the feature/redscarf branch June 8, 2019 15:51
Timbus pushed a commit to Timbus/qmk_firmware that referenced this pull request Jun 23, 2019
@mechmerlin @Timbus
[Keyboard] New Keyboard(s): Red Scarf II+ RS68 and RS78 (qmk#6084)
52a6ffa 
* martenwuut's original code commit

* delete random directory that is the same as the parent directory

* get this compiling

* update readmes

* add manufacturer

* fix up the keymap error and replace KC_A with KC_1

* add verc support which is basically just at trimmed down verb

* update keymap readme to specify which redscarf it is

* add parent level readme

* fix grammar

* fix up readmes and put in alternative name for PCBs

* add configurator support for the ver.c pcb

* add configurator support for Ver.B (RS78) pcb

* add iso support for Ver.C (RS68)

* change DEBOUNCING_DELAY to just DEBOUNCE

* remove K2C to fit the default layouts

* fix keymap

* fixup configurator layout with split backspace
doughsay pushed a commit to doughsay/qmk_firmware that referenced this pull request Aug 31, 2019
@mechmerlin @doughsay
[Keyboard] New Keyboard(s): Red Scarf II+ RS68 and RS78 (qmk#6084)
26c013b 
* martenwuut's original code commit

* delete random directory that is the same as the parent directory

* get this compiling

* update readmes

* add manufacturer

* fix up the keymap error and replace KC_A with KC_1

* add verc support which is basically just at trimmed down verb

* update keymap readme to specify which redscarf it is

* add parent level readme

* fix grammar

* fix up readmes and put in alternative name for PCBs

* add configurator support for the ver.c pcb

* add configurator support for Ver.B (RS78) pcb

* add iso support for Ver.C (RS68)

* change DEBOUNCING_DELAY to just DEBOUNCE

* remove K2C to fit the default layouts

* fix keymap

* fixup configurator layout with split backspace
ridingqwerty pushed a commit to ridingqwerty/qmk_firmware that referenced this pull request Jan 10, 2020
@mechmerlin @drashna
[Keyboard] New Keyboard(s): Red Scarf II+ RS68 and RS78 (qmk#6084)
909bb28 
* martenwuut's original code commit

* delete random directory that is the same as the parent directory

* get this compiling

* update readmes

* add manufacturer

* fix up the keymap error and replace KC_A with KC_1

* add verc support which is basically just at trimmed down verb

* update keymap readme to specify which redscarf it is

* add parent level readme

* fix grammar

* fix up readmes and put in alternative name for PCBs

* add configurator support for the ver.c pcb

* add configurator support for Ver.B (RS78) pcb

* add iso support for Ver.C (RS68)

* change DEBOUNCING_DELAY to just DEBOUNCE

* remove K2C to fit the default layouts

* fix keymap

* fixup configurator layout with split backspace
JeffreyPalmer pushed a commit to JeffreyPalmer/qmk_firmware that referenced this pull request Feb 27, 2020
@mechmerlin @JeffreyPalmer
[Keyboard] New Keyboard(s): Red Scarf II+ RS68 and RS78 (qmk#6084)
2206366 
* martenwuut's original code commit

* delete random directory that is the same as the parent directory

* get this compiling

* update readmes

* add manufacturer

* fix up the keymap error and replace KC_A with KC_1

* add verc support which is basically just at trimmed down verb

* update keymap readme to specify which redscarf it is

* add parent level readme

* fix grammar

* fix up readmes and put in alternative name for PCBs

* add configurator support for the ver.c pcb

* add configurator support for Ver.B (RS78) pcb

* add iso support for Ver.C (RS68)

* change DEBOUNCING_DELAY to just DEBOUNCE

* remove K2C to fit the default layouts

* fix keymap

* fixup configurator layout with split backspace
swamp09 pushed a commit to swamp09/qmk_firmware that referenced this pull request Mar 11, 2020
@mechmerlin @swamp09
[Keyboard] New Keyboard(s): Red Scarf II+ RS68 and RS78 (qmk#6084)
74f7c4c 
* martenwuut's original code commit

* delete random directory that is the same as the parent directory

* get this compiling

* update readmes

* add manufacturer

* fix up the keymap error and replace KC_A with KC_1

* add verc support which is basically just at trimmed down verb

* update keymap readme to specify which redscarf it is

* add parent level readme

* fix grammar

* fix up readmes and put in alternative name for PCBs

* add configurator support for the ver.c pcb

* add configurator support for Ver.B (RS78) pcb

* add iso support for Ver.C (RS68)

* change DEBOUNCING_DELAY to just DEBOUNCE

* remove K2C to fit the default layouts

* fix keymap

* fixup configurator layout with split backspace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark requested changes

@noroadsleft noroadsleft noroadsleft approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mechmerlin @noroadsleft @drashna @fauxpark